From: Lee Jones <lee.jones@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, shemminger@vyatta.com,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 9/9] Avoid 'statement with no effect' compiler warnings
Date: Sun, 4 Nov 2012 08:55:55 +0100 [thread overview]
Message-ID: <20121104075555.GB24262@gmail.com> (raw)
In-Reply-To: <20121104.010043.1842614952525101679.davem@davemloft.net>
On Sun, 04 Nov 2012, David Miller wrote:
> From: Lee Jones <lee.jones@linaro.org>
> Date: Sat, 3 Nov 2012 23:02:30 +0100
>
> > Instead of issuing (0) statements when !CONFIG_SYSFS which will cause
> > 'warning: ', we'll use inline statements instead. This will effectively
> > do the same thing, but suppress any unnecessary warnings.
> >
> > Cc: Stephen Hemminger <shemminger@vyatta.com>
> > Cc: bridge@lists.linux-foundation.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Applied, but please use more informative subject lines.
>
> You should prefix your subject line after [PATCH ...] with
> the name of the subsystem you are touching, a ": " then
> the headline description.
>
> So here you would have used "bridge: " and that's what I added when I
> commited this patch.
Yes, of course I should have done, and usually do.
This was an oversight, sorry about that.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [Bridge] [PATCH 9/9] Avoid 'statement with no effect' compiler warnings
Date: Sun, 4 Nov 2012 08:55:55 +0100 [thread overview]
Message-ID: <20121104075555.GB24262@gmail.com> (raw)
In-Reply-To: <20121104.010043.1842614952525101679.davem@davemloft.net>
On Sun, 04 Nov 2012, David Miller wrote:
> From: Lee Jones <lee.jones@linaro.org>
> Date: Sat, 3 Nov 2012 23:02:30 +0100
>
> > Instead of issuing (0) statements when !CONFIG_SYSFS which will cause
> > 'warning: ', we'll use inline statements instead. This will effectively
> > do the same thing, but suppress any unnecessary warnings.
> >
> > Cc: Stephen Hemminger <shemminger@vyatta.com>
> > Cc: bridge@lists.linux-foundation.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Applied, but please use more informative subject lines.
>
> You should prefix your subject line after [PATCH ...] with
> the name of the subsystem you are touching, a ": " then
> the headline description.
>
> So here you would have used "bridge: " and that's what I added when I
> commited this patch.
Yes, of course I should have done, and usually do.
This was an oversight, sorry about that.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-04 7:56 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 22:02 [PATCH 0/9] Fixups for issues when running 'make randconfig' Lee Jones
2012-11-03 22:02 ` [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure Lee Jones
2012-11-03 22:02 ` Lee Jones
2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
2012-11-03 22:02 ` Lee Jones
2012-11-04 10:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:57 ` Lee Jones
2012-11-04 10:57 ` Lee Jones
2012-11-05 8:13 ` Josh Wu
2012-11-05 8:13 ` Josh Wu
2012-11-05 8:19 ` Lee Jones
2012-11-05 8:19 ` Lee Jones
2012-11-03 22:02 ` [PATCH 3/9] x86: Suppress build warnings in quirks Lee Jones
2012-11-03 22:02 ` [PATCH 4/9] sched: Don't define unthrottle_offline_cfs_rqs when !CONFIG_SMP Lee Jones
2012-11-03 22:02 ` [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Lee Jones
2012-11-03 22:02 ` Lee Jones
2012-11-04 8:13 ` [alsa-devel] " Lars-Peter Clausen
2012-11-04 10:31 ` Lee Jones
2012-11-03 22:02 ` [PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning Lee Jones
2012-11-03 22:02 ` Lee Jones
2012-11-05 2:38 ` Rusty Russell
2012-11-05 2:38 ` Rusty Russell
2012-11-05 8:21 ` Lee Jones
2012-11-05 8:21 ` Lee Jones
2012-11-05 13:00 ` Pawel Moll
2012-11-05 13:00 ` Pawel Moll
2012-11-05 13:02 ` [PATCH] virtio-mmio: Fix irq parsing in command line parameter Pawel Moll
2012-11-05 13:02 ` Pawel Moll
2012-11-05 13:44 ` Lee Jones
2012-11-05 13:44 ` Lee Jones
2012-11-05 14:12 ` Pawel Moll
2012-11-05 14:12 ` Pawel Moll
2012-11-05 14:35 ` Lee Jones
2012-11-05 14:35 ` Lee Jones
2012-11-07 22:22 ` Rusty Russell
2012-11-08 9:48 ` Lee Jones
2012-11-08 12:23 ` Rusty Russell
2012-11-08 12:23 ` Rusty Russell
2012-11-07 14:18 ` [PATCH v2] virtio-mmio: Fix irq parsing in the command line Pawel Moll
2012-11-07 22:47 ` Rusty Russell
2012-11-08 19:05 ` [PATCH v3] virtio-mmio: Fix irq parsing in command line parameter Pawel Moll
2012-11-09 4:11 ` Rusty Russell
2012-11-03 22:02 ` [PATCH 7/9] quota: Use the pre-processor to compile out quotactl_cmd_write when !CONFIG_BLOCK Lee Jones
2012-11-06 23:06 ` Jan Kara
2012-11-03 22:02 ` [PATCH 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:40 ` Paul Bolle
2012-11-03 22:48 ` Lee Jones
2012-11-04 10:14 ` Paul Bolle
2012-11-04 10:53 ` Lee Jones
2012-11-04 17:30 ` David Miller
2012-11-04 17:30 ` David Miller
2012-11-05 8:44 ` Lee Jones
2012-11-05 9:11 ` Paul Bolle
2012-11-05 9:44 ` Lee Jones
2012-11-05 16:46 ` David Miller
2012-11-05 16:46 ` David Miller
2012-11-05 10:31 ` [PATCH 8/9] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES Lee Jones
2012-11-06 23:57 ` David Miller
2012-11-07 9:56 ` Lee Jones
2012-11-04 10:28 ` [PATCH v2 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:02 ` [PATCH 9/9] Avoid 'statement with no effect' compiler warnings Lee Jones
2012-11-03 22:02 ` [Bridge] " Lee Jones
2012-11-04 6:00 ` David Miller
2012-11-04 6:00 ` [Bridge] " David Miller
2012-11-04 7:55 ` Lee Jones [this message]
2012-11-04 7:55 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104075555.GB24262@gmail.com \
--to=lee.jones@linaro.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.