All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Xi Wang <xi.wang@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix NULL checking in dma_pool_create()
Date: Mon, 5 Nov 2012 12:37:38 -0800	[thread overview]
Message-ID: <20121105123738.0a0490a7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352097996-25808-1-git-send-email-xi.wang@gmail.com>

On Mon,  5 Nov 2012 01:46:36 -0500
Xi Wang <xi.wang@gmail.com> wrote:

> First, `dev' is dereferenced in dev_to_node(dev), suggesting that it
> must be non-null.  Later `dev' is checked against NULL, suggesting
> the opposite.  This patch adds a NULL check before its use.
> 
> ...
>
> @@ -159,7 +160,9 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
>  		return NULL;
>  	}
>  
> -	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
> +	node = dev ? dev_to_node(dev) : -1;
> +
> +	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, node);
>  	if (!retval)
>  		return retval;

Well, the dma_pool_create() kerneldoc does not describe dev==NULL to be
acceptable usage and given the lack of oops reports, we can assume that
no code is calling this function with dev==NULL.

So I think we can just remove the code which handles dev==NULL?

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Xi Wang <xi.wang@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix NULL checking in dma_pool_create()
Date: Mon, 5 Nov 2012 12:37:38 -0800	[thread overview]
Message-ID: <20121105123738.0a0490a7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352097996-25808-1-git-send-email-xi.wang@gmail.com>

On Mon,  5 Nov 2012 01:46:36 -0500
Xi Wang <xi.wang@gmail.com> wrote:

> First, `dev' is dereferenced in dev_to_node(dev), suggesting that it
> must be non-null.  Later `dev' is checked against NULL, suggesting
> the opposite.  This patch adds a NULL check before its use.
> 
> ...
>
> @@ -159,7 +160,9 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
>  		return NULL;
>  	}
>  
> -	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
> +	node = dev ? dev_to_node(dev) : -1;
> +
> +	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, node);
>  	if (!retval)
>  		return retval;

Well, the dma_pool_create() kerneldoc does not describe dev==NULL to be
acceptable usage and given the lack of oops reports, we can assume that
no code is calling this function with dev==NULL.

So I think we can just remove the code which handles dev==NULL?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-11-05 20:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05  6:46 [PATCH] mm: fix NULL checking in dma_pool_create() Xi Wang
2012-11-05  6:46 ` Xi Wang
2012-11-05 20:37 ` Andrew Morton [this message]
2012-11-05 20:37   ` Andrew Morton
2012-11-05 20:50   ` Xi Wang
2012-11-05 20:50     ` Xi Wang
2012-11-05 21:26     ` Andrew Morton
2012-11-05 21:26       ` Andrew Morton
2012-11-06 20:48       ` Xi Wang
2012-11-06 20:48         ` Xi Wang
2012-11-13 21:39 ` [PATCH v2] mm: fix null dev " Xi Wang
2012-11-13 21:39   ` Xi Wang
2012-11-13 23:01   ` David Rientjes
2012-11-13 23:01     ` David Rientjes
2012-11-14  0:47     ` Andrew Morton
2012-11-14  0:47       ` Andrew Morton
2012-11-14  0:58   ` Andrew Morton
2012-11-14  0:58     ` Andrew Morton
2012-11-14  5:50     ` Xi Wang
2012-11-14  5:50       ` Xi Wang
2012-11-14 14:17       ` Felipe Balbi
2012-11-14 14:17         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121105123738.0a0490a7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xi.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.