* Re: [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION
@ 2012-11-17 16:03 Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2012-11-17 16:03 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On (11/18/12 00:42), Namhyung Kim wrote:
> It was missed to update POWERTOP_VERSION macro so that the
> new v2.2 release still shows v2.1 string on the header of
> ncurses window. Convert to use PACKAGE_VERSION macro which
> set by autotools to the AC_INIT version so that it cannot
> be missed anymore.
>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
looks good to me, thanks.
-ss
> src/lib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib.h b/src/lib.h
> index 8cf4632..209421a 100644
> --- a/src/lib.h
> +++ b/src/lib.h
> @@ -35,8 +35,8 @@
>
> #define _(STRING) gettext(STRING)
>
> -#define POWERTOP_VERSION "v2.1"
> -#define POWERTOP_SHORT_VERSION "2.1"
> +#define POWERTOP_VERSION "v"PACKAGE_VERSION
> +#define POWERTOP_SHORT_VERSION PACKAGE_VERSION
>
>
> extern int get_max_cpu(void);
> --
> 1.7.9.2
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION
@ 2012-11-29 15:58 Chris Ferron
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ferron @ 2012-11-29 15:58 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On 11/17/2012 07:42 AM, Namhyung Kim wrote:
> It was missed to update POWERTOP_VERSION macro so that the
> new v2.2 release still shows v2.1 string on the header of
> ncurses window. Convert to use PACKAGE_VERSION macro which
> set by autotools to the AC_INIT version so that it cannot
> be missed anymore.
>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
> src/lib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib.h b/src/lib.h
> index 8cf4632..209421a 100644
> --- a/src/lib.h
> +++ b/src/lib.h
> @@ -35,8 +35,8 @@
>
> #define _(STRING) gettext(STRING)
>
> -#define POWERTOP_VERSION "v2.1"
> -#define POWERTOP_SHORT_VERSION "2.1"
> +#define POWERTOP_VERSION "v"PACKAGE_VERSION
> +#define POWERTOP_SHORT_VERSION PACKAGE_VERSION
>
>
> extern int get_max_cpu(void);
Your patch has been applied
-Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION
@ 2012-11-17 15:42 Namhyung Kim
0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2012-11-17 15:42 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
It was missed to update POWERTOP_VERSION macro so that the
new v2.2 release still shows v2.1 string on the header of
ncurses window. Convert to use PACKAGE_VERSION macro which
set by autotools to the AC_INIT version so that it cannot
be missed anymore.
Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
---
src/lib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib.h b/src/lib.h
index 8cf4632..209421a 100644
--- a/src/lib.h
+++ b/src/lib.h
@@ -35,8 +35,8 @@
#define _(STRING) gettext(STRING)
-#define POWERTOP_VERSION "v2.1"
-#define POWERTOP_SHORT_VERSION "2.1"
+#define POWERTOP_VERSION "v"PACKAGE_VERSION
+#define POWERTOP_SHORT_VERSION PACKAGE_VERSION
extern int get_max_cpu(void);
--
1.7.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-29 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-17 16:03 [Powertop] [PATCH] Use PACKAGE_VERSION for POWERTOP_VERSION Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2012-11-29 15:58 Chris Ferron
2012-11-17 15:42 Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.