From: Mark Rutland <mark.rutland@arm.com> To: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>, Dave Martin <dave.martin@linaro.org>, Kukjin Kim <kgene.kim@samsung.com>, Russell King <linux@arm.linux.org.uk>, Pawel Moll <Pawel.Moll@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, Tony Lindgren <tony@atomide.com>, Catalin Marinas <Catalin.Marinas@arm.com>, "devicetree-discuss@lists.ozlabs.org" <devicetree-discuss@lists.ozlabs.org>, Will Deacon <Will.Deacon@arm.com>, Amit Kucheria <amit.kucheria@linaro.org>, Grant Likely <grant.likely@secretlab.ca>, "rob.herring@calxeda.com" <rob.herring@calxeda.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, David Brown <davidb@codeaurora.org>, Magnus Damm <magnus.damm@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 2/5] ARM: kernel: add device tree init map function Date: Mon, 19 Nov 2012 11:02:35 +0000 [thread overview] Message-ID: <20121119110155.GA2816@e106331-lin.cambridge.arm.com> (raw) In-Reply-To: <1352983614-22924-3-git-send-email-lorenzo.pieralisi@arm.com> Hi, Just a couple of comments on the binding documentation. > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt > new file mode 100644 > index 0000000..1fab07a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cpus.txt > @@ -0,0 +1,78 @@ > +* ARM CPUs binding description > + > +The device tree allows to describe the layout of CPUs in a system through > +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > +defining properties for every cpu. > + > +Bindings for CPU nodes follow the ePAPR standard, available from: > + > +http://devicetree.org > + > +For the ARM architecture every CPU node must contain the following properties: > + > +- reg: property matching the CPU MPIDR[23:0] register bits > + reg[31:24] bits must be set to 0 > +- compatible: should be one of: > + "arm,arm1020" > + "arm,arm1020e" > + "arm,arm1022" > + "arm,arm1026" > + "arm,arm720" > + "arm,arm740" > + "arm,arm7tdmi" > + "arm,arm920" > + "arm,arm922" > + "arm,arm925" > + "arm,arm926" > + "arm,arm940" > + "arm,arm946" > + "arm,arm9tdmi" > + "arm,cortex-a5" > + "arm,cortex-a7" > + "arm,cortex-a8" > + "arm,cortex-a9" > + "arm,cortex-a15" > + "arm,arm1136" > + "arm,arm1156" > + "arm,arm1176" > + "arm,arm11mpcore" > + "faraday,fa526" > + "intel,sa110" > + "intel,sa1100" > + "marvell,feroceon" > + "marvell,mohawk" > + "marvell,xsc3" > + "marvell,xscale" > + > +Every cpu node is required to set its device_type to "cpu". Should this not be described at the start of the properties list? e.g: - device_type: must be "cpu" It'd be more consistent and harder to miss that way. > +Example: > + > + cpus { > + #size-cells = <0>; > + #address-cells = <1>; > + > + CPU0: cpu@0 { > + device_type = "cpu"; > + compatible = <arm, cortex-a15>; > + reg = <0x0>; > + }; > + > + CPU1: cpu@1 { > + device_type = "cpu"; > + compatible = <arm, cortex-a15>; > + reg = <0x1>; > + }; > + > + CPU2: cpu@100 { > + device_type = "cpu"; > + compatible = <arm, cortex-a7>; > + reg = <0x100>; > + }; > + > + CPU3: cpu@101 { > + device_type = "cpu"; > + compatible = <arm, cortex-a7>; > + reg = <0x101>; > + }; > + }; It looks like you missed the compatible strings here when fixing things up from v2. They should be: compatible = "arm,cortex-a15"; and: compatible = "arm,cortex-a7"; Otherwise, looks good! Thanks, Mark
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/5] ARM: kernel: add device tree init map function Date: Mon, 19 Nov 2012 11:02:35 +0000 [thread overview] Message-ID: <20121119110155.GA2816@e106331-lin.cambridge.arm.com> (raw) In-Reply-To: <1352983614-22924-3-git-send-email-lorenzo.pieralisi@arm.com> Hi, Just a couple of comments on the binding documentation. > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt > new file mode 100644 > index 0000000..1fab07a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cpus.txt > @@ -0,0 +1,78 @@ > +* ARM CPUs binding description > + > +The device tree allows to describe the layout of CPUs in a system through > +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > +defining properties for every cpu. > + > +Bindings for CPU nodes follow the ePAPR standard, available from: > + > +http://devicetree.org > + > +For the ARM architecture every CPU node must contain the following properties: > + > +- reg: property matching the CPU MPIDR[23:0] register bits > + reg[31:24] bits must be set to 0 > +- compatible: should be one of: > + "arm,arm1020" > + "arm,arm1020e" > + "arm,arm1022" > + "arm,arm1026" > + "arm,arm720" > + "arm,arm740" > + "arm,arm7tdmi" > + "arm,arm920" > + "arm,arm922" > + "arm,arm925" > + "arm,arm926" > + "arm,arm940" > + "arm,arm946" > + "arm,arm9tdmi" > + "arm,cortex-a5" > + "arm,cortex-a7" > + "arm,cortex-a8" > + "arm,cortex-a9" > + "arm,cortex-a15" > + "arm,arm1136" > + "arm,arm1156" > + "arm,arm1176" > + "arm,arm11mpcore" > + "faraday,fa526" > + "intel,sa110" > + "intel,sa1100" > + "marvell,feroceon" > + "marvell,mohawk" > + "marvell,xsc3" > + "marvell,xscale" > + > +Every cpu node is required to set its device_type to "cpu". Should this not be described at the start of the properties list? e.g: - device_type: must be "cpu" It'd be more consistent and harder to miss that way. > +Example: > + > + cpus { > + #size-cells = <0>; > + #address-cells = <1>; > + > + CPU0: cpu at 0 { > + device_type = "cpu"; > + compatible = <arm, cortex-a15>; > + reg = <0x0>; > + }; > + > + CPU1: cpu at 1 { > + device_type = "cpu"; > + compatible = <arm, cortex-a15>; > + reg = <0x1>; > + }; > + > + CPU2: cpu at 100 { > + device_type = "cpu"; > + compatible = <arm, cortex-a7>; > + reg = <0x100>; > + }; > + > + CPU3: cpu at 101 { > + device_type = "cpu"; > + compatible = <arm, cortex-a7>; > + reg = <0x101>; > + }; > + }; It looks like you missed the compatible strings here when fixing things up from v2. They should be: compatible = "arm,cortex-a15"; and: compatible = "arm,cortex-a7"; Otherwise, looks good! Thanks, Mark
next prev parent reply other threads:[~2012-11-19 11:02 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-15 12:46 [PATCH v3 0/5] ARM: multi-cluster aware boot protocol Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi 2012-11-15 12:46 ` [PATCH v3 1/5] ARM: kernel: smp_setup_processor_id() updates Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi 2012-11-15 13:49 ` Will Deacon 2012-11-15 13:49 ` Will Deacon 2012-11-15 14:18 ` Lorenzo Pieralisi 2012-11-15 14:18 ` Lorenzo Pieralisi [not found] ` <20121115141808.GA23513-7AyDDHkRsp3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2012-11-16 10:17 ` Vincent Guittot 2012-11-16 10:17 ` Vincent Guittot [not found] ` <1352983614-22924-2-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2012-11-19 3:08 ` Nicolas Pitre 2012-11-19 3:08 ` Nicolas Pitre 2012-11-15 12:46 ` [PATCH v3 2/5] ARM: kernel: add device tree init map function Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi [not found] ` <1352983614-22924-3-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2012-11-19 3:12 ` Nicolas Pitre 2012-11-19 3:12 ` Nicolas Pitre 2012-11-19 11:02 ` Mark Rutland [this message] 2012-11-19 11:02 ` Mark Rutland 2012-11-15 12:46 ` [PATCH v3 3/5] ARM: kernel: add cpu logical map DT init in setup_arch Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi [not found] ` <1352983614-22924-4-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2012-11-19 3:14 ` Nicolas Pitre 2012-11-19 3:14 ` Nicolas Pitre 2012-11-15 12:46 ` [PATCH v3 4/5] ARM: kernel: add logical mappings look-up Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi 2012-11-19 3:14 ` Nicolas Pitre 2012-11-19 3:14 ` Nicolas Pitre 2012-11-15 12:46 ` [PATCH v3 5/5] ARM: gic: use a private mapping for CPU target interfaces Lorenzo Pieralisi 2012-11-15 12:46 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20121119110155.GA2816@e106331-lin.cambridge.arm.com \ --to=mark.rutland@arm.com \ --cc=Catalin.Marinas@arm.com \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=Pawel.Moll@arm.com \ --cc=Will.Deacon@arm.com \ --cc=amit.kucheria@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=dave.martin@linaro.org \ --cc=davidb@codeaurora.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@arm.linux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=nicolas.pitre@linaro.org \ --cc=rob.herring@calxeda.com \ --cc=swarren@wwwdotorg.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.