* [Buildroot] [PATCH] libpcap: fix static build
@ 2012-11-21 13:11 Thomas Petazzoni
2012-11-21 14:12 ` Baruch Siach
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2012-11-21 13:11 UTC (permalink / raw)
To: buildroot
The libpcap package contained some interesting attempts to support a
static-only build, but it was not working:
http://autobuild.buildroot.org/results/01038d3b970092d894d2bae80679247e65722785/build-end.log
In fact the configure.in of libpcap has provision to support
--enable-shared/--disable-shared, but the generated configure script
in the libpcap package has not been regenerated with the configure.in
changes.
So basically, enabling LIBPCAP_AUTORECONF=YES ensures that the
configure script gets generated, which brings us a working
--enable-shared / --disable-shared.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/libpcap/libpcap.mk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
index 7a1d32f..468b064 100644
--- a/package/libpcap/libpcap.mk
+++ b/package/libpcap/libpcap.mk
@@ -9,12 +9,8 @@ LIBPCAP_SITE = http://www.tcpdump.org/release
LIBPCAP_LICENSE = BSD-3c
LIBPCAP_LICENSE_FILES = LICENSE
LIBPCAP_INSTALL_STAGING = YES
+LIBPCAP_AUTORECONF = YES
-# doesn't have an install-strip
-LIBPCAP_INSTALL_TARGET_OPT= DESTDIR="$(TARGET_DIR)" \
- $(if $(BR2_PREFER_STATIC_LIB),install,install-shared)
-LIBPCAP_INSTALL_STAGING_OPT= DESTDIR="$(STAGING_DIR)" install \
- $(if $(BR2_PREFER_STATIC_LIB),,install-shared)
LIBPCAP_DEPENDENCIES = zlib \
$(if $(BR2_PACKAGE_LIBUSB),libusb)
LIBPCAP_CONF_ENV = ac_cv_linux_vers=2 \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] libpcap: fix static build
2012-11-21 13:11 [Buildroot] [PATCH] libpcap: fix static build Thomas Petazzoni
@ 2012-11-21 14:12 ` Baruch Siach
0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2012-11-21 14:12 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, Nov 21, 2012 at 02:11:31PM +0100, Thomas Petazzoni wrote:
> The libpcap package contained some interesting attempts to support a
> static-only build, but it was not working:
>
> http://autobuild.buildroot.org/results/01038d3b970092d894d2bae80679247e65722785/build-end.log
>
> In fact the configure.in of libpcap has provision to support
> --enable-shared/--disable-shared, but the generated configure script
> in the libpcap package has not been regenerated with the configure.in
> changes.
>
> So basically, enabling LIBPCAP_AUTORECONF=YES ensures that the
> configure script gets generated, which brings us a working
> --enable-shared / --disable-shared.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/libpcap/libpcap.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
> index 7a1d32f..468b064 100644
> --- a/package/libpcap/libpcap.mk
> +++ b/package/libpcap/libpcap.mk
> @@ -9,12 +9,8 @@ LIBPCAP_SITE = http://www.tcpdump.org/release
> LIBPCAP_LICENSE = BSD-3c
> LIBPCAP_LICENSE_FILES = LICENSE
> LIBPCAP_INSTALL_STAGING = YES
> +LIBPCAP_AUTORECONF = YES
Please add a comment here to explain the need for autoreconf.
baruch
> -# doesn't have an install-strip
> -LIBPCAP_INSTALL_TARGET_OPT= DESTDIR="$(TARGET_DIR)" \
> - $(if $(BR2_PREFER_STATIC_LIB),install,install-shared)
> -LIBPCAP_INSTALL_STAGING_OPT= DESTDIR="$(STAGING_DIR)" install \
> - $(if $(BR2_PREFER_STATIC_LIB),,install-shared)
> LIBPCAP_DEPENDENCIES = zlib \
> $(if $(BR2_PACKAGE_LIBUSB),libusb)
> LIBPCAP_CONF_ENV = ac_cv_linux_vers=2 \
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-21 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-21 13:11 [Buildroot] [PATCH] libpcap: fix static build Thomas Petazzoni
2012-11-21 14:12 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.