[PATCH] ARM: decompress: remove unused ARCH_HAS_DECOMP_WDOG

[PATCH] ARM: decompress: remove unused ARCH_HAS_DECOMP_WDOG

[Shawn Guo]

ARCH_HAS_DECOMP_WDOG is only used in lib/inflate.c which is not
included in arch/arm/boot/compressed/decompress.c now.  That said,
ARCH_HAS_DECOMP_WDOG is not used at all.  Let's remove it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
Russell,

If you're fine with patch, I will send a follow-up patch to remove all
those arch_decomp_wdog() from platform uncompress.h which does nothing
at all.

Shawn

 arch/arm/boot/compressed/decompress.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/compressed/decompress.c b/arch/arm/boot/compressed/decompress.c
index 9deb56a..24b0475 100644
--- a/arch/arm/boot/compressed/decompress.c
+++ b/arch/arm/boot/compressed/decompress.c
@@ -13,8 +13,6 @@ extern void error(char *);
 #define STATIC static
 #define STATIC_RW_DATA	/* non-static please */
 
-#define ARCH_HAS_DECOMP_WDOG
-
 /* Diagnostic functions */
 #ifdef DEBUG
 #  define Assert(cond,msg) {if(!(cond)) error(msg);}
-- 
1.7.9.5

[PATCH] ARM: decompress: remove unused ARCH_HAS_DECOMP_WDOG

[Russell King - ARM Linux]

On Wed, Dec 12, 2012 at 09:01:17PM +0800, Shawn Guo wrote:
> ARCH_HAS_DECOMP_WDOG is only used in lib/inflate.c which is not
> included in arch/arm/boot/compressed/decompress.c now.  That said,
> ARCH_HAS_DECOMP_WDOG is not used at all.  Let's remove it.

There are some implementations of the watchdog callbacks - I wonder
if the change to the decompressor code has broken those and no one's
noticed.  They seem to be Samsung platforms.

[PATCH] ARM: decompress: remove unused ARCH_HAS_DECOMP_WDOG

[Shawn Guo]

On Wed, Dec 12, 2012 at 06:42:15PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 12, 2012 at 09:01:17PM +0800, Shawn Guo wrote:
> > ARCH_HAS_DECOMP_WDOG is only used in lib/inflate.c which is not
> > included in arch/arm/boot/compressed/decompress.c now.  That said,
> > ARCH_HAS_DECOMP_WDOG is not used at all.  Let's remove it.
> 
> There are some implementations of the watchdog callbacks - I wonder
> if the change to the decompressor code has broken those and no one's
> noticed.  They seem to be Samsung platforms.

I noticed the implementations on Samsung platforms.  But they are all
wrapped by CONFIG_S3C_BOOT_WATCHDOG which is not defined any where.
So if you agree with the patch, I will send another follow-up to
Samsung maintainer removing all those dead codes.

Shawn