* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-13 21:36 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2012-12-13 21:36 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-arm-kernel, linux-omap, netdev, Richard Cochran
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Otherwise we get the following error with at least omap2plus_defconfig:
drivers/net/ethernet/ti/cpts.c:30:24: error: plat/clock.h: No such file or directory
Signed-off-by: Tony Lindgren <tony@atomide.com
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -27,8 +27,6 @@
#include <linux/uaccess.h>
#include <linux/workqueue.h>
-#include <plat/clock.h>
-
#include "cpts.h"
#ifdef CONFIG_TI_CPTS
^ permalink raw reply [flat|nested] 10+ messages in thread
* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-13 21:36 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2012-12-13 21:36 UTC (permalink / raw)
To: linux-arm-kernel
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Otherwise we get the following error with at least omap2plus_defconfig:
drivers/net/ethernet/ti/cpts.c:30:24: error: plat/clock.h: No such file or directory
Signed-off-by: Tony Lindgren <tony@atomide.com
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -27,8 +27,6 @@
#include <linux/uaccess.h>
#include <linux/workqueue.h>
-#include <plat/clock.h>
-
#include "cpts.h"
#ifdef CONFIG_TI_CPTS
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cpts: Fix build error caused by include of plat/clock.h
2012-12-13 21:36 ` Tony Lindgren
@ 2012-12-14 7:13 ` Richard Cochran
-1 siblings, 0 replies; 10+ messages in thread
From: Richard Cochran @ 2012-12-14 7:13 UTC (permalink / raw)
To: Tony Lindgren; +Cc: David S. Miller, linux-arm-kernel, linux-omap, netdev
On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
> mistakenly included plat/clock.h that should not be included by drivers
> even if it exists.
Hasn't this already been fixed?
https://patchwork.kernel.org/patch/1810481/
http://www.spinics.net/lists/linux-omap/msg83132.html
Thanks,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-14 7:13 ` Richard Cochran
0 siblings, 0 replies; 10+ messages in thread
From: Richard Cochran @ 2012-12-14 7:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
> mistakenly included plat/clock.h that should not be included by drivers
> even if it exists.
Hasn't this already been fixed?
https://patchwork.kernel.org/patch/1810481/
http://www.spinics.net/lists/linux-omap/msg83132.html
Thanks,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cpts: Fix build error caused by include of plat/clock.h
2012-12-14 7:13 ` Richard Cochran
@ 2012-12-14 9:55 ` Koen Kooi
-1 siblings, 0 replies; 10+ messages in thread
From: Koen Kooi @ 2012-12-14 9:55 UTC (permalink / raw)
To: Richard Cochran
Cc: Tony Lindgren, David S. Miller, linux-arm-kernel, linux-omap, netdev
Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
> On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
>> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
>> mistakenly included plat/clock.h that should not be included by drivers
>> even if it exists.
>
> Hasn't this already been fixed?
>
> https://patchwork.kernel.org/patch/1810481/
> http://www.spinics.net/lists/linux-omap/msg83132.html
That patch didn't get applied, so it's still broken in Linus' tree :(
regards,
Koen
^ permalink raw reply [flat|nested] 10+ messages in thread
* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-14 9:55 ` Koen Kooi
0 siblings, 0 replies; 10+ messages in thread
From: Koen Kooi @ 2012-12-14 9:55 UTC (permalink / raw)
To: linux-arm-kernel
Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
> On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
>> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
>> mistakenly included plat/clock.h that should not be included by drivers
>> even if it exists.
>
> Hasn't this already been fixed?
>
> https://patchwork.kernel.org/patch/1810481/
> http://www.spinics.net/lists/linux-omap/msg83132.html
That patch didn't get applied, so it's still broken in Linus' tree :(
regards,
Koen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cpts: Fix build error caused by include of plat/clock.h
2012-12-14 9:55 ` Koen Kooi
@ 2012-12-14 11:09 ` Richard Cochran
-1 siblings, 0 replies; 10+ messages in thread
From: Richard Cochran @ 2012-12-14 11:09 UTC (permalink / raw)
To: Koen Kooi
Cc: Tony Lindgren, David S. Miller, linux-arm-kernel, linux-omap, netdev
On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
>
> Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
>
> > On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
> >> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
> >> mistakenly included plat/clock.h that should not be included by drivers
> >> even if it exists.
> >
> > Hasn't this already been fixed?
> >
> > https://patchwork.kernel.org/patch/1810481/
> > http://www.spinics.net/lists/linux-omap/msg83132.html
>
> That patch didn't get applied, so it's still broken in Linus' tree :(
In netdev's patchwork, this was marked "Not Applicable." Dave, can you
possibly take this patch? If not, who should I ask next?
Thanks,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-14 11:09 ` Richard Cochran
0 siblings, 0 replies; 10+ messages in thread
From: Richard Cochran @ 2012-12-14 11:09 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
>
> Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
>
> > On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
> >> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
> >> mistakenly included plat/clock.h that should not be included by drivers
> >> even if it exists.
> >
> > Hasn't this already been fixed?
> >
> > https://patchwork.kernel.org/patch/1810481/
> > http://www.spinics.net/lists/linux-omap/msg83132.html
>
> That patch didn't get applied, so it's still broken in Linus' tree :(
In netdev's patchwork, this was marked "Not Applicable." Dave, can you
possibly take this patch? If not, who should I ask next?
Thanks,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cpts: Fix build error caused by include of plat/clock.h
2012-12-14 11:09 ` Richard Cochran
@ 2012-12-14 18:18 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2012-12-14 18:18 UTC (permalink / raw)
To: richardcochran; +Cc: koen, tony, linux-arm-kernel, linux-omap, netdev
From: Richard Cochran <richardcochran@gmail.com>
Date: Fri, 14 Dec 2012 12:09:18 +0100
> On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
>>
>> Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
>>
>> > On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
>> >> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
>> >> mistakenly included plat/clock.h that should not be included by drivers
>> >> even if it exists.
>> >
>> > Hasn't this already been fixed?
>> >
>> > https://patchwork.kernel.org/patch/1810481/
>> > http://www.spinics.net/lists/linux-omap/msg83132.html
>>
>> That patch didn't get applied, so it's still broken in Linus' tree :(
>
> In netdev's patchwork, this was marked "Not Applicable." Dave, can you
> possibly take this patch? If not, who should I ask next?
That's strange, when I look at that patch it's marked "Accepted" ;-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* cpts: Fix build error caused by include of plat/clock.h
@ 2012-12-14 18:18 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2012-12-14 18:18 UTC (permalink / raw)
To: linux-arm-kernel
From: Richard Cochran <richardcochran@gmail.com>
Date: Fri, 14 Dec 2012 12:09:18 +0100
> On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
>>
>> Op 14 dec. 2012, om 08:13 heeft Richard Cochran <richardcochran@gmail.com> het volgende geschreven:
>>
>> > On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
>> >> Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
>> >> mistakenly included plat/clock.h that should not be included by drivers
>> >> even if it exists.
>> >
>> > Hasn't this already been fixed?
>> >
>> > https://patchwork.kernel.org/patch/1810481/
>> > http://www.spinics.net/lists/linux-omap/msg83132.html
>>
>> That patch didn't get applied, so it's still broken in Linus' tree :(
>
> In netdev's patchwork, this was marked "Not Applicable." Dave, can you
> possibly take this patch? If not, who should I ask next?
That's strange, when I look at that patch it's marked "Accepted" ;-)
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-12-14 18:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-13 21:36 cpts: Fix build error caused by include of plat/clock.h Tony Lindgren
2012-12-13 21:36 ` Tony Lindgren
2012-12-14 7:13 ` Richard Cochran
2012-12-14 7:13 ` Richard Cochran
2012-12-14 9:55 ` Koen Kooi
2012-12-14 9:55 ` Koen Kooi
2012-12-14 11:09 ` Richard Cochran
2012-12-14 11:09 ` Richard Cochran
2012-12-14 18:18 ` David Miller
2012-12-14 18:18 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.