* [Qemu-devel] [PATCH] vmmouse_reset(): remove minimal code duplication
@ 2012-12-13 14:01 Laszlo Ersek
2012-12-18 16:38 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Laszlo Ersek @ 2012-12-13 14:01 UTC (permalink / raw)
To: qemu-trivial, qemu-devel, lersek
Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset().
vmmouse_disable() resets the status already.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
hw/vmmouse.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/vmmouse.c b/hw/vmmouse.c
index 6338efa..578122c 100644
--- a/hw/vmmouse.c
+++ b/hw/vmmouse.c
@@ -252,7 +252,6 @@ static void vmmouse_reset(DeviceState *d)
{
VMMouseState *s = container_of(d, VMMouseState, dev.qdev);
- s->status = 0xffff;
s->queue_size = VMMOUSE_QUEUE_SIZE;
vmmouse_disable(s);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmmouse_reset(): remove minimal code duplication
2012-12-13 14:01 [Qemu-devel] [PATCH] vmmouse_reset(): remove minimal code duplication Laszlo Ersek
@ 2012-12-18 16:38 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-12-18 16:38 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: qemu-trivial, qemu-devel
On Thu, Dec 13, 2012 at 03:01:49PM +0100, Laszlo Ersek wrote:
> Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset().
> vmmouse_disable() resets the status already.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> hw/vmmouse.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-18 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-13 14:01 [Qemu-devel] [PATCH] vmmouse_reset(): remove minimal code duplication Laszlo Ersek
2012-12-18 16:38 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.