All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] Remove duplicate entry in ./Documentation/Makefile
@ 2012-12-19 18:49 Matt Kraai
  0 siblings, 0 replies; 3+ messages in thread
From: Matt Kraai @ 2012-12-19 18:49 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Thomas Ackermann

Hi,

Junio C Hamano wrote:
> If not by eyeballing but with some mechanical process, did you spot
> any others?

I found one other unnecessarily duplicated line in the top-level
Makefile:

 LIB_H += xdiff/xdiff.h

by running

 find -name Makefile | xargs grep += | sort | uniq -d

and inspecting the results by hand, but this only checked lines
containing "+=".

-- 
Matt Kraai
https://ftbfs.org/kraai

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove duplicate entry in ./Documentation/Makefile
  2012-12-19 18:15 Thomas Ackermann
@ 2012-12-19 18:22 ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2012-12-19 18:22 UTC (permalink / raw)
  To: Thomas Ackermann; +Cc: git

Thomas Ackermann <th.acker@arcor.de> writes:

> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
>  Documentation/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 3615504..7df75d0 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -31,7 +31,6 @@ SP_ARTICLES += howto/separating-topic-branches
>  SP_ARTICLES += howto/revert-a-faulty-merge
>  SP_ARTICLES += howto/recover-corrupted-blob-object
>  SP_ARTICLES += howto/rebuild-from-update-hook
> -SP_ARTICLES += howto/rebuild-from-update-hook

Heh, good eyes.  How did you spot it?

If not by eyeballing but with some mechanical process, did you spot
any others?

>  SP_ARTICLES += howto/rebase-from-internal-branch
>  SP_ARTICLES += howto/maintain-git
>  API_DOCS = $(patsubst %.txt,%,$(filter-out technical/api-index-skel.txt technical/api-index.txt, $(wildcard technical/api-*.txt)))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Remove duplicate entry in ./Documentation/Makefile
@ 2012-12-19 18:15 Thomas Ackermann
  2012-12-19 18:22 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Ackermann @ 2012-12-19 18:15 UTC (permalink / raw)
  To: git; +Cc: th.acker


Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
---
 Documentation/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 3615504..7df75d0 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -31,7 +31,6 @@ SP_ARTICLES += howto/separating-topic-branches
 SP_ARTICLES += howto/revert-a-faulty-merge
 SP_ARTICLES += howto/recover-corrupted-blob-object
 SP_ARTICLES += howto/rebuild-from-update-hook
-SP_ARTICLES += howto/rebuild-from-update-hook
 SP_ARTICLES += howto/rebase-from-internal-branch
 SP_ARTICLES += howto/maintain-git
 API_DOCS = $(patsubst %.txt,%,$(filter-out technical/api-index-skel.txt technical/api-index.txt, $(wildcard technical/api-*.txt)))
-- 
1.8.0.msysgit.0


---
Thomas

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-19 18:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-19 18:49 [PATCH] Remove duplicate entry in ./Documentation/Makefile Matt Kraai
  -- strict thread matches above, loose matches on Subject: below --
2012-12-19 18:15 Thomas Ackermann
2012-12-19 18:22 ` Junio C Hamano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.