* [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt()
@ 2012-12-21 1:19 Axel Lin
2012-12-24 5:38 ` Omair M. Abdullah
2012-12-24 15:32 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-12-21 1:19 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, M R Swami Reddy, Liam Girdwood
The mode variable is either 0 or 1.
To update mode setting, the mask should be BIT(0) rather than BIT(1).
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi M R Swami,
I don't have the datasheet. Can you check if this patch is correct?
Thanks,
Axel
sound/soc/codecs/lm49453.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
index d75257d..c0d203b 100644
--- a/sound/soc/codecs/lm49453.c
+++ b/sound/soc/codecs/lm49453.c
@@ -1218,7 +1218,7 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
}
snd_soc_update_bits(codec, LM49453_P0_AUDIO_PORT1_BASIC_REG,
- LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(1)|BIT(5),
+ LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(0)|BIT(5),
(aif_val | mode | clk_phase));
snd_soc_write(codec, LM49453_P0_AUDIO_PORT1_RX_MSB_REG, clk_shift);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt()
2012-12-21 1:19 [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt() Axel Lin
@ 2012-12-24 5:38 ` Omair M. Abdullah
2012-12-24 15:32 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Omair M. Abdullah @ 2012-12-24 5:38 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, M R Swami Reddy, Liam Girdwood
On Fri, Dec 21, 2012 at 09:19:20AM +0800, Axel Lin wrote:
> The mode variable is either 0 or 1.
> To update mode setting, the mask should be BIT(0) rather than BIT(1).
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi M R Swami,
> I don't have the datasheet. Can you check if this patch is correct?
Yes, according to the datasheet the STEREO mode is BIT(0).
> Thanks,
> Axel
> sound/soc/codecs/lm49453.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
> index d75257d..c0d203b 100644
> --- a/sound/soc/codecs/lm49453.c
> +++ b/sound/soc/codecs/lm49453.c
> @@ -1218,7 +1218,7 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
> }
>
> snd_soc_update_bits(codec, LM49453_P0_AUDIO_PORT1_BASIC_REG,
> - LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(1)|BIT(5),
> + LM49453_AUDIO_PORT1_BASIC_FMT_MASK|BIT(0)|BIT(5),
> (aif_val | mode | clk_phase));
>
> snd_soc_write(codec, LM49453_P0_AUDIO_PORT1_RX_MSB_REG, clk_shift);
> --
> 1.7.9.5
>
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt()
2012-12-21 1:19 [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt() Axel Lin
2012-12-24 5:38 ` Omair M. Abdullah
@ 2012-12-24 15:32 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-12-24 15:32 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, M R Swami Reddy, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 186 bytes --]
On Fri, Dec 21, 2012 at 09:19:20AM +0800, Axel Lin wrote:
> The mode variable is either 0 or 1.
> To update mode setting, the mask should be BIT(0) rather than BIT(1).
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-24 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-21 1:19 [PATCH RFT] ASoC: lm49453: Fix mask for setting mode bit in lm49453_set_dai_fmt() Axel Lin
2012-12-24 5:38 ` Omair M. Abdullah
2012-12-24 15:32 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.