Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

On (12/24/12 20:17), Ferron, Chris E wrote:
> Thanks, I will attend to outstanding patches on Wednesday (GMT+8) when I return to the office. 
> -Chris
>

Thanks, Merry Christmas!

	-ss

 
> -----Original Message-----
> From: powertop-bounces(a)lists.01.org [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Sergey Senozhatsky
> Sent: Monday, December 24, 2012 8:25 AM
> To: Chris Ferron
> Cc: powertop(a)lists.01.org
> Subject: Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*
> 
> On (12/24/12 03:08), Ivan Shapovalov wrote:
> > This is a resend (unchanged but rebased) of the patch series about 
> > refactoring code in cpu/* by deduplication. From this series, only the 
> > last bugfix patch has been applied so far due to a code freeze.
> > 
> > Ivan Shapovalov (10):
> >       Fix includes: do not include intel_cpus.h inside cpu.h
> >       Deduplication: move is_turbo() function to lib
> >       Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
> >       Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
> >       Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
> >       Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
> >       Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
> >       Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
> >       Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
> >       Deduplication: merge go_idle()/go_unidle()/change_freq() 
> > overrides into abstract_cpu() class
> > 
> 
> Hello Chris,
> patch series looks good to me. thanks to Ivan.
> 
> please note V3 of 02 and 03 patches.
> 
> 
> 	-ss
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

On Mon, 24 Dec 2012 03:08:42 +0400
Ivan Shapovalov <intelfx100(a)gmail.com> wrote:

> This is a resend (unchanged but rebased) of the patch series about
> refactoring code in cpu/* by deduplication. From this series, only
> the last bugfix patch has been applied so far due to a code freeze.
> 
> Ivan Shapovalov (10):
>       Fix includes: do not include intel_cpus.h inside cpu.h
>       Deduplication: move is_turbo() function to lib
>       Deduplication: move all instances of account_freq() to
> abstract_cpu::account_freq() Deduplication: remove
> nhm_cpu::account_freq() almost identical to
> abstract_cpu::account_freq() Deduplication: remove
> nhm_{cpu,core,package}::change_effective_frequency() identical to
> cpu_{linux,core,package}::change_effective_frequency() Deduplication:
> merge cpu_{core,linux,package}::change_effective_frequency() into
> abstract_cpu::change_effective_frequency() Deduplication: remove
> {cpu,nhm}_core::calculate_freq() identical to
> abstract_cpu::calculate_freq() Deduplication: remove
> nhm_package::calculate_freq() identical to
> cpu_package::calculate_freq() Deduplication: properly merge
> cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
> Deduplication: merge go_idle()/go_unidle()/change_freq() overrides
> into abstract_cpu() class
> _______________________________________________ PowerTop mailing list
> PowerTop(a)lists.01.org https://lists.01.org/mailman/listinfo/powertop

Hi, I applied your patches.  Thanks for the cleanup.

Kristen

Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Ferron, Chris E]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

Thanks, I will attend to outstanding patches on Wednesday (GMT+8) when I return to the office. 
-Chris

-----Original Message-----
From: powertop-bounces(a)lists.01.org [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Sergey Senozhatsky
Sent: Monday, December 24, 2012 8:25 AM
To: Chris Ferron
Cc: powertop(a)lists.01.org
Subject: Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

On (12/24/12 03:08), Ivan Shapovalov wrote:
> This is a resend (unchanged but rebased) of the patch series about 
> refactoring code in cpu/* by deduplication. From this series, only the 
> last bugfix patch has been applied so far due to a code freeze.
> 
> Ivan Shapovalov (10):
>       Fix includes: do not include intel_cpus.h inside cpu.h
>       Deduplication: move is_turbo() function to lib
>       Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
>       Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
>       Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
>       Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
>       Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
>       Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
>       Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
>       Deduplication: merge go_idle()/go_unidle()/change_freq() 
> overrides into abstract_cpu() class
> 

Hello Chris,
patch series looks good to me. thanks to Ivan.

please note V3 of 02 and 03 patches.


	-ss
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop

Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On (12/24/12 03:08), Ivan Shapovalov wrote:
> This is a resend (unchanged but rebased) of the patch series about refactoring code
> in cpu/* by deduplication. From this series, only the last bugfix patch has been applied
> so far due to a code freeze.
> 
> Ivan Shapovalov (10):
>       Fix includes: do not include intel_cpus.h inside cpu.h
>       Deduplication: move is_turbo() function to lib
>       Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
>       Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
>       Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
>       Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
>       Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
>       Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
>       Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
>       Deduplication: merge go_idle()/go_unidle()/change_freq() overrides into abstract_cpu() class
> 

Hello Chris,
patch series looks good to me. thanks to Ivan.

please note V3 of 02 and 03 patches.


	-ss

[Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Ivan Shapovalov]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

This is a resend (unchanged but rebased) of the patch series about refactoring code
in cpu/* by deduplication. From this series, only the last bugfix patch has been applied
so far due to a code freeze.

Ivan Shapovalov (10):
      Fix includes: do not include intel_cpus.h inside cpu.h
      Deduplication: move is_turbo() function to lib
      Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
      Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
      Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
      Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
      Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
      Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
      Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
      Deduplication: merge go_idle()/go_unidle()/change_freq() overrides into abstract_cpu() class