All of lore.kernel.org
 help / color / mirror / Atom feed
* Porting problem: ndo_set_multicast_list removed
@ 2012-12-24 16:30 ` Woody Wu
  0 siblings, 0 replies; 6+ messages in thread
From: Woody Wu @ 2012-12-24 16:30 UTC (permalink / raw)
  To: kernelnewbies, linux-kernel

Hi, list

I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
kernel, the ndo_set_multicast_list method in the net_device_ops had been
removed. What's the story behind?  Can I simply ignore this method
defined in an old driver?

Please also help to check the below code, is the list of the operations
defined for my driver enough or not?

const struct net_device_ops ax_netdev_ops = {
	.ndo_open		= mydriver_open,
	.ndo_stop		= mydriver_close,
	.ndo_start_xmit		= mydriver_start_xmit,
	.ndo_get_stats		= mydriver_get_stats,
	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
	.ndo_set_mac_address 	= mydriver_set_mac_address,
};

Thanks in advance.

-- 
woody
I can't go back to yesterday - because I was a different person then.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Porting problem: ndo_set_multicast_list removed
@ 2012-12-24 16:30 ` Woody Wu
  0 siblings, 0 replies; 6+ messages in thread
From: Woody Wu @ 2012-12-24 16:30 UTC (permalink / raw)
  To: kernelnewbies

Hi, list

I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
kernel, the ndo_set_multicast_list method in the net_device_ops had been
removed. What's the story behind?  Can I simply ignore this method
defined in an old driver?

Please also help to check the below code, is the list of the operations
defined for my driver enough or not?

const struct net_device_ops ax_netdev_ops = {
	.ndo_open		= mydriver_open,
	.ndo_stop		= mydriver_close,
	.ndo_start_xmit		= mydriver_start_xmit,
	.ndo_get_stats		= mydriver_get_stats,
	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
	.ndo_set_mac_address 	= mydriver_set_mac_address,
};

Thanks in advance.

-- 
woody
I can't go back to yesterday - because I was a different person then.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Porting problem: ndo_set_multicast_list removed
  2012-12-24 16:30 ` Woody Wu
@ 2012-12-24 19:16   ` Eric Dumazet
  -1 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2012-12-24 19:16 UTC (permalink / raw)
  To: Woody Wu; +Cc: kernelnewbies, linux-kernel, netdev

On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> Hi, list
> 
> I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> kernel, the ndo_set_multicast_list method in the net_device_ops had been
> removed. What's the story behind?  Can I simply ignore this method
> defined in an old driver?
> 
> Please also help to check the below code, is the list of the operations
> defined for my driver enough or not?
> 
> const struct net_device_ops ax_netdev_ops = {
> 	.ndo_open		= mydriver_open,
> 	.ndo_stop		= mydriver_close,
> 	.ndo_start_xmit		= mydriver_start_xmit,
> 	.ndo_get_stats		= mydriver_get_stats,
> 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> };
> 
> Thanks in advance.
> 

Take a look at :

commit afc4b13df143122f99a0eb10bfefb216c2806de0
Author: Jiri Pirko <jpirko@redhat.com>
Date:   Tue Aug 16 06:29:01 2011 +0000

    net: remove use of ndo_set_multicast_list in drivers
    
    replace it by ndo_set_rx_mode
    
    Signed-off-by: Jiri Pirko <jpirko@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Porting problem: ndo_set_multicast_list removed
@ 2012-12-24 19:16   ` Eric Dumazet
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2012-12-24 19:16 UTC (permalink / raw)
  To: kernelnewbies

On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> Hi, list
> 
> I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> kernel, the ndo_set_multicast_list method in the net_device_ops had been
> removed. What's the story behind?  Can I simply ignore this method
> defined in an old driver?
> 
> Please also help to check the below code, is the list of the operations
> defined for my driver enough or not?
> 
> const struct net_device_ops ax_netdev_ops = {
> 	.ndo_open		= mydriver_open,
> 	.ndo_stop		= mydriver_close,
> 	.ndo_start_xmit		= mydriver_start_xmit,
> 	.ndo_get_stats		= mydriver_get_stats,
> 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> };
> 
> Thanks in advance.
> 

Take a look at :

commit afc4b13df143122f99a0eb10bfefb216c2806de0
Author: Jiri Pirko <jpirko@redhat.com>
Date:   Tue Aug 16 06:29:01 2011 +0000

    net: remove use of ndo_set_multicast_list in drivers
    
    replace it by ndo_set_rx_mode
    
    Signed-off-by: Jiri Pirko <jpirko@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Porting problem: ndo_set_multicast_list removed
  2012-12-24 19:16   ` Eric Dumazet
@ 2012-12-24 23:47     ` Woody Wu
  -1 siblings, 0 replies; 6+ messages in thread
From: Woody Wu @ 2012-12-24 23:47 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: kernelnewbies, linux-kernel, netdev

On Mon, Dec 24, 2012 at 11:16:27AM -0800, Eric Dumazet wrote:
> On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> > Hi, list
> > 
> > I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> > kernel, the ndo_set_multicast_list method in the net_device_ops had been
> > removed. What's the story behind?  Can I simply ignore this method
> > defined in an old driver?
> > 
> > Please also help to check the below code, is the list of the operations
> > defined for my driver enough or not?
> > 
> > const struct net_device_ops ax_netdev_ops = {
> > 	.ndo_open		= mydriver_open,
> > 	.ndo_stop		= mydriver_close,
> > 	.ndo_start_xmit		= mydriver_start_xmit,
> > 	.ndo_get_stats		= mydriver_get_stats,
> > 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> > 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> > };
> > 
> > Thanks in advance.
> > 
> 
> Take a look at :
> 
> commit afc4b13df143122f99a0eb10bfefb216c2806de0
> Author: Jiri Pirko <jpirko@redhat.com>
> Date:   Tue Aug 16 06:29:01 2011 +0000
> 
>     net: remove use of ndo_set_multicast_list in drivers
>     
>     replace it by ndo_set_rx_mode
>     
>     Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 

Thanks for the info!

-- 
woody
I can't go back to yesterday - because I was a different person then.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Porting problem: ndo_set_multicast_list removed
@ 2012-12-24 23:47     ` Woody Wu
  0 siblings, 0 replies; 6+ messages in thread
From: Woody Wu @ 2012-12-24 23:47 UTC (permalink / raw)
  To: kernelnewbies

On Mon, Dec 24, 2012 at 11:16:27AM -0800, Eric Dumazet wrote:
> On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> > Hi, list
> > 
> > I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> > kernel, the ndo_set_multicast_list method in the net_device_ops had been
> > removed. What's the story behind?  Can I simply ignore this method
> > defined in an old driver?
> > 
> > Please also help to check the below code, is the list of the operations
> > defined for my driver enough or not?
> > 
> > const struct net_device_ops ax_netdev_ops = {
> > 	.ndo_open		= mydriver_open,
> > 	.ndo_stop		= mydriver_close,
> > 	.ndo_start_xmit		= mydriver_start_xmit,
> > 	.ndo_get_stats		= mydriver_get_stats,
> > 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> > 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> > };
> > 
> > Thanks in advance.
> > 
> 
> Take a look at :
> 
> commit afc4b13df143122f99a0eb10bfefb216c2806de0
> Author: Jiri Pirko <jpirko@redhat.com>
> Date:   Tue Aug 16 06:29:01 2011 +0000
> 
>     net: remove use of ndo_set_multicast_list in drivers
>     
>     replace it by ndo_set_rx_mode
>     
>     Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 

Thanks for the info!

-- 
woody
I can't go back to yesterday - because I was a different person then.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-12-24 23:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-24 16:30 Porting problem: ndo_set_multicast_list removed Woody Wu
2012-12-24 16:30 ` Woody Wu
2012-12-24 19:16 ` Eric Dumazet
2012-12-24 19:16   ` Eric Dumazet
2012-12-24 23:47   ` Woody Wu
2012-12-24 23:47     ` Woody Wu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.