All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libpcre: set BUILD_CFLAGS
@ 2013-01-07  9:16 Giuseppe CONDORELLI
  2013-01-07 16:15 ` Martin Jansa
  0 siblings, 1 reply; 2+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-07  9:16 UTC (permalink / raw)
  To: openembedded-core

Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to set
CFLAG_FOR_BUILD, required for the libpcre build.

Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
---
 meta/recipes-support/libpcre/libpcre_8.32.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libpcre/libpcre_8.32.bb b/meta/recipes-support/libpcre/libpcre_8.32.bb
index e434d55..361e9f0 100644
--- a/meta/recipes-support/libpcre/libpcre_8.32.bb
+++ b/meta/recipes-support/libpcre/libpcre_8.32.bb
@@ -34,8 +34,9 @@ EXTRA_OECONF = "\
     --with-match-limit=10000000 \
 "
 
-BUILD_CPPFLAGS += "-DLINK_SIZE=2"
-BUILD_CFLAGS =+ "-I${S}/include"
+# Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to
+# set CFLAG_FOR_BUILD, required for the libpcre build.
+BUILD_CFLAGS =+ "-DLINK_SIZE=2 -I${S}/include"
 CFLAGS += "-D_REENTRANT"
 CXXFLAGS_append_powerpc = " -lstdc++"
 
-- 
1.7.7.6




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libpcre: set BUILD_CFLAGS
  2013-01-07  9:16 [PATCH] libpcre: set BUILD_CFLAGS Giuseppe CONDORELLI
@ 2013-01-07 16:15 ` Martin Jansa
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Jansa @ 2013-01-07 16:15 UTC (permalink / raw)
  To: Giuseppe CONDORELLI; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Mon, Jan 07, 2013 at 10:16:47AM +0100, Giuseppe CONDORELLI wrote:
> Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to set
> CFLAG_FOR_BUILD, required for the libpcre build.

CFLAG_FOR_BUILD typo in commit body and comment in recipe and please change 
subject to indicate that you're _changing_  BUILD_CFLAGS and
BUILD_CPPFLAGS value.

> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> ---
>  meta/recipes-support/libpcre/libpcre_8.32.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/libpcre/libpcre_8.32.bb b/meta/recipes-support/libpcre/libpcre_8.32.bb
> index e434d55..361e9f0 100644
> --- a/meta/recipes-support/libpcre/libpcre_8.32.bb
> +++ b/meta/recipes-support/libpcre/libpcre_8.32.bb
> @@ -34,8 +34,9 @@ EXTRA_OECONF = "\
>      --with-match-limit=10000000 \
>  "
>  
> -BUILD_CPPFLAGS += "-DLINK_SIZE=2"
> -BUILD_CFLAGS =+ "-I${S}/include"
> +# Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to
> +# set CFLAG_FOR_BUILD, required for the libpcre build.
> +BUILD_CFLAGS =+ "-DLINK_SIZE=2 -I${S}/include"
>  CFLAGS += "-D_REENTRANT"
>  CXXFLAGS_append_powerpc = " -lstdc++"
>  
> -- 
> 1.7.7.6
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-07 16:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07  9:16 [PATCH] libpcre: set BUILD_CFLAGS Giuseppe CONDORELLI
2013-01-07 16:15 ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.