All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Prashant Gaikwad <pgaikwad@nvidia.com>, <swarren@nvidia.com>,
	<grant.likely@secretlab.ca>, <linus.walleij@linaro.org>,
	<rob.herring@calxeda.com>, <maxime.ripard@free-electrons.com>,
	<linux@prisktech.co.nz>, <josh.cartwright@ni.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Prashant Gaikwad <pgaikwad@nvidia.com>
Subject: Re: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function
Date: Fri, 18 Jan 2013 09:56:21 -0800	[thread overview]
Message-ID: <20130118175621.3982.82838@quantum> (raw)
In-Reply-To: <1357282858-2112-5-git-send-email-pgaikwad@nvidia.com>

Quoting Prashant Gaikwad (2013-01-03 23:00:56)
> Use common of_clk_init() function for clock initialization.
> 
> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>

Tony,

Can I get a Tested-by from you before I take this in?

Thanks,
Mike

> ---
>  drivers/clk/clk-vt8500.c |   15 ++++-----------
>  1 files changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
> index fe25570..3ce1c3e 100644
> --- a/drivers/clk/clk-vt8500.c
> +++ b/drivers/clk/clk-vt8500.c
> @@ -272,7 +272,7 @@ static __init void vtwm_device_clk_init(struct device_node *node)
>         rc = of_clk_add_provider(node, of_clk_src_simple_get, clk);
>         clk_register_clkdev(clk, clk_name, NULL);
>  }
> -
> +CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init);
>  
>  /* PLL clock related functions */
>  
> @@ -502,20 +502,13 @@ static void __init vt8500_pll_init(struct device_node *node)
>  {
>         vtwm_pll_clk_init(node, PLL_TYPE_VT8500);
>  }
> +CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init);
>  
>  static void __init wm8650_pll_init(struct device_node *node)
>  {
>         vtwm_pll_clk_init(node, PLL_TYPE_WM8650);
>  }
> -
> -static const __initconst struct of_device_id clk_match[] = {
> -       { .compatible = "fixed-clock", .data = of_fixed_clk_setup, },
> -       { .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, },
> -       { .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, },
> -       { .compatible = "via,vt8500-device-clock",
> -                                       .data = vtwm_device_clk_init, },
> -       { /* sentinel */ }
> -};
> +CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init);
>  
>  void __init vtwm_clk_init(void __iomem *base)
>  {
> @@ -524,5 +517,5 @@ void __init vtwm_clk_init(void __iomem *base)
>  
>         pmc_base = base;
>  
> -       of_clk_init(clk_match);
> +       of_clk_init(NULL);
>  }
> -- 
> 1.7.4.1

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function
Date: Fri, 18 Jan 2013 09:56:21 -0800	[thread overview]
Message-ID: <20130118175621.3982.82838@quantum> (raw)
In-Reply-To: <1357282858-2112-5-git-send-email-pgaikwad@nvidia.com>

Quoting Prashant Gaikwad (2013-01-03 23:00:56)
> Use common of_clk_init() function for clock initialization.
> 
> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>

Tony,

Can I get a Tested-by from you before I take this in?

Thanks,
Mike

> ---
>  drivers/clk/clk-vt8500.c |   15 ++++-----------
>  1 files changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
> index fe25570..3ce1c3e 100644
> --- a/drivers/clk/clk-vt8500.c
> +++ b/drivers/clk/clk-vt8500.c
> @@ -272,7 +272,7 @@ static __init void vtwm_device_clk_init(struct device_node *node)
>         rc = of_clk_add_provider(node, of_clk_src_simple_get, clk);
>         clk_register_clkdev(clk, clk_name, NULL);
>  }
> -
> +CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init);
>  
>  /* PLL clock related functions */
>  
> @@ -502,20 +502,13 @@ static void __init vt8500_pll_init(struct device_node *node)
>  {
>         vtwm_pll_clk_init(node, PLL_TYPE_VT8500);
>  }
> +CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init);
>  
>  static void __init wm8650_pll_init(struct device_node *node)
>  {
>         vtwm_pll_clk_init(node, PLL_TYPE_WM8650);
>  }
> -
> -static const __initconst struct of_device_id clk_match[] = {
> -       { .compatible = "fixed-clock", .data = of_fixed_clk_setup, },
> -       { .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, },
> -       { .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, },
> -       { .compatible = "via,vt8500-device-clock",
> -                                       .data = vtwm_device_clk_init, },
> -       { /* sentinel */ }
> -};
> +CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init);
>  
>  void __init vtwm_clk_init(void __iomem *base)
>  {
> @@ -524,5 +517,5 @@ void __init vtwm_clk_init(void __iomem *base)
>  
>         pmc_base = base;
>  
> -       of_clk_init(clk_match);
> +       of_clk_init(NULL);
>  }
> -- 
> 1.7.4.1

  reply	other threads:[~2013-01-18 17:56 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04  7:00 [PATCH 1/7] clk: add common of_clk_init() function Prashant Gaikwad
2013-01-04  7:00 ` Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 2/7] clk: tegra: Use " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-04 16:30   ` Stephen Warren
2013-01-04 16:30     ` Stephen Warren
2013-01-05  2:44     ` Prashant Gaikwad
2013-01-05  2:44       ` Prashant Gaikwad
2013-01-24 19:20       ` Mike Turquette
2013-01-24 19:20         ` Mike Turquette
2013-01-24 19:32         ` Stephen Warren
2013-01-24 19:32           ` Stephen Warren
     [not found]           ` <20130125005729.10623.61165@quantum>
2013-01-25  4:44             ` Stephen Warren
2013-01-25  4:44               ` Stephen Warren
2013-02-01  4:49               ` Prashant Gaikwad
2013-02-01  4:49                 ` Prashant Gaikwad
2013-02-01 22:53                 ` Mike Turquette
2013-02-01 22:53                   ` Mike Turquette
2013-01-04  7:00 ` [PATCH 3/7] clk: sunxi: " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 4/7] clk: highbank: " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-18 17:55   ` Mike Turquette
2013-01-18 17:55     ` Mike Turquette
2013-01-04  7:00 ` [PATCH 5/7] clk: vt8500: " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-18 17:56   ` Mike Turquette [this message]
2013-01-18 17:56     ` Mike Turquette
2013-01-18 21:08     ` Tony Prisk
2013-01-18 21:08       ` Tony Prisk
2013-01-24 19:15       ` Mike Turquette
2013-01-25  4:01         ` Tony Prisk
2013-01-25  4:01           ` Tony Prisk
2013-01-04  7:00 ` [PATCH 6/7] clk: zynq: " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 7/7] clk: vexpress: " Prashant Gaikwad
2013-01-04  7:00   ` Prashant Gaikwad
2013-01-18 17:58   ` Mike Turquette
2013-01-18 17:58     ` Mike Turquette
2013-01-21 16:03     ` Pawel Moll
2013-01-21 16:03       ` Pawel Moll
2013-01-22  9:13     ` Linus Walleij
2013-01-22  9:13       ` Linus Walleij
2013-01-23 10:54   ` Pawel Moll
2013-01-23 10:54     ` Pawel Moll
2013-01-10 19:53 ` [PATCH 1/7] clk: add " Josh Cartwright
2013-01-10 19:53   ` Josh Cartwright
2013-01-11  5:01   ` Prashant Gaikwad
2013-01-11  5:01     ` Prashant Gaikwad
2013-01-13  8:57 ` Maxime Ripard
2013-01-13  8:57   ` Maxime Ripard
2013-01-24 17:47 ` Rob Herring
2013-01-24 17:47   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118175621.3982.82838@quantum \
    --to=mturquette@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=josh.cartwright@ni.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@prisktech.co.nz \
    --cc=maxime.ripard@free-electrons.com \
    --cc=pgaikwad@nvidia.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.