All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz,
	darrick.wong@oracle.com, ericvh@gmail.com,
	viro@zeniv.linux.org.uk, rminnich@sandia.gov, tytso@mit.edu
Cc: martin.petersen@oracle.com, neilb@suse.de,
	Mark Fasheh <mfasheh@suse.com>,
	david@fromorbit.com, gnehzuil.liu@gmail.com,
	linux-kernel@vger.kernel.org, hch@infradead.org,
	linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca,
	ocfs2-devel@oss.oracle.com, bharrosh@panasas.com,
	jlayton@samba.org, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, hirofumi@mail.parknet.co.jp,
	Joel Becker <jlbec@evilplan.org>
Subject: [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
Date: Fri, 18 Jan 2013 17:13:08 -0800	[thread overview]
Message-ID: <20130119011308.20902.44871.stgit@blackbox.djwong.org> (raw)
In-Reply-To: <20130119011231.20902.55954.stgit@blackbox.djwong.org>

When stable pages are required, we have to wait if the page is just
going to disk and we want to modify it. Add proper callback to
ocfs2_grab_pages_for_write().

CC: ocfs2-devel@oss.oracle.com
CC: Joel Becker <jlbec@evilplan.org>
CC: Mark Fasheh <mfasheh@suse.com>
From: Jan Kara <jack@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/ocfs2/aops.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 6577432..9796330 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping,
 				goto out;
 			}
 		}
+		wait_for_stable_page(wc->w_pages[i]);
 
 		if (index == target_index)
 			wc->w_target_page = wc->w_pages[i];


WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz,
	darrick.wong@oracle.com, ericvh@gmail.com,
	viro@zeniv.linux.org.uk, rminnich@sandia.gov, tytso@mit.edu
Cc: martin.petersen@oracle.com, neilb@suse.de,
	Mark Fasheh <mfasheh@suse.com>,
	david@fromorbit.com, gnehzuil.liu@gmail.com,
	linux-kernel@vger.kernel.org, hch@infradead.org,
	linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca,
	ocfs2-devel@oss.oracle.com, bharrosh@panasas.com,
	jlayton@samba.org, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, hirofumi@mail.parknet.co.jp,
	Joel Becker <jlbec@evilplan.org>
Subject: [Ocfs2-devel] [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
Date: Fri, 18 Jan 2013 17:13:08 -0800	[thread overview]
Message-ID: <20130119011308.20902.44871.stgit@blackbox.djwong.org> (raw)
In-Reply-To: <20130119011231.20902.55954.stgit@blackbox.djwong.org>

When stable pages are required, we have to wait if the page is just
going to disk and we want to modify it. Add proper callback to
ocfs2_grab_pages_for_write().

CC: ocfs2-devel at oss.oracle.com
CC: Joel Becker <jlbec@evilplan.org>
CC: Mark Fasheh <mfasheh@suse.com>
From: Jan Kara <jack@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/ocfs2/aops.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 6577432..9796330 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping,
 				goto out;
 			}
 		}
+		wait_for_stable_page(wc->w_pages[i]);
 
 		if (index == target_index)
 			wc->w_target_page = wc->w_pages[i];

  parent reply	other threads:[~2013-01-19  1:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  1:12 [PATCH v2.5 0/3] mm/fs: Remove unnecessary waiting for stable pages Darrick J. Wong
2013-01-19  1:12 ` [PATCH 1/6] bdi: Allow block devices to say that they require stable page writes Darrick J. Wong
2013-01-19  1:12 ` [PATCH 2/6] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2013-01-19  1:12 ` [PATCH 3/6] 9pfs: Fix filesystem to wait for stable page writeback Darrick J. Wong
2013-01-19  1:13 ` [PATCH 4/6] block: Optionally snapshot page contents to provide stable pages during write Darrick J. Wong
2013-01-21 14:12   ` Jan Kara
2013-01-19  1:13 ` Darrick J. Wong [this message]
2013-01-19  1:13   ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages Darrick J. Wong
2013-01-30  1:03   ` Joel Becker
2013-01-30  1:05     ` [Ocfs2-devel] " Joel Becker
2013-01-19  1:13 ` [PATCH 6/6] ubifs: " Darrick J. Wong
2013-01-19  1:13   ` Darrick J. Wong
2013-01-19  1:13   ` Darrick J. Wong
2013-01-23 21:43   ` Andrew Morton
2013-01-23 21:43     ` Andrew Morton
2013-02-21  3:48     ` Darrick J. Wong
2013-02-21  3:48       ` Darrick J. Wong
2013-02-21  9:36       ` Boaz Harrosh
2013-02-21  9:36         ` Boaz Harrosh
2013-02-21  9:36         ` Boaz Harrosh
2013-02-21 22:32       ` Andrew Morton
2013-02-21 22:32         ` Andrew Morton
2013-02-21 22:40         ` Darrick J. Wong
2013-02-21 22:40           ` Darrick J. Wong
2013-02-21 22:40           ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2013-01-15  5:42 [PATCH v2.4 0/3] mm/fs: Remove unnecessary waiting for " Darrick J. Wong
2013-01-15  5:43 ` [PATCH 5/6] ocfs2: Wait for page writeback to provide " Darrick J. Wong
2013-01-15 10:15   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130119011308.20902.44871.stgit@blackbox.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bharrosh@panasas.com \
    --cc=david@fromorbit.com \
    --cc=ericvh@gmail.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=hch@infradead.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jlayton@samba.org \
    --cc=jlbec@evilplan.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=martin.petersen@oracle.com \
    --cc=mfasheh@suse.com \
    --cc=neilb@suse.de \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rminnich@sandia.gov \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.