From: Mark Rutland <mark.rutland@arm.com> To: Kishon Vijay Abraham I <kishon@ti.com> Cc: "tony@atomide.com" <tony@atomide.com>, "balbi@ti.com" <balbi@ti.com>, "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>, "eballetbo@gmail.com" <eballetbo@gmail.com>, "javier@dowhile0.org" <javier@dowhile0.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree-discuss@lists.ozlabs.org" <devicetree-discuss@lists.ozlabs.org>, Marc Kleine-Budde <mkl@pengutronix.de> Subject: Re: [PATCH v1 5/6] usb: otg: add device tree support to otg library Date: Tue, 22 Jan 2013 10:36:50 +0000 [thread overview] Message-ID: <20130122103650.GB18876@e106331-lin.cambridge.arm.com> (raw) In-Reply-To: <1358848694-20145-6-git-send-email-kishon@ti.com> > +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, > + const char *phandle, u8 index) > +{ > + struct usb_phy *phy = NULL, **ptr; > + unsigned long flags; > + struct device_node *node; > + > + if (!dev->of_node) { > + dev_dbg(dev, "device does not have a device node entry\n"); > + return ERR_PTR(-EINVAL); > + } > + > + node = of_parse_phandle(dev->of_node, phandle, index); > + if (!node) { > + dev_dbg(dev, "failed to get %s phandle in %s node\n", phandle, > + dev->of_node->full_name); > + return ERR_PTR(-ENODEV); > + } At any point past this, node's refcount is incremented (done automatically by of_parse_phandle => of_find_node_by_phandle). > + > + ptr = devres_alloc(devm_usb_phy_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) { > + dev_dbg(dev, "failed to allocate memory for devres\n"); > + return ERR_PTR(-ENOMEM); > + } > + > + spin_lock_irqsave(&phy_lock, flags); > + > + phy = __of_usb_find_phy(node); > + if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { > + phy = ERR_PTR(-EPROBE_DEFER); > + devres_free(ptr); > + goto err0; > + } > + > + *ptr = phy; > + devres_add(dev, ptr); > + > + get_device(phy->dev); > + > +err0: > + spin_unlock_irqrestore(&phy_lock, flags); > + > + return phy; > +} This means that on all of the exit paths, node's refcount is left incremented incorrectly. You'll need an of_node_put(node) on each exit path. Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 5/6] usb: otg: add device tree support to otg library Date: Tue, 22 Jan 2013 10:36:50 +0000 [thread overview] Message-ID: <20130122103650.GB18876@e106331-lin.cambridge.arm.com> (raw) In-Reply-To: <1358848694-20145-6-git-send-email-kishon@ti.com> > +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, > + const char *phandle, u8 index) > +{ > + struct usb_phy *phy = NULL, **ptr; > + unsigned long flags; > + struct device_node *node; > + > + if (!dev->of_node) { > + dev_dbg(dev, "device does not have a device node entry\n"); > + return ERR_PTR(-EINVAL); > + } > + > + node = of_parse_phandle(dev->of_node, phandle, index); > + if (!node) { > + dev_dbg(dev, "failed to get %s phandle in %s node\n", phandle, > + dev->of_node->full_name); > + return ERR_PTR(-ENODEV); > + } At any point past this, node's refcount is incremented (done automatically by of_parse_phandle => of_find_node_by_phandle). > + > + ptr = devres_alloc(devm_usb_phy_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) { > + dev_dbg(dev, "failed to allocate memory for devres\n"); > + return ERR_PTR(-ENOMEM); > + } > + > + spin_lock_irqsave(&phy_lock, flags); > + > + phy = __of_usb_find_phy(node); > + if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { > + phy = ERR_PTR(-EPROBE_DEFER); > + devres_free(ptr); > + goto err0; > + } > + > + *ptr = phy; > + devres_add(dev, ptr); > + > + get_device(phy->dev); > + > +err0: > + spin_unlock_irqrestore(&phy_lock, flags); > + > + return phy; > +} This means that on all of the exit paths, node's refcount is left incremented incorrectly. You'll need an of_node_put(node) on each exit path. Thanks, Mark.
next prev parent reply other threads:[~2013-01-22 10:36 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-22 9:58 [PATCH v1 0/6] USB: Add support for multiple PHYs of same type Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` [PATCH v1 1/6] usb: otg: Add an API to bind the USB controller and PHY Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` [PATCH v1 2/6] usb: otg: utils: add facilities in phy lib to support multiple PHYs of same type Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 14:07 ` Roger Quadros 2013-01-22 14:07 ` Roger Quadros 2013-01-22 14:07 ` Roger Quadros 2013-01-22 14:13 ` kishon 2013-01-22 14:13 ` kishon 2013-01-22 14:13 ` kishon 2013-01-22 9:58 ` [PATCH v1 3/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` [PATCH v1 4/6] drivers: usb: musb: omap: make use of the new PHY lib APIs Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 14:09 ` Roger Quadros 2013-01-22 14:09 ` Roger Quadros 2013-01-22 14:09 ` Roger Quadros 2013-01-24 18:58 ` kishon 2013-01-24 18:58 ` kishon 2013-01-24 18:58 ` kishon 2013-01-22 9:58 ` [PATCH v1 5/6] usb: otg: add device tree support to otg library Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 10:36 ` Mark Rutland [this message] 2013-01-22 10:36 ` Mark Rutland 2013-01-22 10:36 ` Mark Rutland 2013-01-22 15:37 ` kishon 2013-01-22 15:37 ` kishon 2013-01-22 15:37 ` kishon 2013-01-22 9:58 ` [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 9:58 ` Kishon Vijay Abraham I 2013-01-22 14:17 ` Roger Quadros 2013-01-22 14:17 ` Roger Quadros 2013-01-22 14:17 ` Roger Quadros 2013-01-22 14:37 ` kishon 2013-01-22 14:37 ` kishon 2013-01-22 14:37 ` kishon 2013-01-22 14:47 ` Roger Quadros 2013-01-22 14:47 ` Roger Quadros 2013-01-22 14:47 ` Roger Quadros 2013-01-22 15:21 ` kishon 2013-01-22 15:21 ` kishon 2013-01-22 15:21 ` kishon 2013-01-22 15:38 ` Peter Ujfalusi 2013-01-22 15:38 ` Peter Ujfalusi 2013-01-22 15:38 ` Peter Ujfalusi 2013-01-22 15:40 ` kishon 2013-01-22 15:40 ` kishon 2013-01-22 15:40 ` kishon 2013-01-22 15:41 ` [PATCH v1 0/6] USB: Add support for multiple PHYs of same type Koen Kooi 2013-01-22 15:41 ` Koen Kooi 2013-01-22 15:41 ` Koen Kooi 2013-01-22 15:45 ` kishon 2013-01-22 15:45 ` kishon 2013-01-22 15:45 ` kishon 2013-01-22 16:16 ` kishon 2013-01-22 16:16 ` kishon 2013-01-22 16:16 ` kishon 2013-01-22 17:02 ` Koen Kooi 2013-01-22 17:02 ` Koen Kooi 2013-01-22 17:02 ` Koen Kooi 2013-01-23 5:19 ` kishon 2013-01-23 5:19 ` kishon 2013-01-23 5:19 ` kishon 2013-01-23 13:58 ` Mohammed, Afzal 2013-01-23 13:58 ` Mohammed, Afzal 2013-01-23 13:58 ` Mohammed, Afzal 2013-01-23 14:26 ` kishon 2013-01-23 14:26 ` kishon 2013-01-23 14:26 ` kishon 2013-01-24 11:51 ` Mohammed, Afzal 2013-01-24 11:51 ` Mohammed, Afzal 2013-01-24 11:51 ` Mohammed, Afzal 2013-01-25 14:46 ` Mohammed, Afzal 2013-01-25 14:46 ` Mohammed, Afzal 2013-01-25 14:46 ` Mohammed, Afzal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130122103650.GB18876@e106331-lin.cambridge.arm.com \ --to=mark.rutland@arm.com \ --cc=balbi@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=eballetbo@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=javier@dowhile0.org \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mkl@pengutronix.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.