From: "Maxim V. Patlasov" <MPatlasov@parallels.com> To: miklos@szeredi.hu Cc: dev@parallels.com, xemul@parallels.com, fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, jbottomley@parallels.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, devel@openvz.org Subject: [PATCH 08/14] fuse: Flush files on wb close Date: Fri, 25 Jan 2013 22:24:21 +0400 [thread overview] Message-ID: <20130125182407.10037.26333.stgit@maximpc.sw.ru> (raw) In-Reply-To: <20130125181700.10037.29163.stgit@maximpc.sw.ru> Any write request requires a file handle to report to the userspace. Thus when we close a file (and free the fuse_file with this info) we have to flush all the outstanding writeback cache. Note, that simply calling the filemap_write_and_wait() is not enough since fuse finishes page writeback immediately and thus the -wait part of the mentioned call will be no-op. Do real wait on per-inode writepages list. Signed-off-by: Maxim Patlasov <MPatlasov@parallels.com> Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- fs/fuse/file.c | 26 +++++++++++++++++++++++++- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 4f8fa45..496e74c 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -138,6 +138,12 @@ static void fuse_file_put(struct fuse_file *ff, bool sync) } } +static void __fuse_file_put(struct fuse_file *ff) +{ + if (atomic_dec_and_test(&ff->count)) + BUG(); +} + int fuse_do_open(struct fuse_conn *fc, u64 nodeid, struct file *file, bool isdir) { @@ -286,8 +292,23 @@ static int fuse_open(struct inode *inode, struct file *file) return fuse_open_common(inode, file, false); } +static void fuse_flush_writeback(struct inode *inode, struct file *file) +{ + struct fuse_conn *fc = get_fuse_conn(inode); + struct fuse_inode *fi = get_fuse_inode(inode); + + filemap_write_and_wait(file->f_mapping); + wait_event(fi->page_waitq, list_empty_careful(&fi->writepages)); + spin_unlock_wait(&fc->lock); +} + static int fuse_release(struct inode *inode, struct file *file) { + struct fuse_conn *fc = get_fuse_conn(inode); + + if (fc->writeback_cache) + fuse_flush_writeback(inode, file); + fuse_release_common(file, FUSE_RELEASE); /* return value is ignored by VFS */ @@ -1343,7 +1364,8 @@ static void fuse_writepage_free(struct fuse_conn *fc, struct fuse_req *req) for (i = 0; i < req->num_pages; i++) __free_page(req->pages[i]); - fuse_file_put(req->ff, false); + if (!fc->writeback_cache) + fuse_file_put(req->ff, false); } static void fuse_writepage_finish(struct fuse_conn *fc, struct fuse_req *req) @@ -1360,6 +1382,8 @@ static void fuse_writepage_finish(struct fuse_conn *fc, struct fuse_req *req) } bdi_writeout_inc(bdi); wake_up(&fi->page_waitq); + if (fc->writeback_cache) + __fuse_file_put(req->ff); } /* Called under fc->lock, may release and reacquire it */
WARNING: multiple messages have this Message-ID (diff)
From: "Maxim V. Patlasov" <MPatlasov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> To: miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org Cc: dev-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org Subject: [PATCH 08/14] fuse: Flush files on wb close Date: Fri, 25 Jan 2013 22:24:21 +0400 [thread overview] Message-ID: <20130125182407.10037.26333.stgit@maximpc.sw.ru> (raw) In-Reply-To: <20130125181700.10037.29163.stgit-vWG5eQQidJHciZdyczg/7Q@public.gmane.org> Any write request requires a file handle to report to the userspace. Thus when we close a file (and free the fuse_file with this info) we have to flush all the outstanding writeback cache. Note, that simply calling the filemap_write_and_wait() is not enough since fuse finishes page writeback immediately and thus the -wait part of the mentioned call will be no-op. Do real wait on per-inode writepages list. Signed-off-by: Maxim Patlasov <MPatlasov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Signed-off-by: Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> --- fs/fuse/file.c | 26 +++++++++++++++++++++++++- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 4f8fa45..496e74c 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -138,6 +138,12 @@ static void fuse_file_put(struct fuse_file *ff, bool sync) } } +static void __fuse_file_put(struct fuse_file *ff) +{ + if (atomic_dec_and_test(&ff->count)) + BUG(); +} + int fuse_do_open(struct fuse_conn *fc, u64 nodeid, struct file *file, bool isdir) { @@ -286,8 +292,23 @@ static int fuse_open(struct inode *inode, struct file *file) return fuse_open_common(inode, file, false); } +static void fuse_flush_writeback(struct inode *inode, struct file *file) +{ + struct fuse_conn *fc = get_fuse_conn(inode); + struct fuse_inode *fi = get_fuse_inode(inode); + + filemap_write_and_wait(file->f_mapping); + wait_event(fi->page_waitq, list_empty_careful(&fi->writepages)); + spin_unlock_wait(&fc->lock); +} + static int fuse_release(struct inode *inode, struct file *file) { + struct fuse_conn *fc = get_fuse_conn(inode); + + if (fc->writeback_cache) + fuse_flush_writeback(inode, file); + fuse_release_common(file, FUSE_RELEASE); /* return value is ignored by VFS */ @@ -1343,7 +1364,8 @@ static void fuse_writepage_free(struct fuse_conn *fc, struct fuse_req *req) for (i = 0; i < req->num_pages; i++) __free_page(req->pages[i]); - fuse_file_put(req->ff, false); + if (!fc->writeback_cache) + fuse_file_put(req->ff, false); } static void fuse_writepage_finish(struct fuse_conn *fc, struct fuse_req *req) @@ -1360,6 +1382,8 @@ static void fuse_writepage_finish(struct fuse_conn *fc, struct fuse_req *req) } bdi_writeout_inc(bdi); wake_up(&fi->page_waitq); + if (fc->writeback_cache) + __fuse_file_put(req->ff); } /* Called under fc->lock, may release and reacquire it */ ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d
next prev parent reply other threads:[~2013-01-25 18:24 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-25 18:20 [PATCH v3 00/14] fuse: An attempt to implement a write-back cache policy Maxim V. Patlasov 2013-01-25 18:20 ` Maxim V. Patlasov 2013-01-25 18:20 ` [PATCH 01/14] fuse: Linking file to inode helper Maxim V. Patlasov 2013-01-25 18:20 ` Maxim V. Patlasov 2013-01-25 18:21 ` [PATCH 02/14] fuse: Getting file for writeback helper Maxim V. Patlasov 2013-01-25 18:21 ` Maxim V. Patlasov 2013-01-25 18:21 ` [PATCH 03/14] fuse: Prepare to handle short reads Maxim V. Patlasov 2013-01-25 18:21 ` [PATCH 04/14] fuse: Prepare to handle multiple pages in writeback Maxim V. Patlasov 2013-01-25 18:21 ` Maxim V. Patlasov 2013-01-25 18:22 ` [PATCH 05/14] fuse: Connection bit for enabling writeback Maxim V. Patlasov 2013-01-25 18:22 ` Maxim V. Patlasov 2013-01-25 18:22 ` [PATCH 06/14] fuse: Trust kernel i_size only - v2 Maxim V. Patlasov 2013-01-25 18:22 ` Maxim V. Patlasov 2013-01-29 10:18 ` Miklos Szeredi 2013-03-25 12:29 ` Maxim V. Patlasov 2013-01-25 18:24 ` [PATCH 07/14] fuse: Update i_mtime on buffered writes Maxim V. Patlasov 2013-01-29 22:19 ` Miklos Szeredi 2013-03-26 9:55 ` Maxim V. Patlasov 2013-01-25 18:24 ` Maxim V. Patlasov [this message] 2013-01-25 18:24 ` [PATCH 08/14] fuse: Flush files on wb close Maxim V. Patlasov 2013-01-29 22:58 ` Miklos Szeredi 2013-03-26 11:24 ` Maxim V. Patlasov 2013-03-26 11:24 ` Maxim V. Patlasov 2013-01-25 18:25 ` [PATCH 09/14] fuse: Implement writepages and write_begin/write_end callbacks - v2 Maxim V. Patlasov 2013-01-25 18:25 ` Maxim V. Patlasov 2013-01-29 23:08 ` Miklos Szeredi 2013-03-27 12:39 ` Maxim V. Patlasov 2013-03-27 12:39 ` Maxim V. Patlasov 2013-01-25 18:25 ` [PATCH 10/14] fuse: fuse_writepage_locked() should wait on writeback Maxim V. Patlasov 2013-01-25 18:25 ` Maxim V. Patlasov 2013-01-25 18:26 ` [PATCH 11/14] fuse: fuse_flush() " Maxim V. Patlasov 2013-01-25 18:26 ` Maxim V. Patlasov 2013-01-25 18:27 ` [PATCH 12/14] fuse: Fix O_DIRECT operations vs cached writeback misorder - v2 Maxim V. Patlasov 2013-01-25 18:27 ` [PATCH 13/14] fuse: Turn writeback cache on Maxim V. Patlasov 2013-01-25 18:27 ` Maxim V. Patlasov 2013-01-25 18:28 ` [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages Maxim V. Patlasov 2013-01-25 18:28 ` Maxim V. Patlasov -- strict thread matches above, loose matches on Subject: below -- 2013-04-01 10:40 [PATCH v4 00/14] fuse: An attempt to implement a write-back cache policy Maxim V. Patlasov 2013-04-01 10:41 ` [PATCH 08/14] fuse: Flush files on wb close Maxim V. Patlasov 2012-11-16 17:04 [PATCH v2 00/14] fuse: An attempt to implement a write-back cache policy Maxim Patlasov 2012-11-16 17:09 ` [PATCH 08/14] fuse: Flush files on wb close Maxim Patlasov 2012-11-16 17:09 ` Maxim Patlasov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130125182407.10037.26333.stgit@maximpc.sw.ru \ --to=mpatlasov@parallels.com \ --cc=dev@parallels.com \ --cc=devel@openvz.org \ --cc=fuse-devel@lists.sourceforge.net \ --cc=jbottomley@parallels.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=viro@zeniv.linux.org.uk \ --cc=xemul@parallels.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.