From: Tony Lindgren <tony@atomide.com> To: Linus Walleij <linus.walleij@linaro.org> Cc: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>, davinci-linux-open-source@linux.davincidsp.com, linux@arm.linux.org.uk, sameo@linux.intel.com, linux-doc@vger.kernel.org, khilman@deeprootsystems.com, devicetree-discuss@lists.ozlabs.org, broonie@opensource.wolfsonmicro.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, hs@denx.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Date: Fri, 1 Feb 2013 09:11:24 -0800 [thread overview] Message-ID: <20130201171124.GF22517@atomide.com> (raw) In-Reply-To: <20130201170906.GE22517@atomide.com> * Tony Lindgren <tony@atomide.com> [130201 09:12]: > * Linus Walleij <linus.walleij@linaro.org> [130129 03:03]: > > On Tue, Jan 29, 2013 at 8:38 AM, Vishwanathrao Badarkhe, Manish > > <manishv.b@ti.com> wrote: > > > > > Currently, I2C driver gets probed before pinctrl driver. > > > To achieve I2C pin muxing via pinctrl driver before I2C > > > probe get called, register pinctrl driver in arch_initcall. > > > Also, add module_exit to unregister pinctrl driver. > > > > > > Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com> > > > > So your I2C driver is not returning -EPROBE_DEFER > > if it cannot find its pins? > > > > Hm, well I can live with this, if Tony ACKs it. > > Hmm pinctrl is before i2c in drivers/Makefile. > Making initcalls happen earlier and earlier is usually the > wrong way to go. Sounds like there's some other issue here > that needs to be fixed instead. Let me guess: The i2c driver is wrongly set to run with arch_initcall? > Regards, > > Tony > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Date: Fri, 1 Feb 2013 09:11:24 -0800 [thread overview] Message-ID: <20130201171124.GF22517@atomide.com> (raw) In-Reply-To: <20130201170906.GE22517@atomide.com> * Tony Lindgren <tony@atomide.com> [130201 09:12]: > * Linus Walleij <linus.walleij@linaro.org> [130129 03:03]: > > On Tue, Jan 29, 2013 at 8:38 AM, Vishwanathrao Badarkhe, Manish > > <manishv.b@ti.com> wrote: > > > > > Currently, I2C driver gets probed before pinctrl driver. > > > To achieve I2C pin muxing via pinctrl driver before I2C > > > probe get called, register pinctrl driver in arch_initcall. > > > Also, add module_exit to unregister pinctrl driver. > > > > > > Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com> > > > > So your I2C driver is not returning -EPROBE_DEFER > > if it cannot find its pins? > > > > Hm, well I can live with this, if Tony ACKs it. > > Hmm pinctrl is before i2c in drivers/Makefile. > Making initcalls happen earlier and earlier is usually the > wrong way to go. Sounds like there's some other issue here > that needs to be fixed instead. Let me guess: The i2c driver is wrongly set to run with arch_initcall? > Regards, > > Tony > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss at lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-02-01 17:11 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-29 7:38 [PATCH V2 0/6] davinci: DT support for i2c0 and tps6507x Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 10:59 ` Linus Walleij 2013-01-29 10:59 ` Linus Walleij 2013-01-29 12:02 ` Vishwanathrao Badarkhe, Manish 2013-01-29 12:02 ` Vishwanathrao Badarkhe, Manish 2013-01-29 12:02 ` Vishwanathrao Badarkhe, Manish 2013-02-01 7:05 ` Sekhar Nori 2013-02-01 7:05 ` Sekhar Nori 2013-02-01 7:05 ` Sekhar Nori 2013-02-01 17:09 ` Tony Lindgren 2013-02-01 17:09 ` Tony Lindgren 2013-02-01 17:11 ` Tony Lindgren [this message] 2013-02-01 17:11 ` Tony Lindgren 2013-02-05 6:36 ` Vishwanathrao Badarkhe, Manish 2013-02-05 6:36 ` Vishwanathrao Badarkhe, Manish 2013-02-05 6:36 ` Vishwanathrao Badarkhe, Manish 2013-02-05 11:27 ` Russell King - ARM Linux 2013-02-05 11:27 ` Russell King - ARM Linux 2013-02-05 11:27 ` Russell King - ARM Linux 2013-02-06 6:04 ` Vishwanathrao Badarkhe, Manish 2013-02-06 6:04 ` Vishwanathrao Badarkhe, Manish 2013-02-06 6:04 ` Vishwanathrao Badarkhe, Manish 2013-02-05 13:00 ` Linus Walleij 2013-02-05 13:00 ` Linus Walleij 2013-02-05 13:00 ` Linus Walleij 2013-02-06 4:57 ` Vishwanathrao Badarkhe, Manish 2013-02-06 4:57 ` Vishwanathrao Badarkhe, Manish 2013-02-06 4:57 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` [PATCH V2 2/6] ARM: davinci: da850: add OF_DEV_AUXDATA entry for I2C0 Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` [PATCH V2 3/6] ARM: davinci: da850: add DT node " Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-02-03 12:49 ` Sekhar Nori 2013-02-03 12:49 ` Sekhar Nori 2013-02-03 12:49 ` Sekhar Nori 2013-02-04 3:07 ` Vishwanathrao Badarkhe, Manish 2013-02-04 3:07 ` Vishwanathrao Badarkhe, Manish 2013-02-04 3:07 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` [PATCH V2 4/6] mfd: tps6507x: add device-tree support Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-02-03 22:31 ` Samuel Ortiz 2013-02-03 22:31 ` Samuel Ortiz 2013-01-29 7:38 ` [PATCH V2 5/6] ARM: regulator: add tps6507x device tree data Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:21 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:21 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:21 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` [PATCH V2 6/6] ARM: davinci: da850: add tps6507x regulator DT data Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-01-29 7:38 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:22 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:22 ` Vishwanathrao Badarkhe, Manish 2013-02-07 10:22 ` Vishwanathrao Badarkhe, Manish
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130201171124.GF22517@atomide.com \ --to=tony@atomide.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=davinci-linux-open-source@linux.davincidsp.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=hs@denx.de \ --cc=khilman@deeprootsystems.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=manishv.b@ti.com \ --cc=nsekhar@ti.com \ --cc=rob.herring@calxeda.com \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.