[GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Hans Verkuil]

Hi Mauro,

The cx2341x module is a helper module for conexant-based MPEG encoders.
It isn't an i2c module at all, instead it should be in common since it is
used by 7 pci and usb drivers to handle the MPEG setup.
    
It also shouldn't be visible in the config menu as it is always
selected automatically by those drivers that need it.

This pull request moves it to the right directory.

Regards,

	Hans

The following changes since commit a32f7d1ad3744914273c6907204c2ab3b5d496a0:

  Merge branch 'v4l_for_linus' into staging/for_v3.9 (2013-01-24 18:49:18 -0200)

are available in the git repository at:


  git://linuxtv.org/hverkuil/media_tree.git cx2341x

for you to fetch changes up to 15ee97480694257081933f3f78666de1c88eec5e:

  cx2341x: move from media/i2c to media/common (2013-01-29 09:47:49 +0100)

----------------------------------------------------------------
Hans Verkuil (1):
      cx2341x: move from media/i2c to media/common

 drivers/media/common/Kconfig                    |    1 +
 drivers/media/common/Makefile                   |    2 +-
 drivers/media/common/cx2341x/Kconfig            |    2 ++
 drivers/media/common/cx2341x/Makefile           |    1 +
 drivers/media/{i2c => common/cx2341x}/cx2341x.c |    0
 drivers/media/i2c/Kconfig                       |   14 --------------
 drivers/media/i2c/Makefile                      |    1 -
 7 files changed, 5 insertions(+), 16 deletions(-)
 create mode 100644 drivers/media/common/cx2341x/Kconfig
 create mode 100644 drivers/media/common/cx2341x/Makefile
 rename drivers/media/{i2c => common/cx2341x}/cx2341x.c (100%)

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Mauro Carvalho Chehab]

Hi Hans,

Em Tue, 29 Jan 2013 09:56:20 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> Hi Mauro,
> 
> The cx2341x module is a helper module for conexant-based MPEG encoders.
> It isn't an i2c module at all, instead it should be in common since it is
> used by 7 pci and usb drivers to handle the MPEG setup.
>     
> It also shouldn't be visible in the config menu as it is always
> selected automatically by those drivers that need it.

It should be noticed that the other non-i2c helper drivers also at
the i2c directories:
	$ grep -L i2c_client drivers/media/i2c/*.c|grep -v mod
	drivers/media/i2c/aptina-pll.c
	drivers/media/i2c/btcx-risc.c
	drivers/media/i2c/cx2341x.c
	drivers/media/i2c/smiapp-pll.c

A closer look may even hit some weird stuff, like tveeprom. This
particular helper driver is not an I2C driver, although it
has i2c_client symbol there, in order to optionally read the data
via I2C, instead of receiving it via an API call.

Also, I don't think cx2341x or any of those other helper drivers
deserve each its own directory.

So, IMHO, the better is to just live them at the i2c directory.
They might be moved, instead, to drivers/media/common (but without
creating subdirs there).

In any case, we should do the same for all those non-i2c helper
drivers. Just moving cx2341x and letting the others there will just
increase the mess.

> 
> This pull request moves it to the right directory.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit a32f7d1ad3744914273c6907204c2ab3b5d496a0:
> 
>   Merge branch 'v4l_for_linus' into staging/for_v3.9 (2013-01-24 18:49:18 -0200)
> 
> are available in the git repository at:
> 
> 
>   git://linuxtv.org/hverkuil/media_tree.git cx2341x
> 
> for you to fetch changes up to 15ee97480694257081933f3f78666de1c88eec5e:
> 
>   cx2341x: move from media/i2c to media/common (2013-01-29 09:47:49 +0100)
> 
> ----------------------------------------------------------------
> Hans Verkuil (1):
>       cx2341x: move from media/i2c to media/common
> 
>  drivers/media/common/Kconfig                    |    1 +
>  drivers/media/common/Makefile                   |    2 +-
>  drivers/media/common/cx2341x/Kconfig            |    2 ++
>  drivers/media/common/cx2341x/Makefile           |    1 +
>  drivers/media/{i2c => common/cx2341x}/cx2341x.c |    0
>  drivers/media/i2c/Kconfig                       |   14 --------------
>  drivers/media/i2c/Makefile                      |    1 -
>  7 files changed, 5 insertions(+), 16 deletions(-)
>  create mode 100644 drivers/media/common/cx2341x/Kconfig
>  create mode 100644 drivers/media/common/cx2341x/Makefile
>  rename drivers/media/{i2c => common/cx2341x}/cx2341x.c (100%)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 

Cheers,
Mauro

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Hans Verkuil]

On Tue February 5 2013 19:49:41 Mauro Carvalho Chehab wrote:
> Hi Hans,
> 
> Em Tue, 29 Jan 2013 09:56:20 +0100
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
> > Hi Mauro,
> > 
> > The cx2341x module is a helper module for conexant-based MPEG encoders.
> > It isn't an i2c module at all, instead it should be in common since it is
> > used by 7 pci and usb drivers to handle the MPEG setup.
> >     
> > It also shouldn't be visible in the config menu as it is always
> > selected automatically by those drivers that need it.
> 
> It should be noticed that the other non-i2c helper drivers also at
> the i2c directories:
> 	$ grep -L i2c_client drivers/media/i2c/*.c|grep -v mod
> 	drivers/media/i2c/aptina-pll.c
> 	drivers/media/i2c/btcx-risc.c
> 	drivers/media/i2c/cx2341x.c
> 	drivers/media/i2c/smiapp-pll.c
>
> A closer look may even hit some weird stuff, like tveeprom. This
> particular helper driver is not an I2C driver, although it
> has i2c_client symbol there, in order to optionally read the data
> via I2C, instead of receiving it via an API call.

At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some relationship
with i2c. But cx2341x.c and btcx-risc.c do not have that at all. One reason
for creating this patch was that I couldn't find the cx2341x.c code until I
smiapp-pll.cdid a find.

> Also, I don't think cx2341x or any of those other helper drivers
> deserve each its own directory.

I thought that the cx2341x.c source in common looked a bit lonely.
But if we add other sources as well, then it has company :-)

> So, IMHO, the better is to just live them at the i2c directory.

For cx2341x and btcx-risc the i2c directory is completely inappropriate.
Nobody is ever going to guess that.

> They might be moved, instead, to drivers/media/common (but without
> creating subdirs there).
> 
> In any case, we should do the same for all those non-i2c helper
> drivers. Just moving cx2341x and letting the others there will just
> increase the mess.

I've no problem moving cx2341x, btcx-risc and tveeprom to common. For
the two pll sources I'd like to know if the authors agree (CC-ed) before
I make a patch moving them to common.

Regards,

	Hans

> 
> > 
> > This pull request moves it to the right directory.
> > 
> > Regards,
> > 
> > 	Hans
> > 
> > The following changes since commit a32f7d1ad3744914273c6907204c2ab3b5d496a0:
> > 
> >   Merge branch 'v4l_for_linus' into staging/for_v3.9 (2013-01-24 18:49:18 -0200)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://linuxtv.org/hverkuil/media_tree.git cx2341x
> > 
> > for you to fetch changes up to 15ee97480694257081933f3f78666de1c88eec5e:
> > 
> >   cx2341x: move from media/i2c to media/common (2013-01-29 09:47:49 +0100)
> > 
> > ----------------------------------------------------------------
> > Hans Verkuil (1):
> >       cx2341x: move from media/i2c to media/common
> > 
> >  drivers/media/common/Kconfig                    |    1 +
> >  drivers/media/common/Makefile                   |    2 +-
> >  drivers/media/common/cx2341x/Kconfig            |    2 ++
> >  drivers/media/common/cx2341x/Makefile           |    1 +
> >  drivers/media/{i2c => common/cx2341x}/cx2341x.c |    0
> >  drivers/media/i2c/Kconfig                       |   14 --------------
> >  drivers/media/i2c/Makefile                      |    1 -
> >  7 files changed, 5 insertions(+), 16 deletions(-)
> >  create mode 100644 drivers/media/common/cx2341x/Kconfig
> >  create mode 100644 drivers/media/common/cx2341x/Makefile
> >  rename drivers/media/{i2c => common/cx2341x}/cx2341x.c (100%)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Mauro Carvalho Chehab]

Em Wed, 6 Feb 2013 08:46:35 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> On Tue February 5 2013 19:49:41 Mauro Carvalho Chehab wrote:
> > Hi Hans,
> > 
> > Em Tue, 29 Jan 2013 09:56:20 +0100
> > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > 
> > > Hi Mauro,
> > > 
> > > The cx2341x module is a helper module for conexant-based MPEG encoders.
> > > It isn't an i2c module at all, instead it should be in common since it is
> > > used by 7 pci and usb drivers to handle the MPEG setup.
> > >     
> > > It also shouldn't be visible in the config menu as it is always
> > > selected automatically by those drivers that need it.
> > 
> > It should be noticed that the other non-i2c helper drivers also at
> > the i2c directories:
> > 	$ grep -L i2c_client drivers/media/i2c/*.c|grep -v mod
> > 	drivers/media/i2c/aptina-pll.c
> > 	drivers/media/i2c/btcx-risc.c
> > 	drivers/media/i2c/cx2341x.c
> > 	drivers/media/i2c/smiapp-pll.c
> >
> > A closer look may even hit some weird stuff, like tveeprom. This
> > particular helper driver is not an I2C driver, although it
> > has i2c_client symbol there, in order to optionally read the data
> > via I2C, instead of receiving it via an API call.
> 
> At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some relationship
> with i2c.

True, but none of the three are actually i2c drivers; they're just shared
functions used by drivers helper code.

Hmm...

$ git grep aptina-pll.h drivers/media/
drivers/media/i2c/aptina-pll.c:#include "aptina-pll.h"
drivers/media/i2c/mt9m032.c:#include "aptina-pll.h"
drivers/media/i2c/mt9p031.c:#include "aptina-pll.h"

$ git grep smiapp-pll.h drivers/media/
drivers/media/i2c/smiapp-pll.c:#include "smiapp-pll.h"
drivers/media/i2c/smiapp-pll.h: * drivers/media/i2c/smiapp-pll.h
drivers/media/i2c/smiapp/smiapp.h:#include "smiapp-pll.h"

$ git grep smiapp.h drivers/media/
drivers/media/i2c/smiapp/smiapp-core.c:#include "smiapp.h"
drivers/media/i2c/smiapp/smiapp-limits.c:#include "smiapp.h"
drivers/media/i2c/smiapp/smiapp-quirk.c:#include "smiapp.h"
drivers/media/i2c/smiapp/smiapp-regs.c:#include "smiapp.h"
drivers/media/i2c/smiapp/smiapp.h: * drivers/media/i2c/smiapp/smiapp.h
drivers/media/i2c/smiapp/smiapp.h:#include <media/smiapp.h>

It could make sense to keep those two on I2c, eventually moving
smapp-pl to i2c/smiapp. I have conflicting opinions here :)

> But cx2341x.c and btcx-risc.c do not have that at all. One reason
> for creating this patch was that I couldn't find the cx2341x.c code until I
> smiapp-pll.cdid a find.
> 
> > Also, I don't think cx2341x or any of those other helper drivers
> > deserve each its own directory.
> 
> I thought that the cx2341x.c source in common looked a bit lonely.
> But if we add other sources as well, then it has company :-)

:)

> > So, IMHO, the better is to just live them at the i2c directory.
> 
> For cx2341x and btcx-risc the i2c directory is completely inappropriate.
> Nobody is ever going to guess that.

Agreed. Those are just leftovers of the tree reorg, as the final patch
at v4l side were to rename "video" to "i2c".

> > They might be moved, instead, to drivers/media/common (but without
> > creating subdirs there).
> > 
> > In any case, we should do the same for all those non-i2c helper
> > drivers. Just moving cx2341x and letting the others there will just
> > increase the mess.
> 
> I've no problem moving cx2341x, btcx-risc and tveeprom to common. For
> the two pll sources I'd like to know if the authors agree (CC-ed) before
> I make a patch moving them to common.

Fair enough.

Regards,
Mauro

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Laurent Pinchart]

Hi Mauro,

On Wednesday 06 February 2013 07:16:04 Mauro Carvalho Chehab wrote:
> Em Wed, 6 Feb 2013 08:46:35 +0100 Hans Verkuil escreveu:
> > On Tue February 5 2013 19:49:41 Mauro Carvalho Chehab wrote:
> > > Em Tue, 29 Jan 2013 09:56:20 +0100 Hans Verkuil escreveu:
> > > > Hi Mauro,
> > > > 
> > > > The cx2341x module is a helper module for conexant-based MPEG
> > > > encoders. It isn't an i2c module at all, instead it should be in
> > > > common since it is used by 7 pci and usb drivers to handle the MPEG
> > > > setup.
> > > > 
> > > > It also shouldn't be visible in the config menu as it is always
> > > > selected automatically by those drivers that need it.
> > > 
> > > It should be noticed that the other non-i2c helper drivers also at
> > > 
> > > the i2c directories:
> > > 	$ grep -L i2c_client drivers/media/i2c/*.c|grep -v mod
> > > 	drivers/media/i2c/aptina-pll.c
> > > 	drivers/media/i2c/btcx-risc.c
> > > 	drivers/media/i2c/cx2341x.c
> > > 	drivers/media/i2c/smiapp-pll.c
> > > 
> > > A closer look may even hit some weird stuff, like tveeprom. This
> > > particular helper driver is not an I2C driver, although it
> > > has i2c_client symbol there, in order to optionally read the data
> > > via I2C, instead of receiving it via an API call.
> > 
> > At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some
> > relationship with i2c.
> 
> True, but none of the three are actually i2c drivers; they're just shared
> functions used by drivers helper code.
> 
> Hmm...
> 
> $ git grep aptina-pll.h drivers/media/
> drivers/media/i2c/aptina-pll.c:#include "aptina-pll.h"
> drivers/media/i2c/mt9m032.c:#include "aptina-pll.h"
> drivers/media/i2c/mt9p031.c:#include "aptina-pll.h"
> 
> $ git grep smiapp-pll.h drivers/media/
> drivers/media/i2c/smiapp-pll.c:#include "smiapp-pll.h"
> drivers/media/i2c/smiapp-pll.h: * drivers/media/i2c/smiapp-pll.h
> drivers/media/i2c/smiapp/smiapp.h:#include "smiapp-pll.h"
> 
> $ git grep smiapp.h drivers/media/
> drivers/media/i2c/smiapp/smiapp-core.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-limits.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-quirk.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-regs.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp.h: * drivers/media/i2c/smiapp/smiapp.h
> drivers/media/i2c/smiapp/smiapp.h:#include <media/smiapp.h>
> 
> It could make sense to keep those two on I2c,

I'd like that :-) Those helper functions will likely never be used by non-I2C 
drivers. If they are we can reconsider moving them to common/, but for now it 
makes sense to keep them in i2c/ in my opinion.

> eventually moving smapp-pl to i2c/smiapp.

Just FYI, the smiapp-pll driver will be used by other Aptina drivers for 
sensors that use a SMIA++-like PLL. I haven't had time to finish the code yet.

> I have conflicting opinions here :)
> 
> > But cx2341x.c and btcx-risc.c do not have that at all. One reason
> > for creating this patch was that I couldn't find the cx2341x.c code until
> > I smiapp-pll.cdid a find.
> > 
> > > Also, I don't think cx2341x or any of those other helper drivers
> > > deserve each its own directory.
> > 
> > I thought that the cx2341x.c source in common looked a bit lonely.
> > But if we add other sources as well, then it has company :-)
>
> :)
>
> > > So, IMHO, the better is to just live them at the i2c directory.
> > 
> > For cx2341x and btcx-risc the i2c directory is completely inappropriate.
> > Nobody is ever going to guess that.
> 
> Agreed. Those are just leftovers of the tree reorg, as the final patch
> at v4l side were to rename "video" to "i2c".
> 
> > > They might be moved, instead, to drivers/media/common (but without
> > > creating subdirs there).
> > > 
> > > In any case, we should do the same for all those non-i2c helper
> > > drivers. Just moving cx2341x and letting the others there will just
> > > increase the mess.
> > 
> > I've no problem moving cx2341x, btcx-risc and tveeprom to common. For
> > the two pll sources I'd like to know if the authors agree (CC-ed) before
> > I make a patch moving them to common.

-- 
Regards,

Laurent Pinchart

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Hans Verkuil]

On Wed 6 February 2013 10:16:04 Mauro Carvalho Chehab wrote:
> Em Wed, 6 Feb 2013 08:46:35 +0100
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
> > On Tue February 5 2013 19:49:41 Mauro Carvalho Chehab wrote:
> > > Hi Hans,
> > > 
> > > Em Tue, 29 Jan 2013 09:56:20 +0100
> > > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > > 
> > > > Hi Mauro,
> > > > 
> > > > The cx2341x module is a helper module for conexant-based MPEG encoders.
> > > > It isn't an i2c module at all, instead it should be in common since it is
> > > > used by 7 pci and usb drivers to handle the MPEG setup.
> > > >     
> > > > It also shouldn't be visible in the config menu as it is always
> > > > selected automatically by those drivers that need it.
> > > 
> > > It should be noticed that the other non-i2c helper drivers also at
> > > the i2c directories:
> > > 	$ grep -L i2c_client drivers/media/i2c/*.c|grep -v mod
> > > 	drivers/media/i2c/aptina-pll.c
> > > 	drivers/media/i2c/btcx-risc.c
> > > 	drivers/media/i2c/cx2341x.c
> > > 	drivers/media/i2c/smiapp-pll.c
> > >
> > > A closer look may even hit some weird stuff, like tveeprom. This
> > > particular helper driver is not an I2C driver, although it
> > > has i2c_client symbol there, in order to optionally read the data
> > > via I2C, instead of receiving it via an API call.
> > 
> > At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some relationship
> > with i2c.
> 
> True, but none of the three are actually i2c drivers; they're just shared
> functions used by drivers helper code.
> 
> Hmm...
> 
> $ git grep aptina-pll.h drivers/media/
> drivers/media/i2c/aptina-pll.c:#include "aptina-pll.h"
> drivers/media/i2c/mt9m032.c:#include "aptina-pll.h"
> drivers/media/i2c/mt9p031.c:#include "aptina-pll.h"
> 
> $ git grep smiapp-pll.h drivers/media/
> drivers/media/i2c/smiapp-pll.c:#include "smiapp-pll.h"
> drivers/media/i2c/smiapp-pll.h: * drivers/media/i2c/smiapp-pll.h
> drivers/media/i2c/smiapp/smiapp.h:#include "smiapp-pll.h"
> 
> $ git grep smiapp.h drivers/media/
> drivers/media/i2c/smiapp/smiapp-core.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-limits.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-quirk.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp-regs.c:#include "smiapp.h"
> drivers/media/i2c/smiapp/smiapp.h: * drivers/media/i2c/smiapp/smiapp.h
> drivers/media/i2c/smiapp/smiapp.h:#include <media/smiapp.h>
> 
> It could make sense to keep those two on I2c, eventually moving
> smapp-pl to i2c/smiapp. I have conflicting opinions here :)
> 
> > But cx2341x.c and btcx-risc.c do not have that at all. One reason
> > for creating this patch was that I couldn't find the cx2341x.c code until I
> > smiapp-pll.cdid a find.
> > 
> > > Also, I don't think cx2341x or any of those other helper drivers
> > > deserve each its own directory.
> > 
> > I thought that the cx2341x.c source in common looked a bit lonely.
> > But if we add other sources as well, then it has company :-)
> 
> :)
> 
> > > So, IMHO, the better is to just live them at the i2c directory.
> > 
> > For cx2341x and btcx-risc the i2c directory is completely inappropriate.
> > Nobody is ever going to guess that.
> 
> Agreed. Those are just leftovers of the tree reorg, as the final patch
> at v4l side were to rename "video" to "i2c".
> 
> > > They might be moved, instead, to drivers/media/common (but without
> > > creating subdirs there).
> > > 
> > > In any case, we should do the same for all those non-i2c helper
> > > drivers. Just moving cx2341x and letting the others there will just
> > > increase the mess.
> > 
> > I've no problem moving cx2341x, btcx-risc and tveeprom to common. For
> > the two pll sources I'd like to know if the authors agree (CC-ed) before
> > I make a patch moving them to common.
> 
> Fair enough.

OK, I'll prepare patches today moving cx2341x, btcx-risc and tveeprom to
common. I agree with Laurent that the pll sources are better placed in i2c,
at least for now.

Regards,

	Hans

Re: [GIT PULL FOR v3.9] Move cx2341x from media/i2c to media/common

[Sakari Ailus]

Hi Laurent,

On Wed, Feb 06, 2013 at 10:41:16AM +0100, Laurent Pinchart wrote:
> On Wednesday 06 February 2013 07:16:04 Mauro Carvalho Chehab wrote:
> > Em Wed, 6 Feb 2013 08:46:35 +0100 Hans Verkuil escreveu:
> > > At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some
> > > relationship with i2c.
> > 
> > True, but none of the three are actually i2c drivers; they're just shared
> > functions used by drivers helper code.
> > 
> > Hmm...
> > 
> > $ git grep aptina-pll.h drivers/media/
> > drivers/media/i2c/aptina-pll.c:#include "aptina-pll.h"
> > drivers/media/i2c/mt9m032.c:#include "aptina-pll.h"
> > drivers/media/i2c/mt9p031.c:#include "aptina-pll.h"
> > 
> > $ git grep smiapp-pll.h drivers/media/
> > drivers/media/i2c/smiapp-pll.c:#include "smiapp-pll.h"
> > drivers/media/i2c/smiapp-pll.h: * drivers/media/i2c/smiapp-pll.h
> > drivers/media/i2c/smiapp/smiapp.h:#include "smiapp-pll.h"
> > 
> > $ git grep smiapp.h drivers/media/
> > drivers/media/i2c/smiapp/smiapp-core.c:#include "smiapp.h"
> > drivers/media/i2c/smiapp/smiapp-limits.c:#include "smiapp.h"
> > drivers/media/i2c/smiapp/smiapp-quirk.c:#include "smiapp.h"
> > drivers/media/i2c/smiapp/smiapp-regs.c:#include "smiapp.h"
> > drivers/media/i2c/smiapp/smiapp.h: * drivers/media/i2c/smiapp/smiapp.h
> > drivers/media/i2c/smiapp/smiapp.h:#include <media/smiapp.h>
> > 
> > It could make sense to keep those two on I2c,
> 
> I'd like that :-) Those helper functions will likely never be used by non-I2C 
> drivers. If they are we can reconsider moving them to common/, but for now it 
> makes sense to keep them in i2c/ in my opinion.

Ack to that. I2c is the bus for the time being but the CSI-3 is
bi-directional:

<URL:http://www.design-reuse.com/sip/30046/mipi-csi-3-camera-serial-interface-receiver/>

The sensors using that bus may well have entirely different PLLs though.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk