All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: S3C24XX: let S3C2412_PM select S3C2412_PM_SLEEP
@ 2013-02-05 21:51 ` Heiko Stübner
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2013-02-05 21:51 UTC (permalink / raw)
  To: Kukjin Kim; +Cc: linux-arm-kernel, linux-samsung-soc

The code to enter sleep is used by both the s3c2412 and s3c2416 and
was thus factored out into an extra config option.

But it seems it was forgotten to add the appropriate select to the
s3c2412 pm option, resulting in breakage when only compiling s3c2412
support.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/mach-s3c24xx/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 5e17e1d..ac61bb7 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -301,6 +301,7 @@ config S3C2412_DMA
 
 config S3C2412_PM
 	bool
+	select S3C2412_PM_SLEEP
 	help
 	  Internal config node to apply S3C2412 power management
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: S3C24XX: let S3C2412_PM select S3C2412_PM_SLEEP
@ 2013-02-05 21:51 ` Heiko Stübner
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2013-02-05 21:51 UTC (permalink / raw)
  To: linux-arm-kernel

The code to enter sleep is used by both the s3c2412 and s3c2416 and
was thus factored out into an extra config option.

But it seems it was forgotten to add the appropriate select to the
s3c2412 pm option, resulting in breakage when only compiling s3c2412
support.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/mach-s3c24xx/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 5e17e1d..ac61bb7 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -301,6 +301,7 @@ config S3C2412_DMA
 
 config S3C2412_PM
 	bool
+	select S3C2412_PM_SLEEP
 	help
 	  Internal config node to apply S3C2412 power management
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: S3C24XX: let S3C2412_PM select S3C2412_PM_SLEEP
  2013-02-05 21:51 ` Heiko Stübner
@ 2013-02-08 22:47   ` Kukjin Kim
  -1 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-02-08 22:47 UTC (permalink / raw)
  To: 'Heiko Stübner'; +Cc: linux-arm-kernel, linux-samsung-soc

Heiko Stübner wrote:
> 
> The code to enter sleep is used by both the s3c2412 and s3c2416 and
> was thus factored out into an extra config option.
> 
> But it seems it was forgotten to add the appropriate select to the
> s3c2412 pm option, resulting in breakage when only compiling s3c2412
> support.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm/mach-s3c24xx/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-
> s3c24xx/Kconfig
> index 5e17e1d..ac61bb7 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -301,6 +301,7 @@ config S3C2412_DMA
> 
>  config S3C2412_PM
>  	bool
> +	select S3C2412_PM_SLEEP
>  	help
>  	  Internal config node to apply S3C2412 power management
> 
> --
> 1.7.10.4

Looks good to me, applied.

Thanks

- Kukjin

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: S3C24XX: let S3C2412_PM select S3C2412_PM_SLEEP
@ 2013-02-08 22:47   ` Kukjin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-02-08 22:47 UTC (permalink / raw)
  To: linux-arm-kernel

Heiko St?bner wrote:
> 
> The code to enter sleep is used by both the s3c2412 and s3c2416 and
> was thus factored out into an extra config option.
> 
> But it seems it was forgotten to add the appropriate select to the
> s3c2412 pm option, resulting in breakage when only compiling s3c2412
> support.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm/mach-s3c24xx/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-
> s3c24xx/Kconfig
> index 5e17e1d..ac61bb7 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -301,6 +301,7 @@ config S3C2412_DMA
> 
>  config S3C2412_PM
>  	bool
> +	select S3C2412_PM_SLEEP
>  	help
>  	  Internal config node to apply S3C2412 power management
> 
> --
> 1.7.10.4

Looks good to me, applied.

Thanks

- Kukjin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-02-08 22:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-05 21:51 [PATCH] ARM: S3C24XX: let S3C2412_PM select S3C2412_PM_SLEEP Heiko Stübner
2013-02-05 21:51 ` Heiko Stübner
2013-02-08 22:47 ` Kukjin Kim
2013-02-08 22:47   ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.