From: Markus Pargmann <mpa@pengutronix.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 03/13] mmc: provide a standard MMC device-tree binding parser centrally
Date: Sat, 09 Feb 2013 13:37:51 +0000 [thread overview]
Message-ID: <20130209133751.GA25584@pengutronix.de> (raw)
In-Reply-To: <1360180020-18555-4-git-send-email-g.liakhovetski@gmx.de>
On Wed, Feb 06, 2013 at 08:46:50PM +0100, Guennadi Liakhovetski wrote:
> + /* Parse Card Detection */
> + if (of_find_property(np, "non-removable", &len)) {
> + host->caps |= MMC_CAP_NONREMOVABLE;
> + } else {
> + bool explicit_inv_cd, gpio_inv_cd = false;
> +
> + explicit_inv_cd = !!of_find_property(np, "cd-inverted", &len);
You could use of_property_read_bool here
> + /* Parse Write Protection */
> + explicit_inv_wp = !!of_find_property(np, "wp-inverted", &len);
and here.
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Markus Pargmann <mpa@pengutronix.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 03/13] mmc: provide a standard MMC device-tree binding parser centrally
Date: Sat, 9 Feb 2013 14:37:51 +0100 [thread overview]
Message-ID: <20130209133751.GA25584@pengutronix.de> (raw)
In-Reply-To: <1360180020-18555-4-git-send-email-g.liakhovetski@gmx.de>
On Wed, Feb 06, 2013 at 08:46:50PM +0100, Guennadi Liakhovetski wrote:
> + /* Parse Card Detection */
> + if (of_find_property(np, "non-removable", &len)) {
> + host->caps |= MMC_CAP_NONREMOVABLE;
> + } else {
> + bool explicit_inv_cd, gpio_inv_cd = false;
> +
> + explicit_inv_cd = !!of_find_property(np, "cd-inverted", &len);
You could use of_property_read_bool here
> + /* Parse Write Protection */
> + explicit_inv_wp = !!of_find_property(np, "wp-inverted", &len);
and here.
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-02-09 13:37 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 19:46 [PATCH v3 00/13] mmc: core and driver DT and related development Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 01/13] mmc: sdhi, tmio: only check flags in tmio-mmc driver proper Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 02/13] mmc: detailed definition of CD and WP MMC line polarities in DT Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 22:30 ` Arnd Bergmann
2013-02-06 22:30 ` Arnd Bergmann
2013-02-06 19:46 ` [PATCH v3 03/13] mmc: provide a standard MMC device-tree binding parser centrally Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-09 13:37 ` Markus Pargmann [this message]
2013-02-09 13:37 ` Markus Pargmann
2013-02-06 19:46 ` [PATCH v3 04/13] mmc: (cosmetic) remove "extern" from function declarations Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 05/13] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
[not found] ` <1360180020-18555-1-git-send-email-g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
2013-02-06 19:46 ` [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
[not found] ` <1360180020-18555-7-git-send-email-g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
2013-02-06 22:24 ` Arnd Bergmann
2013-02-06 22:24 ` Arnd Bergmann
2013-02-07 0:59 ` Simon Horman
2013-02-07 0:59 ` Simon Horman
2013-02-07 8:27 ` Arnd Bergmann
2013-02-07 8:27 ` Arnd Bergmann
2013-02-13 15:59 ` Guennadi Liakhovetski
2013-02-13 15:59 ` Guennadi Liakhovetski
2013-02-14 1:42 ` Magnus Damm
2013-02-14 1:42 ` Magnus Damm
2013-02-14 1:59 ` Simon Horman
2013-02-14 1:59 ` Simon Horman
2013-02-14 2:09 ` Magnus Damm
2013-02-14 2:09 ` Magnus Damm
2013-02-14 2:24 ` Simon Horman
2013-02-14 2:24 ` Simon Horman
2013-02-14 8:28 ` Guennadi Liakhovetski
2013-02-14 8:28 ` Guennadi Liakhovetski
2013-02-14 9:12 ` Magnus Damm
2013-02-14 9:12 ` Magnus Damm
2013-02-14 9:25 ` Guennadi Liakhovetski
2013-02-14 9:25 ` Guennadi Liakhovetski
2013-02-14 15:51 ` Arnd Bergmann
2013-02-06 19:46 ` [PATCH v3 07/13] mmc: tmio-mmc: parse " Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 08/13] mmc: sh_mobile_sdhi: remove unused .pdata field Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 09/13] mmc: sh_mobile_sdhi: use managed resource allocations Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 10/13] mmc: tmio: remove unused and deprecated symbols Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 11/13] mmc: tmio: add support for the VccQ regulator Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:46 ` [PATCH v3 12/13] mmc: add DT bindings for more MMC capability flags Guennadi Liakhovetski
2013-02-06 19:46 ` Guennadi Liakhovetski
2013-02-06 19:47 ` [PATCH v3 13/13] mmc: tmio: add barriers to IO operations Guennadi Liakhovetski
2013-02-06 19:47 ` Guennadi Liakhovetski
2013-02-07 9:51 ` Paul Mundt
2013-02-07 9:51 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209133751.GA25584@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.