From: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: "marvin24-Mmb7MZpHnFY@public.gmane.org"
<marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()
Date: Mon, 11 Feb 2013 05:18:40 +0100 [thread overview]
Message-ID: <20130211.061840.516448986332629268.hdoyu@nvidia.com> (raw)
In-Reply-To: <1828614.u7HcYf891a@ax5200p>
Hi Marc,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org> wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
> ah, ok - I just skipped the "also" in your sentence above. But still, the
> #ifdefs look strange to me and save only a few byte of code. Just me few
> cents.
What about the following as Arnd suggested[1]?
void __init tegra_hotplug_init(void)
{
if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
return;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) && tegra_chip_id == TEGRA20)
tegra_hotplug_shutdown = tegra20_hotplug_shutdown;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_3x_SOC)) && tegra_chip_id == TEGRA30)
tegra_hotplug_shutdown = tegra30_hotplug_shutdown;
}
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148632.html
WARNING: multiple messages have this Message-ID (diff)
From: Hiroshi Doyu <hdoyu@nvidia.com>
To: "marvin24@gmx.de" <marvin24@gmx.de>
Cc: "swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()
Date: Mon, 11 Feb 2013 05:18:40 +0100 [thread overview]
Message-ID: <20130211.061840.516448986332629268.hdoyu@nvidia.com> (raw)
In-Reply-To: <1828614.u7HcYf891a@ax5200p>
Hi Marc,
Marc Dietrich <marvin24@gmx.de> wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
> ah, ok - I just skipped the "also" in your sentence above. But still, the
> #ifdefs look strange to me and save only a few byte of code. Just me few
> cents.
What about the following as Arnd suggested[1]?
void __init tegra_hotplug_init(void)
{
if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
return;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) && tegra_chip_id == TEGRA20)
tegra_hotplug_shutdown = tegra20_hotplug_shutdown;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_3x_SOC)) && tegra_chip_id == TEGRA30)
tegra_hotplug_shutdown = tegra30_hotplug_shutdown;
}
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148632.html
WARNING: multiple messages have this Message-ID (diff)
From: hdoyu@nvidia.com (Hiroshi Doyu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()
Date: Mon, 11 Feb 2013 05:18:40 +0100 [thread overview]
Message-ID: <20130211.061840.516448986332629268.hdoyu@nvidia.com> (raw)
In-Reply-To: <1828614.u7HcYf891a@ax5200p>
Hi Marc,
Marc Dietrich <marvin24@gmx.de> wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
> ah, ok - I just skipped the "also" in your sentence above. But still, the
> #ifdefs look strange to me and save only a few byte of code. Just me few
> cents.
What about the following as Arnd suggested[1]?
void __init tegra_hotplug_init(void)
{
if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
return;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) && tegra_chip_id == TEGRA20)
tegra_hotplug_shutdown = tegra20_hotplug_shutdown;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_3x_SOC)) && tegra_chip_id == TEGRA30)
tegra_hotplug_shutdown = tegra30_hotplug_shutdown;
}
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148632.html
next prev parent reply other threads:[~2013-02-11 4:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 7:29 [PATCH 0/4] ARM: tegra: Unify board-dt-tegra{20,30,114} Hiroshi Doyu
2013-02-08 7:29 ` [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early() Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
[not found] ` <1360308574-19658-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-08 7:47 ` Felipe Balbi
2013-02-08 7:47 ` Felipe Balbi
2013-02-08 7:47 ` Felipe Balbi
[not found] ` <20130208074720.GB21879-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-02-08 8:09 ` Hiroshi Doyu
2013-02-08 8:09 ` Hiroshi Doyu
2013-02-08 8:09 ` Hiroshi Doyu
[not found] ` <20130208.100942.592982910310763762.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-09 12:18 ` Arnd Bergmann
2013-02-09 12:18 ` Arnd Bergmann
2013-02-09 12:18 ` Arnd Bergmann
2013-02-08 12:29 ` Marc Dietrich
2013-02-08 12:29 ` Marc Dietrich
2013-02-08 12:29 ` Marc Dietrich
2013-02-08 17:09 ` Stephen Warren
2013-02-08 17:09 ` Stephen Warren
2013-02-08 17:09 ` Stephen Warren
[not found] ` <51153136.7010705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-10 17:28 ` Marc Dietrich
2013-02-10 17:28 ` Marc Dietrich
2013-02-10 17:28 ` Marc Dietrich
2013-02-10 20:20 ` Stephen Warren
2013-02-10 20:20 ` Stephen Warren
2013-02-10 20:20 ` Stephen Warren
[not found] ` <51180121.6040803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-10 21:16 ` Marc Dietrich
2013-02-10 21:16 ` Marc Dietrich
2013-02-10 21:16 ` Marc Dietrich
2013-02-11 4:18 ` Hiroshi Doyu [this message]
2013-02-11 4:18 ` Hiroshi Doyu
2013-02-11 4:18 ` Hiroshi Doyu
2013-02-08 7:29 ` [PATCH 2/4] ARM: tegra: Unify board-dt-tegra{30,114}.c Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` [PATCH 3/4] ARM: tegra: Unify board-dt-tegra{20,30}.c to tegra.c Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` [PATCH 4/4] ARM: tegra: Restore USB/PCIE info in new DT board file Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
2013-02-08 7:29 ` Hiroshi Doyu
[not found] ` <1360308574-19658-5-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-08 17:58 ` Stephen Warren
2013-02-08 17:58 ` Stephen Warren
2013-02-08 17:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211.061840.516448986332629268.hdoyu@nvidia.com \
--to=hdoyu-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.