All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ieee802154: at86rf230: Remove empty suspend/resume callbacks
@ 2013-02-15 13:03 Lars-Peter Clausen
  2013-02-15 20:35 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-02-15 13:03 UTC (permalink / raw)
  To: Alexander Smirnov, Dmitry Eremin-Solenikov, David S. Miller
  Cc: linux-zigbee-devel, netdev, Lars-Peter Clausen

There is no need to implement empty suspend/resume callbacks if there is nothing
to do during suspend/resume. The drivers will behave the same with no callbacks
or empty callbacks during suspend/resume.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/net/ieee802154/at86rf230.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index a4a62e1..fc1687e 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -751,16 +751,6 @@ static int at86rf230_hw_init(struct at86rf230_local *lp)
 	return 0;
 }
 
-static int at86rf230_suspend(struct spi_device *spi, pm_message_t message)
-{
-	return 0;
-}
-
-static int at86rf230_resume(struct spi_device *spi)
-{
-	return 0;
-}
-
 static int at86rf230_fill_data(struct spi_device *spi)
 {
 	struct at86rf230_local *lp = spi_get_drvdata(spi);
@@ -948,8 +938,6 @@ static struct spi_driver at86rf230_driver = {
 	},
 	.probe      = at86rf230_probe,
 	.remove     = at86rf230_remove,
-	.suspend    = at86rf230_suspend,
-	.resume     = at86rf230_resume,
 };
 
 module_spi_driver(at86rf230_driver);
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ieee802154: at86rf230: Remove empty suspend/resume callbacks
  2013-02-15 13:03 [PATCH] ieee802154: at86rf230: Remove empty suspend/resume callbacks Lars-Peter Clausen
@ 2013-02-15 20:35 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-15 20:35 UTC (permalink / raw)
  To: lars; +Cc: alex.bluesman.smirnov, dbaryshkov, linux-zigbee-devel, netdev

From: Lars-Peter Clausen <lars@metafoo.de>
Date: Fri, 15 Feb 2013 14:03:29 +0100

> There is no need to implement empty suspend/resume callbacks if there is nothing
> to do during suspend/resume. The drivers will behave the same with no callbacks
> or empty callbacks during suspend/resume.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-15 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-15 13:03 [PATCH] ieee802154: at86rf230: Remove empty suspend/resume callbacks Lars-Peter Clausen
2013-02-15 20:35 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.