Re: [PATCH] Added license header to dtc/libfdt/fdt.h and libfdt_env.h

From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Kim Phillips <kim.phillips-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Justin Sobota <jsobota-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] Added license header to dtc/libfdt/fdt.h and libfdt_env.h
Date: Fri, 15 Feb 2013 14:40:28 +1100	[thread overview]
Message-ID: <20130215034028.GE29108@truffula.fritz.box> (raw)
In-Reply-To: <20130214183936.e82dbf45c5708f8084de2d62-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1682 bytes --]

On Thu, Feb 14, 2013 at 06:39:36PM -0600, Kim Phillips wrote:
> On Thu, 14 Feb 2013 10:32:56 +1100
> David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> 
> > On Wed, Feb 13, 2013 at 11:32:01AM -0500, Justin Sobota wrote:
> > > This commit adds a license header to fdt.h and libfdt_env.h because
> > > the license was omitted
> > 
> > So, having a quick look at the git blame for both these files, it
> > looks like Kim Phillips (CCed) also touched them substantially.
> > 
> > Kim, did you want to supply an additional copyright line for these files?
> 
> sure, it'd be:
> 
> Copyright 2012 Kim Phillips, Freescale Semiconductor.
> 
> I can spin a patch on top of this one, or - wait...
> 
> > > Signed-off-by: Justin Sobota <jsobota-l0cyMroinI0@public.gmane.org>
> > > ---
> > >  libfdt/fdt.h        |   50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  libfdt/libfdt_env.h |   50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 100 insertions(+)
> > >  mode change 100644 => 100755 libfdt/fdt.h
> > >  mode change 100644 => 100755 libfdt/libfdt_env.h
> 
> ...what's up with making them executable?

Good point, didn't notice that.  I'm guessing an accidental transition
through a FAT filing system.

> So I'm assuming this patch is going to be respun to not include the
> mode changes, in which case please add the above copyright line
> under David's.
> 
> Thanks,
> 
> Kim
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss