All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: devel@lists.open80211s.org
Cc: Marco Porsch <marco@cozybit.com>,
	vthiagar@qca.qualcomm.com, jouni@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, mcgrof@qca.qualcomm.com,
	ath9k-devel@lists.ath9k.org, senthilb@qca.qualcomm.com,
	johannes@sipsolutions.net
Subject: Re: [PATCH 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Fri, 15 Feb 2013 07:42:55 -0500	[thread overview]
Message-ID: <20130215124255.GB3493@localhost> (raw)
In-Reply-To: <20130215124046.GA3493@localhost>

On Fri, Feb 15, 2013 at 07:40:46AM -0500, Bob Copeland wrote:
> > I don't think you should drop this comment; also why not just address
> > it? There's a timestamp in rx_status that should be the correct one for
> > ath9k (which is pretty much all this seems to work on anyway :) )
> 
> The comment is just moved?  Mesh already uses rx_status->mactime, if
> the driver supplies it, which the comment says :)

Oh I see - you are saying not to drop the comment about rcu locking.

-- 
Bob Copeland %% www.bobcopeland.com

WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Fri, 15 Feb 2013 07:42:55 -0500	[thread overview]
Message-ID: <20130215124255.GB3493@localhost> (raw)
In-Reply-To: <20130215124046.GA3493@localhost>

On Fri, Feb 15, 2013 at 07:40:46AM -0500, Bob Copeland wrote:
> > I don't think you should drop this comment; also why not just address
> > it? There's a timestamp in rx_status that should be the correct one for
> > ath9k (which is pretty much all this seems to work on anyway :) )
> 
> The comment is just moved?  Mesh already uses rx_status->mactime, if
> the driver supplies it, which the comment says :)

Oh I see - you are saying not to drop the comment about rcu locking.

-- 
Bob Copeland %% www.bobcopeland.com

  reply	other threads:[~2013-02-15 12:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 11:40 [PATCH 1/3] mac80211: move mesh sync beacon handler into neighbour_update Marco Porsch
2013-02-15 11:40 ` [ath9k-devel] " Marco Porsch
2013-02-15 11:40 ` [PATCH 2/3] mac80211: mesh power save doze scheduling Marco Porsch
2013-02-15 11:40   ` [ath9k-devel] " Marco Porsch
2013-02-15 11:40 ` [PATCH 3/3] ath9k: mesh powersave support Marco Porsch
2013-02-15 11:40   ` [ath9k-devel] " Marco Porsch
2013-02-15 12:14 ` [PATCH 1/3] mac80211: move mesh sync beacon handler into neighbour_update Johannes Berg
2013-02-15 12:14   ` [ath9k-devel] " Johannes Berg
2013-02-15 12:40   ` Bob Copeland
2013-02-15 12:40     ` [ath9k-devel] " Bob Copeland
2013-02-15 12:42     ` Bob Copeland [this message]
2013-02-15 12:42       ` Bob Copeland
2013-02-15 13:30       ` Marco Porsch
2013-02-15 13:30         ` [ath9k-devel] " Marco Porsch
2013-02-15 12:40   ` marco
2013-02-15 12:40     ` [ath9k-devel] " marco at cozybit.com
2013-02-15 12:46     ` Johannes Berg
2013-02-15 12:46       ` [ath9k-devel] " Johannes Berg
2013-02-15 13:31       ` Marco Porsch
2013-02-15 13:31         ` [ath9k-devel] " Marco Porsch
2013-02-15 13:37         ` Johannes Berg
2013-02-15 13:37           ` [ath9k-devel] " Johannes Berg
2013-02-15 13:48           ` Marco Porsch
2013-02-15 13:48             ` [ath9k-devel] " Marco Porsch
2013-02-15 13:58             ` Johannes Berg
2013-02-15 13:58               ` [ath9k-devel] " Johannes Berg
2013-02-18 15:07               ` Marco Porsch
2013-02-18 15:07                 ` [ath9k-devel] " Marco Porsch
2013-02-18 15:20                 ` Johannes Berg
2013-02-18 15:20                   ` [ath9k-devel] " Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215124255.GB3493@localhost \
    --to=me@bobcopeland.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=devel@lists.open80211s.org \
    --cc=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marco@cozybit.com \
    --cc=mcgrof@qca.qualcomm.com \
    --cc=senthilb@qca.qualcomm.com \
    --cc=vthiagar@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.