From: Vivek Goyal <vgoyal@redhat.com> To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> Cc: ebiederm@xmission.com, cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/13] vmcore: introduce types for objects copied in 2nd kernel Date: Fri, 15 Feb 2013 10:28:28 -0500 [thread overview] Message-ID: <20130215152828.GC27784@redhat.com> (raw) In-Reply-To: <20130214101205.22466.5909.stgit@localhost6.localdomain6> On Thu, Feb 14, 2013 at 07:12:05PM +0900, HATAYAMA Daisuke wrote: > Some parts of old memory need to be copied in buffers on 2nd kernel to > be remapped to user-space. To distinguish objects in the buffer on 2nd > kernel and the ones on old memory, enum vmcore_type is introduced: the > object in the buffer on 2nd kernel has VMCORE_2ND_KERNEL type, and the > one on old memory has VMCORE_OLD_MEMORY type. > > Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> > --- > > include/linux/proc_fs.h | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 32676b3..4b153ed 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -97,11 +97,20 @@ struct kcore_list { > int type; > }; > > +enum vmcore_type { > + VMCORE_OLD_MEMORY, > + VMCORE_2ND_KERNEL, This VMCORE_2ND_KERNEL tag looks bad. How about introducing a "unsigned int flag" element in "struct vmcore" and set the flag MEM_TYPE_OLDMEM for any contents which come from oldmem. If MEM_TYPE_OLDMEM is not set, it is assumed that contents are to be fetched from current kernel using pointer vmcore->buf. BTW, which elements you need to copy from first kernel? > +}; > + > struct vmcore { > struct list_head list; > - unsigned long long paddr; > + union { > + unsigned long long paddr; > + char *buf; > + }; > unsigned long long size; > loff_t offset; > + enum vmcore_type type; > }; > Thanks Vivek > #ifdef CONFIG_PROC_FS
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, cpw@sgi.com Subject: Re: [PATCH 04/13] vmcore: introduce types for objects copied in 2nd kernel Date: Fri, 15 Feb 2013 10:28:28 -0500 [thread overview] Message-ID: <20130215152828.GC27784@redhat.com> (raw) In-Reply-To: <20130214101205.22466.5909.stgit@localhost6.localdomain6> On Thu, Feb 14, 2013 at 07:12:05PM +0900, HATAYAMA Daisuke wrote: > Some parts of old memory need to be copied in buffers on 2nd kernel to > be remapped to user-space. To distinguish objects in the buffer on 2nd > kernel and the ones on old memory, enum vmcore_type is introduced: the > object in the buffer on 2nd kernel has VMCORE_2ND_KERNEL type, and the > one on old memory has VMCORE_OLD_MEMORY type. > > Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> > --- > > include/linux/proc_fs.h | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 32676b3..4b153ed 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -97,11 +97,20 @@ struct kcore_list { > int type; > }; > > +enum vmcore_type { > + VMCORE_OLD_MEMORY, > + VMCORE_2ND_KERNEL, This VMCORE_2ND_KERNEL tag looks bad. How about introducing a "unsigned int flag" element in "struct vmcore" and set the flag MEM_TYPE_OLDMEM for any contents which come from oldmem. If MEM_TYPE_OLDMEM is not set, it is assumed that contents are to be fetched from current kernel using pointer vmcore->buf. BTW, which elements you need to copy from first kernel? > +}; > + > struct vmcore { > struct list_head list; > - unsigned long long paddr; > + union { > + unsigned long long paddr; > + char *buf; > + }; > unsigned long long size; > loff_t offset; > + enum vmcore_type type; > }; > Thanks Vivek > #ifdef CONFIG_PROC_FS _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-02-15 15:28 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-14 10:11 [PATCH 00/13] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke 2013-02-14 10:11 ` HATAYAMA Daisuke 2013-02-14 10:11 ` [PATCH 01/13] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke 2013-02-14 10:11 ` HATAYAMA Daisuke 2013-02-15 15:01 ` Vivek Goyal 2013-02-15 15:01 ` Vivek Goyal 2013-02-14 10:11 ` [PATCH 02/13] vmcore: round up buffer size of ELF headers by PAGE_SIZE HATAYAMA Daisuke 2013-02-14 10:11 ` HATAYAMA Daisuke 2013-02-15 15:18 ` Vivek Goyal 2013-02-15 15:18 ` Vivek Goyal 2013-02-18 15:58 ` HATAYAMA Daisuke 2013-02-18 15:58 ` HATAYAMA Daisuke 2013-02-14 10:11 ` [PATCH 03/13] vmcore: fill unused part of buffer for ELF headers with 0 HATAYAMA Daisuke 2013-02-14 10:11 ` HATAYAMA Daisuke 2013-02-14 10:12 ` [PATCH 04/13] vmcore: introduce types for objects copied in 2nd kernel HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 15:28 ` Vivek Goyal [this message] 2013-02-15 15:28 ` Vivek Goyal 2013-02-18 16:06 ` HATAYAMA Daisuke 2013-02-18 16:06 ` HATAYAMA Daisuke 2013-02-19 23:07 ` Vivek Goyal 2013-02-19 23:07 ` Vivek Goyal 2013-02-14 10:12 ` [PATCH 05/13] vmcore: modify ELF32 code according to new type HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 15:30 ` Vivek Goyal 2013-02-15 15:30 ` Vivek Goyal 2013-02-18 16:11 ` HATAYAMA Daisuke 2013-02-18 16:11 ` HATAYAMA Daisuke 2013-02-14 10:12 ` [PATCH 06/13] vmcore: modify vmcore clean-up function to free buffer on 2nd kernel HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 15:32 ` Vivek Goyal 2013-02-15 15:32 ` Vivek Goyal 2013-02-14 10:12 ` [PATCH 07/13] vmcore: modify read_vmcore() to read " HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 15:51 ` Vivek Goyal 2013-02-15 15:51 ` Vivek Goyal 2013-02-14 10:12 ` [PATCH 08/13] vmcore: remove unused helper function HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 15:52 ` Vivek Goyal 2013-02-15 15:52 ` Vivek Goyal 2013-02-14 10:12 ` [PATCH 09/13] vmcore: copy ELF note segments in buffer on 2nd kernel HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 16:53 ` Vivek Goyal 2013-02-15 16:53 ` Vivek Goyal 2013-02-18 17:02 ` HATAYAMA Daisuke 2013-02-18 17:02 ` HATAYAMA Daisuke 2013-02-19 23:05 ` Vivek Goyal 2013-02-19 23:05 ` Vivek Goyal 2013-02-14 10:12 ` [PATCH 10/13] vmcore: round-up offset of vmcore object in page-size boundary HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-14 10:12 ` [PATCH 11/13] vmcore: count holes generated by round-up operation for vmcore size HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-14 10:12 ` [PATCH 12/13] vmcore: copy non page-size aligned head and tail pages in 2nd kernel HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-14 10:12 ` [PATCH 13/13] vmcore: introduce mmap_vmcore() HATAYAMA Daisuke 2013-02-14 10:12 ` HATAYAMA Daisuke 2013-02-15 3:57 ` [PATCH 00/13] kdump, vmcore: support mmap() on /proc/vmcore Atsushi Kumagai 2013-02-15 3:57 ` Atsushi Kumagai 2013-02-18 0:16 ` Hatayama, Daisuke 2013-02-18 0:16 ` Hatayama, Daisuke 2013-03-27 5:51 ` makedumpfile mmap() benchmark Jingbai Ma 2013-03-27 5:51 ` Jingbai Ma 2013-03-27 6:23 ` HATAYAMA Daisuke 2013-03-27 6:23 ` HATAYAMA Daisuke 2013-03-27 6:35 ` Jingbai Ma 2013-03-27 6:35 ` Jingbai Ma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130215152828.GC27784@redhat.com \ --to=vgoyal@redhat.com \ --cc=cpw@sgi.com \ --cc=d.hatayama@jp.fujitsu.com \ --cc=ebiederm@xmission.com \ --cc=kexec@lists.infradead.org \ --cc=kumagai-atsushi@mxc.nes.nec.co.jp \ --cc=linux-kernel@vger.kernel.org \ --cc=lisa.mitchell@hp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.