All of lore.kernel.org
 help / color / mirror / Atom feed
* [to-be-updated] futex-avoid-kernel-taint-caused-by-get_robust_list.patch removed from -mm tree
@ 2013-02-15 23:45 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2013-02-15 23:45 UTC (permalink / raw)
  To: paul.gortmaker, davej, keescook, richard, stable, tglx, mm-commits


The patch titled
     Subject: futex: avoid kernel taint caused by get_robust_list
has been removed from the -mm tree.  Its filename was
     futex-avoid-kernel-taint-caused-by-get_robust_list.patch

This patch was dropped because an updated version will be merged

------------------------------------------------------
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: futex: avoid kernel taint caused by get_robust_list

Commit ec0c4274e33c0373e4 ("futex: Mark get_robust_list as deprecated")
added these two WARN_ONCE calls.

However, WARN_ONCE taints the kernel, and we shouldn't be allowing any
user who wanders by to do this.  For example, the system fuzzer "trinity"
uses the tainted state as a metric for when to stop, assuming that it has
caused significant wreckage (and indeed that tool is what actually led me
to this change).

The ability to deprecate this code has been called into question[1], but
if that remains to be finalized, then making this change in the interim
seems to make sense.

[1] http://lkml.indiana.edu/hypermail/linux/kernel/1208.0/01081.html

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@vger.kernel.org>	[3.4+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/futex.c        |    2 +-
 kernel/futex_compat.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -puN kernel/futex.c~futex-avoid-kernel-taint-caused-by-get_robust_list kernel/futex.c
--- a/kernel/futex.c~futex-avoid-kernel-taint-caused-by-get_robust_list
+++ a/kernel/futex.c
@@ -2472,7 +2472,7 @@ SYSCALL_DEFINE3(get_robust_list, int, pi
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
+	printk_once(KERN_WARNING "deprecated: get_robust_list will be deleted in 2013.\n");
 
 	rcu_read_lock();
 
diff -puN kernel/futex_compat.c~futex-avoid-kernel-taint-caused-by-get_robust_list kernel/futex_compat.c
--- a/kernel/futex_compat.c~futex-avoid-kernel-taint-caused-by-get_robust_list
+++ a/kernel/futex_compat.c
@@ -143,7 +143,7 @@ COMPAT_SYSCALL_DEFINE3(get_robust_list, 
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
+	printk_once(KERN_WARNING "deprecated: get_robust_list will be deleted in 2013.\n");
 
 	rcu_read_lock();
 
_

Patches currently in -mm which might be from paul.gortmaker@windriver.com are

linux-next.patch
compiler-gcc4h-reorder-macros-based-upon-gcc-ver.patch
compiler-gcch-add-gcc-recommended-gcc_version-macro.patch
compiler-gcc34h-use-gcc_version-macro.patch
compiler-gcc4h-bugh-remove-duplicate-macros.patch
bugh-fix-build_bug_on-macro-in-__checker__.patch
bugh-prevent-double-evaulation-of-in-build_bug_on.patch
bugh-make-build_bug_on-generate-compile-time-error.patch
compilerh-bugh-prevent-double-error-messages-with-build_bug_on.patch
bugh-compilerh-introduce-compiletime_assert-build_bug_on_msg.patch
inotify-remove-broken-mask-checks-causing-unmount-to-be-einval.patch
time-dont-inline-export_symbol-functions.patch
dca-convert-to-idr_alloc.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-02-15 23:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-15 23:45 [to-be-updated] futex-avoid-kernel-taint-caused-by-get_robust_list.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.