* [PATCH] ipv4: xfrm4_mode_tunnel: Fix warning
@ 2013-02-18 13:45 Fabio Estevam
2013-02-18 17:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-02-18 13:45 UTC (permalink / raw)
To: davem; +Cc: pshelar, edumazet, netdev, Fabio Estevam
Fix the following warning:
net/ipv4/xfrm4_mode_tunnel.c:145:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
net/ipv4/xfrm4_mode_tunnel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/xfrm4_mode_tunnel.c b/net/ipv4/xfrm4_mode_tunnel.c
index 1162ace..fe5189e 100644
--- a/net/ipv4/xfrm4_mode_tunnel.c
+++ b/net/ipv4/xfrm4_mode_tunnel.c
@@ -142,7 +142,8 @@ static int xfrm4_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
for_each_input_rcu(rcv_notify_handlers, handler)
handler->handler(skb);
- if (err = skb_unclone(skb, GFP_ATOMIC))
+ err = skb_unclone(skb, GFP_ATOMIC);
+ if (err)
goto out;
if (x->props.flags & XFRM_STATE_DECAP_DSCP)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv4: xfrm4_mode_tunnel: Fix warning
2013-02-18 13:45 [PATCH] ipv4: xfrm4_mode_tunnel: Fix warning Fabio Estevam
@ 2013-02-18 17:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-18 17:42 UTC (permalink / raw)
To: fabio.estevam; +Cc: pshelar, edumazet, netdev
Stephen Hemminger already submitted the patches necessary to fix these
warnings.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-18 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-18 13:45 [PATCH] ipv4: xfrm4_mode_tunnel: Fix warning Fabio Estevam
2013-02-18 17:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.