All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: balbi@ti.com, linux-omap@vger.kernel.org,
	khilman@deeprootsystems.com, paul@pwsan.com, tony@atomide.com,
	sourav.poddar@ti.com, vaibhav.bedia@ti.com,
	linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver
Date: Mon, 18 Feb 2013 13:13:08 +0200	[thread overview]
Message-ID: <20130218111308.GE32688@arwen.pp.htv.fi> (raw)
In-Reply-To: <512208BE.7060207@ti.com>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Hi,

On Mon, Feb 18, 2013 at 04:25:58PM +0530, Santosh Shilimkar wrote:
> >>If I read the code correctly there's nothing setting oh->mux during DT
> >>boot. The only caller to omap_hwmod_mux_init() (which allocates and
> >>returns omap_hwmod_mux_info pointer) is
> >>arch/arm/mach-omap2/devices.c::omap4_keyboard_init(). This has nothing
> >
> >actually arch/arm/mach-omap2/serial.c::omap_serial_init_port() also
> >calls that, but it's also not used during DT boots.
> >
> DT boot, all the function pointers are broken so wakeup as well as slave
> idle-mode is broken. Nothing new here. Serial file does set the pads
> as you noticed and this is what can be offloaded to generic pint control
> which can triggered from driver.

fair enough, understood now.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver
Date: Mon, 18 Feb 2013 13:13:08 +0200	[thread overview]
Message-ID: <20130218111308.GE32688@arwen.pp.htv.fi> (raw)
In-Reply-To: <512208BE.7060207@ti.com>

Hi,

On Mon, Feb 18, 2013 at 04:25:58PM +0530, Santosh Shilimkar wrote:
> >>If I read the code correctly there's nothing setting oh->mux during DT
> >>boot. The only caller to omap_hwmod_mux_init() (which allocates and
> >>returns omap_hwmod_mux_info pointer) is
> >>arch/arm/mach-omap2/devices.c::omap4_keyboard_init(). This has nothing
> >
> >actually arch/arm/mach-omap2/serial.c::omap_serial_init_port() also
> >calls that, but it's also not used during DT boots.
> >
> DT boot, all the function pointers are broken so wakeup as well as slave
> idle-mode is broken. Nothing new here. Serial file does set the pads
> as you noticed and this is what can be offloaded to generic pint control
> which can triggered from driver.

fair enough, understood now.

cheers

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130218/10c134e7/attachment.sig>

  reply	other threads:[~2013-02-18 11:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 12:06 [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver Santosh Shilimkar
2013-02-15 12:06 ` Santosh Shilimkar
2013-02-15 13:03 ` a0131647
2013-02-15 13:03   ` a0131647
2013-02-15 13:07   ` Felipe Balbi
2013-02-15 13:07     ` Felipe Balbi
2013-02-15 13:08     ` Felipe Balbi
2013-02-15 13:08       ` Felipe Balbi
2013-02-15 13:42       ` a0131647
2013-02-15 13:42         ` a0131647
2013-02-15 13:50         ` Santosh Shilimkar
2013-02-15 13:50           ` Santosh Shilimkar
2013-02-18 10:04 ` Santosh Shilimkar
2013-02-18 10:04   ` Santosh Shilimkar
2013-02-18 10:10   ` Felipe Balbi
2013-02-18 10:10     ` Felipe Balbi
2013-02-18 10:11     ` Felipe Balbi
2013-02-18 10:11       ` Felipe Balbi
2013-02-18 10:25       ` Santosh Shilimkar
2013-02-18 10:25         ` Santosh Shilimkar
2013-02-18 10:42         ` Felipe Balbi
2013-02-18 10:42           ` Felipe Balbi
2013-02-18 10:45           ` Felipe Balbi
2013-02-18 10:45             ` Felipe Balbi
2013-02-18 10:55             ` Santosh Shilimkar
2013-02-18 10:55               ` Santosh Shilimkar
2013-02-18 11:13               ` Felipe Balbi [this message]
2013-02-18 11:13                 ` Felipe Balbi
2013-02-18 14:36                 ` Santosh Shilimkar
2013-02-18 14:36                   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218111308.GE32688@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=sourav.poddar@ti.com \
    --cc=tony@atomide.com \
    --cc=vaibhav.bedia@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.