All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Hugne <erik.hugne@ericsson.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH net-next (V2, RESENT)] ipv6: Queue fragments per interface for multicast/link-local addresses.
Date: Mon, 18 Feb 2013 14:19:01 +0100	[thread overview]
Message-ID: <20130218131901.GA24346@eerihug-hybrid.ki.sw.ericsson.se> (raw)
In-Reply-To: <511FB776.8000901@linux-ipv6.org>

On Sun, Feb 17, 2013 at 01:44:38AM +0900, YOSHIFUJI Hideaki wrote:
> We should queue fragments for the same link-local address on
> different interfaces (e.g. fe80::1%eth0 and fe80::1%eth1) to the
> different queue, because of nature of addressing architecture.
> 
> Similarly, we should queue fragments for multicast on different
> interface to the different queue.  This is okay because
> application joins group on speicific interface, and multicast
> traffic is expected only on that interface.
>

Your patch does solve the reassembly problem when macvlans are defined, thanks!

A tad unrelated, but i think there's still some ipv6 multicast filtering 
work to be done in the macvlan driver. If you for example join an all scope 
mcast address, ff09::1 on macvlan 0 it will implicitly be 'joined' on all 
other macvlans aswell..

I can buy that linklocal multicast packets are cloned out to all macvlan devices,
but if a specific prefix is joined on one of them, i dont think it's correct that
all sibling devices should receive that traffic, unless they asked for it.

//E

  reply	other threads:[~2013-02-18 13:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16  5:49 [RFC PATCH net-next (V2)] ipv6: Queue fragments per interface for multicast/link-local addresses YOSHIFUJI Hideaki
2013-02-16  6:25 ` Eric Dumazet
2013-02-16 11:39   ` YOSHIFUJI Hideaki
2013-02-16 16:15     ` Eric Dumazet
2013-02-16 18:53       ` Vlad Yasevich
2013-02-16 16:44 ` [RFC PATCH net-next (V2, RESENT)] " YOSHIFUJI Hideaki
2013-02-18 13:19   ` Erik Hugne [this message]
2013-03-16  7:47   ` Hannes Frederic Sowa
2013-03-17  0:50     ` YOSHIFUJI Hideaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218131901.GA24346@eerihug-hybrid.ki.sw.ericsson.se \
    --to=erik.hugne@ericsson.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.