All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH net-next (V2, RESENT)] ipv6: Queue fragments per interface for multicast/link-local addresses.
Date: Sat, 16 Mar 2013 08:47:45 +0100	[thread overview]
Message-ID: <20130316074745.GC24041@order.stressinduktion.org> (raw)
In-Reply-To: <511FB776.8000901@linux-ipv6.org>

On Sun, Feb 17, 2013 at 01:44:38AM +0900, YOSHIFUJI Hideaki wrote:
> We should queue fragments for the same link-local address on
> different interfaces (e.g. fe80::1%eth0 and fe80::1%eth1) to the
> different queue, because of nature of addressing architecture.
> 
> Similarly, we should queue fragments for multicast on different
> interface to the different queue.  This is okay because
> application joins group on speicific interface, and multicast
> traffic is expected only on that interface.
> 
> CC: Ben Greear <greearb@candelatech.com>
> CC: Vlad Yasevich <vyasevic@redhat.com>
> CC: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

I just found this patch while cleaning up my tree. I don't know its state
(netdev patchworks says RFC and netfilter patchworks still lists it as
new). However, I also do think that the per interface matching would be
the right thing to do for multicast|linklocal fragments. Perhaps this patch
should be resend?

Yoshifuji, do you think we should also implement RFC 3168 5.3 ECN
fragmentation protection in reassembly.c? I think it should be
straightforward because it is already implemented for ipv4 and the
relevant bits just need to be moved to inet_fragment.c and become a bit
more generalized.

Thanks,

  Hannes


  parent reply	other threads:[~2013-03-16  7:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16  5:49 [RFC PATCH net-next (V2)] ipv6: Queue fragments per interface for multicast/link-local addresses YOSHIFUJI Hideaki
2013-02-16  6:25 ` Eric Dumazet
2013-02-16 11:39   ` YOSHIFUJI Hideaki
2013-02-16 16:15     ` Eric Dumazet
2013-02-16 18:53       ` Vlad Yasevich
2013-02-16 16:44 ` [RFC PATCH net-next (V2, RESENT)] " YOSHIFUJI Hideaki
2013-02-18 13:19   ` Erik Hugne
2013-03-16  7:47   ` Hannes Frederic Sowa [this message]
2013-03-17  0:50     ` YOSHIFUJI Hideaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130316074745.GC24041@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.