From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] R-Car SATA driver and platform data
Date: Tue, 19 Feb 2013 00:49:47 +0000 [thread overview]
Message-ID: <20130219004947.GB14932@verge.net.au> (raw)
In-Reply-To: <512234E5.5050700@cogentembedded.com>
On Mon, Feb 18, 2013 at 06:04:21PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 18-02-2013 5:23, Simon Horman wrote:
>
> >> Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:
>
> >>[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration
> >>[2/4] ARM: mach-shmobile: r8a7779: add SATA support
> >>[3/4] libata: add R-Car SATA driver
> >>[4/4] ARM: mach-shmobile: marzen: add SATA support
>
> >>Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.
>
> >Hi Sergei, Hi All,
>
> >I do not expect patch 3 of this series to got through
> >the renesas tree, however, I have included it and the other three patches
> >in this series to a topic branch in the renesas tree, topic/r-car-stat.
>
> I probably make the patch 3 patch 1 in the next posting.
>
> >The base of the topic branch is:
> >* a merge of renesas.git next and libata-dev.git upstream, and;
> >* a boot fix for Marzen which I plan to add to next once it is reviewed:
> > "ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).
>
> >With this in place I built a kernel using the marzen_defconfig and booted it.
> >However, I wonder if I am missing a kernel option, or perhaps something
> >else of a minor nature as I see the following:
>
> ># dmesg | grep sata
> >sata_rcar sata_rcar: coherent DMA mask is unset
> >sata_rcar sata_rcar: failed to start port 0 (errno=-12)
> >sata_rcar: probe of sata_rcar failed with error -12
>
> No, it's entirely our fault -- Vladimir didn't test the driver in
> non-DT mode with DMA support added (due to the above mentioned boot
> fix missing), and I didn't notice the missing intializers for
> 'sata_device.dev.[coherent_]dma_mask' when reviewing his patches. V2
> will be posted soon.
Great, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
jgarzik@pobox.com, linux-ide@vger.kernel.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 0/4] R-Car SATA driver and platform data
Date: Tue, 19 Feb 2013 09:49:47 +0900 [thread overview]
Message-ID: <20130219004947.GB14932@verge.net.au> (raw)
In-Reply-To: <512234E5.5050700@cogentembedded.com>
On Mon, Feb 18, 2013 at 06:04:21PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 18-02-2013 5:23, Simon Horman wrote:
>
> >> Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:
>
> >>[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration
> >>[2/4] ARM: mach-shmobile: r8a7779: add SATA support
> >>[3/4] libata: add R-Car SATA driver
> >>[4/4] ARM: mach-shmobile: marzen: add SATA support
>
> >>Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.
>
> >Hi Sergei, Hi All,
>
> >I do not expect patch 3 of this series to got through
> >the renesas tree, however, I have included it and the other three patches
> >in this series to a topic branch in the renesas tree, topic/r-car-stat.
>
> I probably make the patch 3 patch 1 in the next posting.
>
> >The base of the topic branch is:
> >* a merge of renesas.git next and libata-dev.git upstream, and;
> >* a boot fix for Marzen which I plan to add to next once it is reviewed:
> > "ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).
>
> >With this in place I built a kernel using the marzen_defconfig and booted it.
> >However, I wonder if I am missing a kernel option, or perhaps something
> >else of a minor nature as I see the following:
>
> ># dmesg | grep sata
> >sata_rcar sata_rcar: coherent DMA mask is unset
> >sata_rcar sata_rcar: failed to start port 0 (errno=-12)
> >sata_rcar: probe of sata_rcar failed with error -12
>
> No, it's entirely our fault -- Vladimir didn't test the driver in
> non-DT mode with DMA support added (due to the above mentioned boot
> fix missing), and I didn't notice the missing intializers for
> 'sata_device.dev.[coherent_]dma_mask' when reviewing his patches. V2
> will be posted soon.
Great, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] R-Car SATA driver and platform data
Date: Tue, 19 Feb 2013 09:49:47 +0900 [thread overview]
Message-ID: <20130219004947.GB14932@verge.net.au> (raw)
In-Reply-To: <512234E5.5050700@cogentembedded.com>
On Mon, Feb 18, 2013 at 06:04:21PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 18-02-2013 5:23, Simon Horman wrote:
>
> >> Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:
>
> >>[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration
> >>[2/4] ARM: mach-shmobile: r8a7779: add SATA support
> >>[3/4] libata: add R-Car SATA driver
> >>[4/4] ARM: mach-shmobile: marzen: add SATA support
>
> >>Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.
>
> >Hi Sergei, Hi All,
>
> >I do not expect patch 3 of this series to got through
> >the renesas tree, however, I have included it and the other three patches
> >in this series to a topic branch in the renesas tree, topic/r-car-stat.
>
> I probably make the patch 3 patch 1 in the next posting.
>
> >The base of the topic branch is:
> >* a merge of renesas.git next and libata-dev.git upstream, and;
> >* a boot fix for Marzen which I plan to add to next once it is reviewed:
> > "ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).
>
> >With this in place I built a kernel using the marzen_defconfig and booted it.
> >However, I wonder if I am missing a kernel option, or perhaps something
> >else of a minor nature as I see the following:
>
> ># dmesg | grep sata
> >sata_rcar sata_rcar: coherent DMA mask is unset
> >sata_rcar sata_rcar: failed to start port 0 (errno=-12)
> >sata_rcar: probe of sata_rcar failed with error -12
>
> No, it's entirely our fault -- Vladimir didn't test the driver in
> non-DT mode with DMA support added (due to the above mentioned boot
> fix missing), and I didn't notice the missing intializers for
> 'sata_device.dev.[coherent_]dma_mask' when reviewing his patches. V2
> will be posted soon.
Great, thanks.
next prev parent reply other threads:[~2013-02-19 0:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 21:35 [PATCH 0/4] R-Car SATA driver and platform data Sergei Shtylyov
2013-02-16 22:35 ` Sergei Shtylyov
2013-02-16 22:35 ` Sergei Shtylyov
2013-02-18 1:23 ` Simon Horman
2013-02-18 1:23 ` Simon Horman
2013-02-18 1:23 ` Simon Horman
2013-02-18 14:04 ` Sergei Shtylyov
2013-02-18 14:04 ` Sergei Shtylyov
2013-02-18 14:04 ` Sergei Shtylyov
2013-02-19 0:49 ` Simon Horman [this message]
2013-02-19 0:49 ` Simon Horman
2013-02-19 0:49 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219004947.GB14932@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.