All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings
@ 2013-02-19  9:49 Sachin Kamat
  2013-02-19 10:25 ` MyungJoo Ham
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-02-19  9:49 UTC (permalink / raw)
  To: lm-sensors

Fixes the following sparse warnings:
drivers/hwmon/ntc_thermistor.c:46:31: warning:
symbol 'ncpXXwb473' was not declared. Should it be static?
drivers/hwmon/ntc_thermistor.c:82:31: warning:
symbol 'ncpXXwl333' was not declared. Should it be static?

Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/hwmon/ntc_thermistor.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index a87eb89..b5f63f9 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -43,7 +43,7 @@ struct ntc_compensation {
  * The following compensation tables are from the specification of Murata NTC
  * Thermistors Datasheet
  */
-const struct ntc_compensation ncpXXwb473[] = {
+static const struct ntc_compensation ncpXXwb473[] = {
 	{ .temp_C	= -40, .ohm	= 1747920 },
 	{ .temp_C	= -35, .ohm	= 1245428 },
 	{ .temp_C	= -30, .ohm	= 898485 },
@@ -79,7 +79,7 @@ const struct ntc_compensation ncpXXwb473[] = {
 	{ .temp_C	= 120, .ohm	= 1615 },
 	{ .temp_C	= 125, .ohm	= 1406 },
 };
-const struct ntc_compensation ncpXXwl333[] = {
+static const struct ntc_compensation ncpXXwl333[] = {
 	{ .temp_C	= -40, .ohm	= 1610154 },
 	{ .temp_C	= -35, .ohm	= 1130850 },
 	{ .temp_C	= -30, .ohm	= 802609 },
-- 
1.7.4.1


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings
  2013-02-19  9:49 [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings Sachin Kamat
@ 2013-02-19 10:25 ` MyungJoo Ham
  2013-02-19 12:35 ` Jean Delvare
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: MyungJoo Ham @ 2013-02-19 10:25 UTC (permalink / raw)
  To: lm-sensors

> Fixes the following sparse warnings:
> drivers/hwmon/ntc_thermistor.c:46:31: warning:
> symbol 'ncpXXwb473' was not declared. Should it be static?
> drivers/hwmon/ntc_thermistor.c:82:31: warning:
> symbol 'ncpXXwl333' was not declared. Should it be static?
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/hwmon/ntc_thermistor.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index a87eb89..b5f63f9 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -43,7 +43,7 @@ struct ntc_compensation {
>   * The following compensation tables are from the specification of Murata NTC
>   * Thermistors Datasheet
>   */
> -const struct ntc_compensation ncpXXwb473[] = {
> +static const struct ntc_compensation ncpXXwb473[] = {
>  	{ .temp_C	= -40, .ohm	= 1747920 },
>  	{ .temp_C	= -35, .ohm	= 1245428 },
>  	{ .temp_C	= -30, .ohm	= 898485 },
> @@ -79,7 +79,7 @@ const struct ntc_compensation ncpXXwb473[] = {
>  	{ .temp_C	= 120, .ohm	= 1615 },
>  	{ .temp_C	= 125, .ohm	= 1406 },
>  };
> -const struct ntc_compensation ncpXXwl333[] = {
> +static const struct ntc_compensation ncpXXwl333[] = {
>  	{ .temp_C	= -40, .ohm	= 1610154 },
>  	{ .temp_C	= -35, .ohm	= 1130850 },
>  	{ .temp_C	= -30, .ohm	= 802609 },
> -- 
> 1.7.4.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings
  2013-02-19  9:49 [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings Sachin Kamat
  2013-02-19 10:25 ` MyungJoo Ham
@ 2013-02-19 12:35 ` Jean Delvare
  2013-02-19 16:45 ` Guenter Roeck
  2013-02-19 16:45 ` Guenter Roeck
  3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2013-02-19 12:35 UTC (permalink / raw)
  To: lm-sensors

On Tue, 19 Feb 2013 15:07:34 +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/hwmon/ntc_thermistor.c:46:31: warning:
> symbol 'ncpXXwb473' was not declared. Should it be static?
> drivers/hwmon/ntc_thermistor.c:82:31: warning:
> symbol 'ncpXXwl333' was not declared. Should it be static?
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Jean Delvare <khali@linux-fr.org>

Guenter, it happens that I have exactly 0 patches in my hwmon queue for
kernel 3.9. So I'll skip my turn on this one and let you handle all the
hwmon patches which should go in 3.9.

> ---
>  drivers/hwmon/ntc_thermistor.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index a87eb89..b5f63f9 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -43,7 +43,7 @@ struct ntc_compensation {
>   * The following compensation tables are from the specification of Murata NTC
>   * Thermistors Datasheet
>   */
> -const struct ntc_compensation ncpXXwb473[] = {
> +static const struct ntc_compensation ncpXXwb473[] = {
>  	{ .temp_C	= -40, .ohm	= 1747920 },
>  	{ .temp_C	= -35, .ohm	= 1245428 },
>  	{ .temp_C	= -30, .ohm	= 898485 },
> @@ -79,7 +79,7 @@ const struct ntc_compensation ncpXXwb473[] = {
>  	{ .temp_C	= 120, .ohm	= 1615 },
>  	{ .temp_C	= 125, .ohm	= 1406 },
>  };
> -const struct ntc_compensation ncpXXwl333[] = {
> +static const struct ntc_compensation ncpXXwl333[] = {
>  	{ .temp_C	= -40, .ohm	= 1610154 },
>  	{ .temp_C	= -35, .ohm	= 1130850 },
>  	{ .temp_C	= -30, .ohm	= 802609 },


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings
  2013-02-19  9:49 [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings Sachin Kamat
  2013-02-19 10:25 ` MyungJoo Ham
  2013-02-19 12:35 ` Jean Delvare
@ 2013-02-19 16:45 ` Guenter Roeck
  2013-02-19 16:45 ` Guenter Roeck
  3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2013-02-19 16:45 UTC (permalink / raw)
  To: lm-sensors

On Tue, Feb 19, 2013 at 01:35:52PM +0100, Jean Delvare wrote:
> On Tue, 19 Feb 2013 15:07:34 +0530, Sachin Kamat wrote:
> > Fixes the following sparse warnings:
> > drivers/hwmon/ntc_thermistor.c:46:31: warning:
> > symbol 'ncpXXwb473' was not declared. Should it be static?
> > drivers/hwmon/ntc_thermistor.c:82:31: warning:
> > symbol 'ncpXXwl333' was not declared. Should it be static?
> > 
> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> Guenter, it happens that I have exactly 0 patches in my hwmon queue for
> kernel 3.9. So I'll skip my turn on this one and let you handle all the
> hwmon patches which should go in 3.9.
> 
No problem.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings
  2013-02-19  9:49 [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings Sachin Kamat
                   ` (2 preceding siblings ...)
  2013-02-19 16:45 ` Guenter Roeck
@ 2013-02-19 16:45 ` Guenter Roeck
  3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2013-02-19 16:45 UTC (permalink / raw)
  To: lm-sensors

On Tue, Feb 19, 2013 at 03:07:34PM +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/hwmon/ntc_thermistor.c:46:31: warning:
> symbol 'ncpXXwb473' was not declared. Should it be static?
> drivers/hwmon/ntc_thermistor.c:82:31: warning:
> symbol 'ncpXXwl333' was not declared. Should it be static?
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-19 16:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-19  9:49 [lm-sensors] [PATCH 1/1] hwmon: (ntc_thermistor): Fix sparse warnings Sachin Kamat
2013-02-19 10:25 ` MyungJoo Ham
2013-02-19 12:35 ` Jean Delvare
2013-02-19 16:45 ` Guenter Roeck
2013-02-19 16:45 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.