* randconfig errors @ 2013-02-15 17:25 Rob Herring 2013-02-15 18:00 ` Arnd Bergmann ` (3 more replies) 0 siblings, 4 replies; 17+ messages in thread From: Rob Herring @ 2013-02-15 17:25 UTC (permalink / raw) To: linux-arm-kernel Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these. Rob /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:188:1: error: redefinition of 'is_omap54xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:189:1: error: redefinition of 'is_am33xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:191:1: error: redefinition of 'is_ti81xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:193:1: error: redefinition of 'is_omap242x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:194:1: error: redefinition of 'is_omap243x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:195:1: error: redefinition of 'is_omap343x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:196:1: error: redefinition of 'is_omap363x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:197:1: error: redefinition of 'is_omap443x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:198:1: error: redefinition of 'is_omap446x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:199:1: error: redefinition of 'is_omap447x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:200:1: error: redefinition of 'is_omap543x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:202:1: error: redefinition of 'is_ti816x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:203:1: error: redefinition of 'is_ti814x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:204:1: error: redefinition of 'is_am335x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:283:1: error: redefinition of 'is_omap2420' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:284:1: error: redefinition of 'is_omap2422' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:285:1: error: redefinition of 'is_omap2423' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:286:1: error: redefinition of 'is_omap2430' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:287:1: error: redefinition of 'is_omap3430' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:456:1: error: redefinition of 'omap3_has_l2cache' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:457:1: error: redefinition of 'omap3_has_sgx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:458:1: error: redefinition of 'omap3_has_iva' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:459:1: error: redefinition of 'omap3_has_neon' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:460:1: error: redefinition of 'omap3_has_isp' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:461:1: error: redefinition of 'omap3_has_192mhz_clk' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:462:1: error: redefinition of 'omap3_has_io_wakeup' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:463:1: error: redefinition of 'omap3_has_sdrc' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:464:1: error: redefinition of 'omap3_has_io_chain_ctrl' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:475:1: error: redefinition of 'omap4_has_perf_silicon' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/gpu/drm/drm_pci.c:485:2: error: implicit declaration of function 'pcie_capability_read_dword' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:21:5: error: redefinition of 'st_sensors_allocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:65:6: error: redefinition of 'st_sensors_deallocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:176:3: error: implicit declaration of function 'iio_push_to_buffers' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:106:36: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:109:21: error: variable 'inv_mpu_trigger_ops' has initializer but incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:110:2: error: unknown field 'owner' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:111:2: error: unknown field 'set_trigger_state' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:119:2: error: implicit declaration of function 'iio_trigger_alloc' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:126:38: error: 'iio_trigger_generic_data_rdy_poll' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:132:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:133:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:134:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:135:2: error: implicit declaration of function 'iio_trigger_register' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:145:2: error: implicit declaration of function 'iio_trigger_free' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:152:2: error: implicit declaration of function 'iio_trigger_unregister' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/industrialio-triggered-buffer.c:20:16: error: 'iio_sw_buffer_preenable' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/media/platform/davinci/vpss.c:28:27: fatal error: mach/hardware.h: No such file or directory /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/remoteproc/omap_remoteproc.c:31:26: fatal error: plat/mailbox.h: No such file or directory /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/omap-serial.c:1185:14: error: 'struct uart_port' has no member named 'sysrq' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/usb/host/uhci-hcd.c:857:2: error: #error "missing bus glue for uhci-hcd" /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/security/integrity/ima/ima_policy.c:538:4: error: implicit declaration of function 'part_pack_uuid' [-Werror=implicit-function-declaration] ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 17:25 randconfig errors Rob Herring @ 2013-02-15 18:00 ` Arnd Bergmann 2013-02-15 20:11 ` Mike Turquette 2013-02-15 18:22 ` Marc Zyngier ` (2 subsequent siblings) 3 siblings, 1 reply; 17+ messages in thread From: Arnd Bergmann @ 2013-02-15 18:00 UTC (permalink / raw) To: linux-arm-kernel On Friday 15 February 2013, Rob Herring wrote: > Errors from randconfig builds restricted to multi-platform configs on > the current linux-next. I know I've seen a fix on the first one from > Arnd, but have not investigated any of these. I have seen some of these before with the allyesconfig builds. Investigating randconfig is on my list for next week. > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx' Patch is queued in arm-soc now. > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) I've seen this one with allyesconfig but have not tried to make a fix > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] These are waiting for a patch from Matt Porter, "[PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()". Matt, what is your plan for this? I assume it's too late to get the entire series into 3.9, but you have Vinod's Ack on this one, and it should probably get merged early on because of the other subsystems that are not tracking their dependencies ;-) > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/gpu/drm/drm_pci.c:485:2: error: implicit declaration of function 'pcie_capability_read_dword' [-Werror=implicit-function-declaration] Should be fixed in today's -next. > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:21:5: error: redefinition of 'st_sensors_allocate_trigger' > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:65:6: error: redefinition of 'st_sensors_deallocate_trigger' > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:176:3: error: implicit declaration of function 'iio_push_to_buffers' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:106:36: error: dereferencing pointer to incomplete type > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:109:21: error: variable 'inv_mpu_trigger_ops' has initializer but incomplete type > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:110:2: error: unknown field 'owner' specified in initializer > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:111:2: error: unknown field 'set_trigger_state' specified in initializer > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:119:2: error: implicit declaration of function 'iio_trigger_alloc' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:126:38: error: 'iio_trigger_generic_data_rdy_poll' undeclared (first use in this function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:132:10: error: dereferencing pointer to incomplete type > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:133:10: error: dereferencing pointer to incomplete type > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:134:10: error: dereferencing pointer to incomplete type > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:135:2: error: implicit declaration of function 'iio_trigger_register' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:145:2: error: implicit declaration of function 'iio_trigger_free' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:152:2: error: implicit declaration of function 'iio_trigger_unregister' [-Werror=implicit-function-declaration] > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/industrialio-triggered-buffer.c:20:16: error: 'iio_sw_buffer_preenable' undeclared here (not in a function) I have not seen any of these so far. > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/media/platform/davinci/vpss.c:28:27: fatal error: mach/hardware.h: No such file or directory patch sent, waiting for Mauro > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/remoteproc/omap_remoteproc.c:31:26: fatal error: plat/mailbox.h: No such file or directory Fixed in arm-soc today > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>' > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/omap-serial.c:1185:14: error: 'struct uart_port' has no member named 'sysrq' Haven't seen these ones. > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/usb/host/uhci-hcd.c:857:2: error: #error "missing bus glue for uhci-hcd" I have a plan to fix this, but not patch. > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) This is already broken in v3.8-rc7 and earlier, I hope the fix makes it into 3.8. > /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) > /var/lib/jenkins/jobs/linux-randconfig/workspace/security/integrity/ima/ima_policy.c:538:4: error: implicit declaration of function 'part_pack_uuid' [-Werror=implicit-function-declaration] I have not seen these two. Thanks for the report. Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 18:00 ` Arnd Bergmann @ 2013-02-15 20:11 ` Mike Turquette 2013-02-15 20:28 ` Troy Kisky 0 siblings, 1 reply; 17+ messages in thread From: Mike Turquette @ 2013-02-15 20:11 UTC (permalink / raw) To: linux-arm-kernel Quoting Arnd Bergmann (2013-02-15 10:00:36) > On Friday 15 February 2013, Rob Herring wrote: > > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) > > I've seen this one with allyesconfig but have not tried to make a fix Looks like this one was introduced by 7248001, "clk: vt8500: Fix device clock divisor calculations". Looks like a copy/paste error where prate was used instead of parent_rate. Tony can you test the below patch? Regards, Mike >From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001 From: Mike Turquette <mturquette@linaro.org> Date: Fri, 15 Feb 2013 12:03:51 -0800 Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" introduced logic to improve divider selection while changing rates for the VT8500 dclk. However a copy-paste error results in using the wrong variable name in the .set_rate callback. Fixed by changing *prate to parent_rate. The .round_rate function is correct and remains unchanged. Signed-off-by: Mike Turquette <mturquette@linaro.org> Cc: Tony Prisk <linux@prisktech.co.nz> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Rob Herring <robherring2@gmail.com> --- drivers/clk/clk-vt8500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index b5538bb..c010861 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, divisor = parent_rate / rate; - /* If prate / rate would be decimal, incr the divisor */ - if (rate * divisor < *prate) + /* If parent_rate / rate would be decimal, incr the divisor */ + if (rate * divisor < parent_rate) divisor++; if (divisor == cdev->div_mask + 1) -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 20:11 ` Mike Turquette @ 2013-02-15 20:28 ` Troy Kisky 2013-02-22 9:29 ` Arnd Bergmann 0 siblings, 1 reply; 17+ messages in thread From: Troy Kisky @ 2013-02-15 20:28 UTC (permalink / raw) To: linux-arm-kernel On 2/15/2013 1:11 PM, Mike Turquette wrote: > Quoting Arnd Bergmann (2013-02-15 10:00:36) >> On Friday 15 February 2013, Rob Herring wrote: >>> /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) >> I've seen this one with allyesconfig but have not tried to make a fix > Looks like this one was introduced by 7248001, "clk: vt8500: Fix device > clock divisor calculations". > > Looks like a copy/paste error where prate was used instead of > parent_rate. > > Tony can you test the below patch? > > Regards, > Mike > > > >From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001 > From: Mike Turquette <mturquette@linaro.org> > Date: Fri, 15 Feb 2013 12:03:51 -0800 > Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate > > Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" > introduced logic to improve divider selection while changing rates for > the VT8500 dclk. However a copy-paste error results in using the wrong > variable name in the .set_rate callback. Fixed by changing *prate to > parent_rate. The .round_rate function is correct and remains unchanged. > > Signed-off-by: Mike Turquette <mturquette@linaro.org> > Cc: Tony Prisk <linux@prisktech.co.nz> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Rob Herring <robherring2@gmail.com> > --- > drivers/clk/clk-vt8500.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > index b5538bb..c010861 100644 > --- a/drivers/clk/clk-vt8500.c > +++ b/drivers/clk/clk-vt8500.c > @@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, > > divisor = parent_rate / rate; > > - /* If prate / rate would be decimal, incr the divisor */ > - if (rate * divisor < *prate) > + /* If parent_rate / rate would be decimal, incr the divisor */ > + if (rate * divisor < parent_rate) > divisor++; > > if (divisor == cdev->div_mask + 1) What about just divisor = (parent_rate + rate - 1) / rate; ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 20:28 ` Troy Kisky @ 2013-02-22 9:29 ` Arnd Bergmann 0 siblings, 0 replies; 17+ messages in thread From: Arnd Bergmann @ 2013-02-22 9:29 UTC (permalink / raw) To: linux-arm-kernel On Friday 15 February 2013, Troy Kisky wrote: > > Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" > > introduced logic to improve divider selection while changing rates for > > the VT8500 dclk. However a copy-paste error results in using the wrong > > variable name in the .set_rate callback. Fixed by changing *prate to > > parent_rate. The .round_rate function is correct and remains unchanged. > > > > Signed-off-by: Mike Turquette <mturquette@linaro.org> > > Cc: Tony Prisk <linux@prisktech.co.nz> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Rob Herring <robherring2@gmail.com> > > --- > > drivers/clk/clk-vt8500.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > > index b5538bb..c010861 100644 > > --- a/drivers/clk/clk-vt8500.c > > +++ b/drivers/clk/clk-vt8500.c > > @@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, > > > > divisor = parent_rate / rate; > > > > - /* If prate / rate would be decimal, incr the divisor */ > > - if (rate * divisor < *prate) > > + /* If parent_rate / rate would be decimal, incr the divisor */ > > + if (rate * divisor < parent_rate) > > divisor++; > > > > if (divisor == cdev->div_mask + 1) > What about just > > divisor = (parent_rate + rate - 1) / rate; > This is now broken in Linus' upstream tree. Could you get one fix merged? Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 17:25 randconfig errors Rob Herring 2013-02-15 18:00 ` Arnd Bergmann @ 2013-02-15 18:22 ` Marc Zyngier 2013-02-15 18:47 ` Marc Zyngier [not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com> 2013-02-21 10:38 ` Shawn Guo 3 siblings, 1 reply; 17+ messages in thread From: Marc Zyngier @ 2013-02-15 18:22 UTC (permalink / raw) To: linux-arm-kernel On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> wrote: > Errors from randconfig builds restricted to multi-platform configs on > the current linux-next. I know I've seen a fix on the first one from > Arnd, but have not investigated any of these. > > /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: > error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS). I'll queue a patch to fix the breakage... M. -- Fast, cheap, reliable. Pick two. ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 18:22 ` Marc Zyngier @ 2013-02-15 18:47 ` Marc Zyngier 2013-02-15 19:16 ` Christoffer Dall 0 siblings, 1 reply; 17+ messages in thread From: Marc Zyngier @ 2013-02-15 18:47 UTC (permalink / raw) To: linux-arm-kernel On Fri, 15 Feb 2013 19:22:37 +0100, Marc Zyngier <marc.zyngier@arm.com> wrote: > On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> > wrote: >> Errors from randconfig builds restricted to multi-platform configs on >> the current linux-next. I know I've seen a fix on the first one from >> Arnd, but have not investigated any of these. >> > >> > /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: >> error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) > > This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> > KVM_USER_MEM_SLOTS). > I'll queue a patch to fix the breakage... Looks like there's a few more, and what was brewing in kvm-next had some side effects. Christoffer, I'll send the patches separately. M. -- Fast, cheap, reliable. Pick two. ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 18:47 ` Marc Zyngier @ 2013-02-15 19:16 ` Christoffer Dall 2013-02-15 19:22 ` Marc Zyngier 0 siblings, 1 reply; 17+ messages in thread From: Christoffer Dall @ 2013-02-15 19:16 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 1:47 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: > On Fri, 15 Feb 2013 19:22:37 +0100, Marc Zyngier <marc.zyngier@arm.com> > wrote: >> On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> >> wrote: >>> Errors from randconfig builds restricted to multi-platform configs on >>> the current linux-next. I know I've seen a fix on the first one from >>> Arnd, but have not investigated any of these. >>> >> >>> >> > /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: >>> error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) >> >> This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> >> KVM_USER_MEM_SLOTS). >> I'll queue a patch to fix the breakage... > > Looks like there's a few more, and what was brewing in kvm-next had some > side effects. > > Christoffer, I'll send the patches separately. > I was kind of hoping that the KVM guys would have pulled the KVM/ARM stuff into kvm/next and it could have been fixed up there.... The patches are really trivial though iirc. ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 19:16 ` Christoffer Dall @ 2013-02-15 19:22 ` Marc Zyngier 2013-02-15 19:24 ` Christoffer Dall 0 siblings, 1 reply; 17+ messages in thread From: Marc Zyngier @ 2013-02-15 19:22 UTC (permalink / raw) To: linux-arm-kernel On 15/02/13 19:16, Christoffer Dall wrote: > On Fri, Feb 15, 2013 at 1:47 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: >> On Fri, 15 Feb 2013 19:22:37 +0100, Marc Zyngier <marc.zyngier@arm.com> >> wrote: >>> On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> >>> wrote: >>>> Errors from randconfig builds restricted to multi-platform configs on >>>> the current linux-next. I know I've seen a fix on the first one from >>>> Arnd, but have not investigated any of these. >>>> >>> >>>> >>> >> /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: >>>> error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) >>> >>> This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> >>> KVM_USER_MEM_SLOTS). >>> I'll queue a patch to fix the breakage... >> >> Looks like there's a few more, and what was brewing in kvm-next had some >> side effects. >> >> Christoffer, I'll send the patches separately. >> > I was kind of hoping that the KVM guys would have pulled the KVM/ARM > stuff into kvm/next and it could have been fixed up there.... The > patches are really trivial though iirc. Indeed they are. Probably an oversight from the KVM guys. Sent them anyway... M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: randconfig errors 2013-02-15 19:22 ` Marc Zyngier @ 2013-02-15 19:24 ` Christoffer Dall 0 siblings, 0 replies; 17+ messages in thread From: Christoffer Dall @ 2013-02-15 19:24 UTC (permalink / raw) To: Marc Zyngier; +Cc: Rob Herring, Arnd Bergmann, linux-arm-kernel, kvm On Fri, Feb 15, 2013 at 2:22 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: > On 15/02/13 19:16, Christoffer Dall wrote: >> On Fri, Feb 15, 2013 at 1:47 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: >>> On Fri, 15 Feb 2013 19:22:37 +0100, Marc Zyngier <marc.zyngier@arm.com> >>> wrote: >>>> On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> >>>> wrote: >>>>> Errors from randconfig builds restricted to multi-platform configs on >>>>> the current linux-next. I know I've seen a fix on the first one from >>>>> Arnd, but have not investigated any of these. >>>>> >>>> >>>>> >>>> >>> /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: >>>>> error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) >>>> >>>> This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> >>>> KVM_USER_MEM_SLOTS). >>>> I'll queue a patch to fix the breakage... >>> >>> Looks like there's a few more, and what was brewing in kvm-next had some >>> side effects. >>> >>> Christoffer, I'll send the patches separately. >>> >> I was kind of hoping that the KVM guys would have pulled the KVM/ARM >> stuff into kvm/next and it could have been fixed up there.... The >> patches are really trivial though iirc. > > Indeed they are. Probably an oversight from the KVM guys. Sent them > anyway... > I saw them, it all looks good. I'm cc'ing the kvm list here just for info. -Christoffer ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors @ 2013-02-15 19:24 ` Christoffer Dall 0 siblings, 0 replies; 17+ messages in thread From: Christoffer Dall @ 2013-02-15 19:24 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 2:22 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: > On 15/02/13 19:16, Christoffer Dall wrote: >> On Fri, Feb 15, 2013 at 1:47 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: >>> On Fri, 15 Feb 2013 19:22:37 +0100, Marc Zyngier <marc.zyngier@arm.com> >>> wrote: >>>> On Fri, 15 Feb 2013 11:25:56 -0600, Rob Herring <robherring2@gmail.com> >>>> wrote: >>>>> Errors from randconfig builds restricted to multi-platform configs on >>>>> the current linux-next. I know I've seen a fix on the first one from >>>>> Arnd, but have not investigated any of these. >>>>> >>>> >>>>> >>>> >>> /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: >>>>> error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) >>>> >>>> This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> >>>> KVM_USER_MEM_SLOTS). >>>> I'll queue a patch to fix the breakage... >>> >>> Looks like there's a few more, and what was brewing in kvm-next had some >>> side effects. >>> >>> Christoffer, I'll send the patches separately. >>> >> I was kind of hoping that the KVM guys would have pulled the KVM/ARM >> stuff into kvm/next and it could have been fixed up there.... The >> patches are really trivial though iirc. > > Indeed they are. Probably an oversight from the KVM guys. Sent them > anyway... > I saw them, it all looks good. I'm cc'ing the kvm list here just for info. -Christoffer ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com>]
* randconfig errors [not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com> @ 2013-02-15 19:45 ` Matt Porter 2013-02-15 20:12 ` Arnd Bergmann 0 siblings, 1 reply; 17+ messages in thread From: Matt Porter @ 2013-02-15 19:45 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 06:00:36PM +0000, Arnd Bergmann wrote: > On Friday 15 February 2013, Rob Herring wrote: > > Errors from randconfig builds restricted to multi-platform configs on > > the current linux-next. I know I've seen a fix on the first one from > > Arnd, but have not investigated any of these. > > I have seen some of these before with the allyesconfig builds. > Investigating randconfig is on my list for next week. > > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' > > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx' > > Patch is queued in arm-soc now. > > > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) > > I've seen this one with allyesconfig but have not tried to make a fix > > > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] > > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] > > These are waiting for a patch from Matt Porter, "[PATCH v7 07/10] dmaengine: add > dma_request_slave_channel_compat()". Matt, what is your plan for this? I assume > it's too late to get the entire series into 3.9, but you have Vinod's Ack on this > one, and it should probably get merged early on because of the other subsystems > that are not tracking their dependencies ;-) Yeah, probably too late for the dmaengine edma series. I need to update to fix the first patch bisect issues and the DT portions lack an ack from Rob or Grant. I'd be happy to see at least the compat() patch be picked up. Chris had to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm not sure whose tree that one should go through at this point...perhaps via Chris' tree now? -Matt ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 19:45 ` Matt Porter @ 2013-02-15 20:12 ` Arnd Bergmann 2013-02-15 20:25 ` Chris Ball 2013-02-20 6:36 ` Vinod Koul 0 siblings, 2 replies; 17+ messages in thread From: Arnd Bergmann @ 2013-02-15 20:12 UTC (permalink / raw) To: linux-arm-kernel On Friday 15 February 2013, Matt Porter wrote: > I'd be happy to see at least the compat() patch be picked up. Chris had > to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm > not sure whose tree that one should go through at this point...perhaps > via Chris' tree now? It really should have been in the crypto tree before Mark's patches to use them, but if Chris is still considering the the hsmmc dt patches for 3.9, including them there is probably the best way forward. I would expect him to say no them at this point though, and in that case, I think it should be either the slave-dma tree or the arm-soc tree. Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 20:12 ` Arnd Bergmann @ 2013-02-15 20:25 ` Chris Ball 2013-02-20 6:36 ` Vinod Koul 1 sibling, 0 replies; 17+ messages in thread From: Chris Ball @ 2013-02-15 20:25 UTC (permalink / raw) To: linux-arm-kernel Hi, On Fri, Feb 15 2013, Arnd Bergmann wrote: > I would expect him to say no them at this point though, and in that > case, I think it should be either the slave-dma tree or the arm-soc > tree. Agreed, these should go in someone else's tree, thanks. - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 20:12 ` Arnd Bergmann 2013-02-15 20:25 ` Chris Ball @ 2013-02-20 6:36 ` Vinod Koul 2013-02-20 9:53 ` Arnd Bergmann 1 sibling, 1 reply; 17+ messages in thread From: Vinod Koul @ 2013-02-20 6:36 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 08:12:03PM +0000, Arnd Bergmann wrote: > On Friday 15 February 2013, Matt Porter wrote: > > I'd be happy to see at least the compat() patch be picked up. Chris had > > to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm > > not sure whose tree that one should go through at this point...perhaps > > via Chris' tree now? > > It really should have been in the crypto tree before Mark's patches > to use them, but if Chris is still considering the the hsmmc dt > patches for 3.9, including them there is probably the best way forward. > > I would expect him to say no them at this point though, and in that > case, I think it should be either the slave-dma tree or the arm-soc > tree. Do you want me to add the compat() patch? I had acked it sometime back I was hoping to send the PULL request in a day or two... Pls let me know... -- ~Vinod ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-20 6:36 ` Vinod Koul @ 2013-02-20 9:53 ` Arnd Bergmann 0 siblings, 0 replies; 17+ messages in thread From: Arnd Bergmann @ 2013-02-20 9:53 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 20 February 2013, Vinod Koul wrote: > > It really should have been in the crypto tree before Mark's patches > > to use them, but if Chris is still considering the the hsmmc dt > > patches for 3.9, including them there is probably the best way forward. > > > > I would expect him to say no them at this point though, and in that > > case, I think it should be either the slave-dma tree or the arm-soc > > tree. > Do you want me to add the compat() patch? I had acked it sometime back > > I was hoping to send the PULL request in a day or two... Pls let me know... The patch is clearly needed in 3.9, so one of us should add it. It feels more appropriate for you to do it since it only touches the dma-slave header files. If you don't want to add more late patches to your branch, I can also put it into the arm-soc fixes queue, you decide. Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* randconfig errors 2013-02-15 17:25 randconfig errors Rob Herring ` (2 preceding siblings ...) [not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com> @ 2013-02-21 10:38 ` Shawn Guo 3 siblings, 0 replies; 17+ messages in thread From: Shawn Guo @ 2013-02-21 10:38 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 11:25:56AM -0600, Rob Herring wrote: > /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] Thanks, Rob. I will get it fixed. Shawn ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2013-02-22 9:29 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-02-15 17:25 randconfig errors Rob Herring 2013-02-15 18:00 ` Arnd Bergmann 2013-02-15 20:11 ` Mike Turquette 2013-02-15 20:28 ` Troy Kisky 2013-02-22 9:29 ` Arnd Bergmann 2013-02-15 18:22 ` Marc Zyngier 2013-02-15 18:47 ` Marc Zyngier 2013-02-15 19:16 ` Christoffer Dall 2013-02-15 19:22 ` Marc Zyngier 2013-02-15 19:24 ` Christoffer Dall 2013-02-15 19:24 ` Christoffer Dall [not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com> 2013-02-15 19:45 ` Matt Porter 2013-02-15 20:12 ` Arnd Bergmann 2013-02-15 20:25 ` Chris Ball 2013-02-20 6:36 ` Vinod Koul 2013-02-20 9:53 ` Arnd Bergmann 2013-02-21 10:38 ` Shawn Guo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.