[PATCH] staging: si3226x: TDM: add issues to TODO file

[PATCH] staging: si3226x: TDM: add issues to TODO file

[Kurachkin Michail]

Signed-off-by: Michail Kurachkin <michail.kurachkin@promwad.com>
---
 drivers/staging/si3226x/TODO |   20 +++++++++++++++++---
 drivers/staging/tdm/TODO     |   19 +++++++++++++++++++
 2 files changed, 36 insertions(+), 3 deletions(-)
 create mode 100644 drivers/staging/tdm/TODO

diff --git a/drivers/staging/si3226x/TODO b/drivers/staging/si3226x/TODO
index b2cb27e..e4c334a 100644
--- a/drivers/staging/si3226x/TODO
+++ b/drivers/staging/si3226x/TODO
@@ -1,8 +1,22 @@
+Mainteiners:
+Michail Kurachkin <Michail.Kurachkin@promwad.com> <stelhs@yandex.ru>
+Ivan Kuten <ivan.kuten@promwad.com>
+Promwad company <info@promwad.com>
+
+Reviwers:
+Oliver Neukum <oneukum@suse.de>
+Ryan Mallon <rmallon@gmail.com>
+Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+Needed to be done to get the code out of the staging tree:
 1) mutex_lock(&slic_chr_dev_lock);
 This locking is very heavy handed and should be reworked

-2) SLIC driver works unstable when compiled as module, loaded, then unloaded and finally reloaded again.
-
-3) Current version of Si3226x SLIC driver is limited. It implements only base functionality such as Answer, Hangup, receive DTMF, send DTMF, send Caller ID.
+2) SLIC driver works unstable when compiled as module,
+loaded, then unloaded and finally reloaded again.

+3) ensure stability of current driver, define several test scenarios

+4) Current version of Si3226x SLIC driver is limited. It implements
+only base functionality such as Answer, Hangup, receive DTMF,
+send DTMF, send Caller ID.
diff --git a/drivers/staging/tdm/TODO b/drivers/staging/tdm/TODO
new file mode 100644
index 0000000..585a617
--- /dev/null
+++ b/drivers/staging/tdm/TODO
@@ -0,0 +1,19 @@
+Mainteiners:
+Michail Kurachkin <Michail.Kurachkin@promwad.com> <stelhs@yandex.ru>
+Ivan Kuten <ivan.kuten@promwad.com>
+Promwad company <info@promwad.com>
+
+Reviwers:
+Oliver Neukum <oneukum@suse.de>
+Ryan Mallon <rmallon@gmail.com>
+Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+Needed to be done to get the code out of the staging tree:
+1) Marvell Kirkwood TDM driver works unstable when compiled as module,
+loaded, then unloaded and finally reloaded again.
+
+2) Add Documentation/tdm-bus.txt
+
+3) ensure stability of current driver, define several test scenarios
+
+4) look into Freescale TDM https://patchwork.kernel.org/patch/1249881/ , adopt Freescale bits into current TDM framework
--
1.7.5.4

Re: [PATCH] staging: si3226x: TDM: add issues to TODO file

[Greg Kroah-Hartman]

On Thu, Feb 28, 2013 at 04:30:52PM +0000, Kurachkin Michail wrote:
> Signed-off-by: Michail Kurachkin <michail.kurachkin@promwad.com>
> ---
>  drivers/staging/si3226x/TODO |   20 +++++++++++++++++---
>  drivers/staging/tdm/TODO     |   19 +++++++++++++++++++
>  2 files changed, 36 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/staging/tdm/TODO
> 
> diff --git a/drivers/staging/si3226x/TODO b/drivers/staging/si3226x/TODO
> index b2cb27e..e4c334a 100644
> --- a/drivers/staging/si3226x/TODO
> +++ b/drivers/staging/si3226x/TODO
> @@ -1,8 +1,22 @@
> +Mainteiners:
> +Michail Kurachkin <Michail.Kurachkin@promwad.com> <stelhs@yandex.ru>
> +Ivan Kuten <ivan.kuten@promwad.com>
> +Promwad company <info@promwad.com>
> +
> +Reviwers:
> +Oliver Neukum <oneukum@suse.de>
> +Ryan Mallon <rmallon@gmail.com>
> +Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Why are you listing reviewers?  We've never done that in a TODO file
before, please don't start.

And this should be two patches, one for each driver.

In fact, ideally it would be part of your original series.  As I really
don't want to hand-edit the Subject: of those patches, can you just fix
this up properly and resend all of them, based on the comments I've
provided so far?

thanks,

greg k-h