From: Herbert Xu <herbert@gondor.apana.org.au>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Adam Baker <linux@baker-net.org.uk>
Subject: Re: [Patch net] bridge: do not expire mdb entry when bridge still uses it
Date: Fri, 8 Mar 2013 10:31:51 +0800 [thread overview]
Message-ID: <20130308023151.GA27155@gondor.apana.org.au> (raw)
In-Reply-To: <1362708423-23932-1-git-send-email-amwang@redhat.com>
On Fri, Mar 08, 2013 at 10:07:03AM +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> This is a long-standing bug and reported several times:
> https://bugzilla.redhat.com/show_bug.cgi?id=880035
> http://marc.info/?l=linux-netdev&m=136164389416341&w=2
>
> This bug can be observed in virt environment, when a KVM guest
> communicates with the host via multicast. After some time (should
> be 260 sec, I didn't measure), the multicast traffic suddenly
> terminates.
>
> This is due to the mdb entry for bridge itself expires automatically,
> it should not expire as long as the bridge still generates multicast
> traffic. It should expire when the bridge leaves the multicast group,
> OR when there is no multicast traffic on this bridge.
>
> I fix this by adding another bool which is set when there is
> multicast traffic goes to the bridge, cleared in the expire timer and
> when IGMP leave is received. I ran omping for 15 minutes, everything
> looks good now.
I gather from the bugzilla entry that this happens where there is
no querier in the network.
So my question is why does this only affect the bridge port and
not other ports on the bridge?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Cong Wang <amwang@redhat.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
Adam Baker <linux@baker-net.org.uk>
Subject: Re: [Bridge] [Patch net] bridge: do not expire mdb entry when bridge still uses it
Date: Fri, 8 Mar 2013 10:31:51 +0800 [thread overview]
Message-ID: <20130308023151.GA27155@gondor.apana.org.au> (raw)
In-Reply-To: <1362708423-23932-1-git-send-email-amwang@redhat.com>
On Fri, Mar 08, 2013 at 10:07:03AM +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> This is a long-standing bug and reported several times:
> https://bugzilla.redhat.com/show_bug.cgi?id=880035
> http://marc.info/?l=linux-netdev&m=136164389416341&w=2
>
> This bug can be observed in virt environment, when a KVM guest
> communicates with the host via multicast. After some time (should
> be 260 sec, I didn't measure), the multicast traffic suddenly
> terminates.
>
> This is due to the mdb entry for bridge itself expires automatically,
> it should not expire as long as the bridge still generates multicast
> traffic. It should expire when the bridge leaves the multicast group,
> OR when there is no multicast traffic on this bridge.
>
> I fix this by adding another bool which is set when there is
> multicast traffic goes to the bridge, cleared in the expire timer and
> when IGMP leave is received. I ran omping for 15 minutes, everything
> looks good now.
I gather from the bugzilla entry that this happens where there is
no querier in the network.
So my question is why does this only affect the bridge port and
not other ports on the bridge?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2013-03-08 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 2:07 [Patch net] bridge: do not expire mdb entry when bridge still uses it Cong Wang
2013-03-08 2:07 ` [Bridge] " Cong Wang
2013-03-08 2:31 ` Herbert Xu [this message]
2013-03-08 2:31 ` Herbert Xu
2013-03-08 2:44 ` Cong Wang
2013-03-08 2:44 ` [Bridge] " Cong Wang
2013-03-08 2:47 ` Herbert Xu
2013-03-08 2:47 ` [Bridge] " Herbert Xu
2013-03-08 4:06 ` Cong Wang
2013-03-08 4:06 ` [Bridge] " Cong Wang
2013-03-08 4:08 ` Herbert Xu
2013-03-08 4:08 ` [Bridge] " Herbert Xu
2013-03-08 7:26 ` Cong Wang
2013-03-08 7:26 ` [Bridge] " Cong Wang
2013-03-08 11:24 ` Herbert Xu
2013-03-08 11:24 ` [Bridge] " Herbert Xu
2013-03-11 1:44 ` Cong Wang
2013-03-11 1:44 ` [Bridge] " Cong Wang
2013-03-19 1:12 ` Cong Wang
2013-03-19 1:12 ` [Bridge] " Cong Wang
2013-03-09 22:46 ` Adam Baker
2013-03-09 22:46 ` [Bridge] " Adam Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308023151.GA27155@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux@baker-net.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.