[PATCH] usb: phy: rename all phy drivers to phy-$name.c

[PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

this will make sure that we have sensible names
for all phy drivers. Current situation was already
quite bad with too generic names being used.

Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
 drivers/usb/phy/Makefile                           | 42 +++++++++++-----------
 drivers/usb/phy/{ab8500-usb.c => phy-ab8500.c}     |  0
 drivers/usb/phy/{fsl_otg.c => phy-fsl.c}           |  2 +-
 drivers/usb/phy/{fsl_otg.h => phy-fsl.h}           |  0
 drivers/usb/phy/{gpio_vbus.c => phy-gpio-vbus.c}   |  0
 .../usb/phy/{isp1301_omap.c => phy-isp1301-omap.c} |  0
 drivers/usb/phy/{isp1301.c => phy-isp1301.c}       |  0
 drivers/usb/phy/{msm_otg.c => phy-msm.c}           |  0
 drivers/usb/phy/{mv_u3d_phy.c => phy-mv-u3d.c}     |  2 +-
 drivers/usb/phy/{mv_u3d_phy.h => phy-mv-u3d.h}     |  0
 drivers/usb/phy/{mv_otg.c => phy-mv.c}             |  2 +-
 drivers/usb/phy/{mv_otg.h => phy-mv.h}             |  0
 drivers/usb/phy/{mxs-phy.c => phy-mxs.c}           |  0
 drivers/usb/phy/{nop-usb-xceiv.c => phy-nop.c}     |  0
 .../phy/{omap-control-usb.c => phy-omap-control.c} |  0
 drivers/usb/phy/{omap-usb2.c => phy-omap-usb2.c}   |  0
 drivers/usb/phy/{omap-usb3.c => phy-omap-usb3.c}   |  0
 drivers/usb/phy/{otg_fsm.c => phy-otg-fsm.c}       |  2 +-
 drivers/usb/phy/{otg_fsm.h => phy-otg-fsm.h}       |  0
 drivers/usb/phy/{rcar-phy.c => phy-rcar.c}         |  0
 .../usb/phy/{samsung-usbphy.c => phy-samsung.c}    |  0
 drivers/usb/phy/{tegra_usb_phy.c => phy-tegra.c}   |  0
 drivers/usb/phy/{twl4030-usb.c => phy-twl4030.c}   |  0
 drivers/usb/phy/{twl6030-usb.c => phy-twl6030.c}   |  0
 .../phy/{ulpi_viewport.c => phy-ulpi-viewport.c}   |  0
 drivers/usb/phy/{ulpi.c => phy-ulpi.c}             |  0
 26 files changed, 25 insertions(+), 25 deletions(-)
 rename drivers/usb/phy/{ab8500-usb.c => phy-ab8500.c} (100%)
 rename drivers/usb/phy/{fsl_otg.c => phy-fsl.c} (99%)
 rename drivers/usb/phy/{fsl_otg.h => phy-fsl.h} (100%)
 rename drivers/usb/phy/{gpio_vbus.c => phy-gpio-vbus.c} (100%)
 rename drivers/usb/phy/{isp1301_omap.c => phy-isp1301-omap.c} (100%)
 rename drivers/usb/phy/{isp1301.c => phy-isp1301.c} (100%)
 rename drivers/usb/phy/{msm_otg.c => phy-msm.c} (100%)
 rename drivers/usb/phy/{mv_u3d_phy.c => phy-mv-u3d.c} (99%)
 rename drivers/usb/phy/{mv_u3d_phy.h => phy-mv-u3d.h} (100%)
 rename drivers/usb/phy/{mv_otg.c => phy-mv.c} (99%)
 rename drivers/usb/phy/{mv_otg.h => phy-mv.h} (100%)
 rename drivers/usb/phy/{mxs-phy.c => phy-mxs.c} (100%)
 rename drivers/usb/phy/{nop-usb-xceiv.c => phy-nop.c} (100%)
 rename drivers/usb/phy/{omap-control-usb.c => phy-omap-control.c} (100%)
 rename drivers/usb/phy/{omap-usb2.c => phy-omap-usb2.c} (100%)
 rename drivers/usb/phy/{omap-usb3.c => phy-omap-usb3.c} (100%)
 rename drivers/usb/phy/{otg_fsm.c => phy-otg-fsm.c} (99%)
 rename drivers/usb/phy/{otg_fsm.h => phy-otg-fsm.h} (100%)
 rename drivers/usb/phy/{rcar-phy.c => phy-rcar.c} (100%)
 rename drivers/usb/phy/{samsung-usbphy.c => phy-samsung.c} (100%)
 rename drivers/usb/phy/{tegra_usb_phy.c => phy-tegra.c} (100%)
 rename drivers/usb/phy/{twl4030-usb.c => phy-twl4030.c} (100%)
 rename drivers/usb/phy/{twl6030-usb.c => phy-twl6030.c} (100%)
 rename drivers/usb/phy/{ulpi_viewport.c => phy-ulpi-viewport.c} (100%)
 rename drivers/usb/phy/{ulpi.c => phy-ulpi.c} (100%)

diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
index d10a8b3..32db575 100644
--- a/drivers/usb/phy/Makefile
+++ b/drivers/usb/phy/Makefile
@@ -8,24 +8,24 @@ obj-$(CONFIG_USB_PHY)			+= phy.o
 
 # transceiver drivers, keep the list sorted
 
-obj-$(CONFIG_AB8500_USB)		+= ab8500-usb.o
-fsl_usb2_otg-objs			:= fsl_otg.o otg_fsm.o
-obj-$(CONFIG_FSL_USB2_OTG)		+= fsl_usb2_otg.o
-obj-$(CONFIG_ISP1301_OMAP)		+= isp1301_omap.o
-obj-$(CONFIG_MV_U3D_PHY)		+= mv_u3d_phy.o
-obj-$(CONFIG_NOP_USB_XCEIV)		+= nop-usb-xceiv.o
-obj-$(CONFIG_OMAP_CONTROL_USB)		+= omap-control-usb.o
-obj-$(CONFIG_OMAP_USB2)			+= omap-usb2.o
-obj-$(CONFIG_OMAP_USB3)			+= omap-usb3.o
-obj-$(CONFIG_SAMSUNG_USBPHY)		+= samsung-usbphy.o
-obj-$(CONFIG_TWL4030_USB)		+= twl4030-usb.o
-obj-$(CONFIG_TWL6030_USB)		+= twl6030-usb.o
-obj-$(CONFIG_USB_EHCI_TEGRA)		+= tegra_usb_phy.o
-obj-$(CONFIG_USB_GPIO_VBUS)		+= gpio_vbus.o
-obj-$(CONFIG_USB_ISP1301)		+= isp1301.o
-obj-$(CONFIG_USB_MSM_OTG)		+= msm_otg.o
-obj-$(CONFIG_USB_MV_OTG)		+= mv_otg.o
-obj-$(CONFIG_USB_MXS_PHY)		+= mxs-phy.o
-obj-$(CONFIG_USB_RCAR_PHY)		+= rcar-phy.o
-obj-$(CONFIG_USB_ULPI)			+= ulpi.o
-obj-$(CONFIG_USB_ULPI_VIEWPORT)		+= ulpi_viewport.o
+obj-$(CONFIG_AB8500_USB)		+= phy-ab8500.o
+phy-fsl-usb2-objs			:= phy-fsl.o phy-otg-fsm.o
+obj-$(CONFIG_FSL_USB2_OTG)		+= phy-fsl-usb2.o
+obj-$(CONFIG_ISP1301_OMAP)		+= phy-isp1301.omap.o
+obj-$(CONFIG_MV_U3D_PHY)		+= phy-mv-u3d.o
+obj-$(CONFIG_NOP_USB_XCEIV)		+= phy-nop.o
+obj-$(CONFIG_OMAP_CONTROL_USB)		+= phy-omap-control.o
+obj-$(CONFIG_OMAP_USB2)			+= phy-omap-usb2.o
+obj-$(CONFIG_OMAP_USB3)			+= phy-omap-usb3.o
+obj-$(CONFIG_SAMSUNG_USBPHY)		+= phy-samsung.o
+obj-$(CONFIG_TWL4030_USB)		+= phy-twl4030.o
+obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030.o
+obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra.o
+obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus.o
+obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
+obj-$(CONFIG_USB_MSM_OTG)		+= phy-msm.o
+obj-$(CONFIG_USB_MV_OTG)		+= phy-mv.o
+obj-$(CONFIG_USB_MXS_PHY)		+= phy-mxs.o
+obj-$(CONFIG_USB_RCAR_PHY)		+= phy-rcar.o
+obj-$(CONFIG_USB_ULPI)			+= phy-ulpi.o
+obj-$(CONFIG_USB_ULPI_VIEWPORT)		+= phy-ulpi-viewport.o
diff --git a/drivers/usb/phy/ab8500-usb.c b/drivers/usb/phy/phy-ab8500.c
similarity index 100%
rename from drivers/usb/phy/ab8500-usb.c
rename to drivers/usb/phy/phy-ab8500.c
diff --git a/drivers/usb/phy/fsl_otg.c b/drivers/usb/phy/phy-fsl.c
similarity index 99%
rename from drivers/usb/phy/fsl_otg.c
rename to drivers/usb/phy/phy-fsl.c
index 72a2a00..bca345b 100644
--- a/drivers/usb/phy/fsl_otg.c
+++ b/drivers/usb/phy/phy-fsl.c
@@ -43,7 +43,7 @@
 
 #include <asm/unaligned.h>
 
-#include "fsl_otg.h"
+#include "phy-fsl.h"
 
 #define DRIVER_VERSION "Rev. 1.55"
 #define DRIVER_AUTHOR "Jerry Huang/Li Yang"
diff --git a/drivers/usb/phy/fsl_otg.h b/drivers/usb/phy/phy-fsl.h
similarity index 100%
rename from drivers/usb/phy/fsl_otg.h
rename to drivers/usb/phy/phy-fsl.h
diff --git a/drivers/usb/phy/gpio_vbus.c b/drivers/usb/phy/phy-gpio-vbus.c
similarity index 100%
rename from drivers/usb/phy/gpio_vbus.c
rename to drivers/usb/phy/phy-gpio-vbus.c
diff --git a/drivers/usb/phy/isp1301_omap.c b/drivers/usb/phy/phy-isp1301-omap.c
similarity index 100%
rename from drivers/usb/phy/isp1301_omap.c
rename to drivers/usb/phy/phy-isp1301-omap.c
diff --git a/drivers/usb/phy/isp1301.c b/drivers/usb/phy/phy-isp1301.c
similarity index 100%
rename from drivers/usb/phy/isp1301.c
rename to drivers/usb/phy/phy-isp1301.c
diff --git a/drivers/usb/phy/msm_otg.c b/drivers/usb/phy/phy-msm.c
similarity index 100%
rename from drivers/usb/phy/msm_otg.c
rename to drivers/usb/phy/phy-msm.c
diff --git a/drivers/usb/phy/mv_u3d_phy.c b/drivers/usb/phy/phy-mv-u3d.c
similarity index 99%
rename from drivers/usb/phy/mv_u3d_phy.c
rename to drivers/usb/phy/phy-mv-u3d.c
index 9d85991..f94e441 100644
--- a/drivers/usb/phy/mv_u3d_phy.c
+++ b/drivers/usb/phy/phy-mv-u3d.c
@@ -15,7 +15,7 @@
 #include <linux/usb/otg.h>
 #include <linux/platform_data/mv_usb.h>
 
-#include "mv_u3d_phy.h"
+#include "phy-mv-u3d.h"
 
 /*
  * struct mv_u3d_phy - transceiver driver state
diff --git a/drivers/usb/phy/mv_u3d_phy.h b/drivers/usb/phy/phy-mv-u3d.h
similarity index 100%
rename from drivers/usb/phy/mv_u3d_phy.h
rename to drivers/usb/phy/phy-mv-u3d.h
diff --git a/drivers/usb/phy/mv_otg.c b/drivers/usb/phy/phy-mv.c
similarity index 99%
rename from drivers/usb/phy/mv_otg.c
rename to drivers/usb/phy/phy-mv.c
index b6a9be3..043fdd2 100644
--- a/drivers/usb/phy/mv_otg.c
+++ b/drivers/usb/phy/phy-mv.c
@@ -27,7 +27,7 @@
 #include <linux/usb/hcd.h>
 #include <linux/platform_data/mv_usb.h>
 
-#include "mv_otg.h"
+#include "phy-mv.h"
 
 #define	DRIVER_DESC	"Marvell USB OTG transceiver driver"
 #define	DRIVER_VERSION	"Jan 20, 2010"
diff --git a/drivers/usb/phy/mv_otg.h b/drivers/usb/phy/phy-mv.h
similarity index 100%
rename from drivers/usb/phy/mv_otg.h
rename to drivers/usb/phy/phy-mv.h
diff --git a/drivers/usb/phy/mxs-phy.c b/drivers/usb/phy/phy-mxs.c
similarity index 100%
rename from drivers/usb/phy/mxs-phy.c
rename to drivers/usb/phy/phy-mxs.c
diff --git a/drivers/usb/phy/nop-usb-xceiv.c b/drivers/usb/phy/phy-nop.c
similarity index 100%
rename from drivers/usb/phy/nop-usb-xceiv.c
rename to drivers/usb/phy/phy-nop.c
diff --git a/drivers/usb/phy/omap-control-usb.c b/drivers/usb/phy/phy-omap-control.c
similarity index 100%
rename from drivers/usb/phy/omap-control-usb.c
rename to drivers/usb/phy/phy-omap-control.c
diff --git a/drivers/usb/phy/omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c
similarity index 100%
rename from drivers/usb/phy/omap-usb2.c
rename to drivers/usb/phy/phy-omap-usb2.c
diff --git a/drivers/usb/phy/omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c
similarity index 100%
rename from drivers/usb/phy/omap-usb3.c
rename to drivers/usb/phy/phy-omap-usb3.c
diff --git a/drivers/usb/phy/otg_fsm.c b/drivers/usb/phy/phy-otg-fsm.c
similarity index 99%
rename from drivers/usb/phy/otg_fsm.c
rename to drivers/usb/phy/phy-otg-fsm.c
index 1f729a1..c520b35 100644
--- a/drivers/usb/phy/otg_fsm.c
+++ b/drivers/usb/phy/phy-otg-fsm.c
@@ -29,7 +29,7 @@
 #include <linux/usb/gadget.h>
 #include <linux/usb/otg.h>
 
-#include "otg_fsm.h"
+#include "phy-otg-fsm.h"
 
 /* Change USB protocol when there is a protocol change */
 static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
diff --git a/drivers/usb/phy/otg_fsm.h b/drivers/usb/phy/phy-otg-fsm.h
similarity index 100%
rename from drivers/usb/phy/otg_fsm.h
rename to drivers/usb/phy/phy-otg-fsm.h
diff --git a/drivers/usb/phy/rcar-phy.c b/drivers/usb/phy/phy-rcar.c
similarity index 100%
rename from drivers/usb/phy/rcar-phy.c
rename to drivers/usb/phy/phy-rcar.c
diff --git a/drivers/usb/phy/samsung-usbphy.c b/drivers/usb/phy/phy-samsung.c
similarity index 100%
rename from drivers/usb/phy/samsung-usbphy.c
rename to drivers/usb/phy/phy-samsung.c
diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/phy-tegra.c
similarity index 100%
rename from drivers/usb/phy/tegra_usb_phy.c
rename to drivers/usb/phy/phy-tegra.c
diff --git a/drivers/usb/phy/twl4030-usb.c b/drivers/usb/phy/phy-twl4030.c
similarity index 100%
rename from drivers/usb/phy/twl4030-usb.c
rename to drivers/usb/phy/phy-twl4030.c
diff --git a/drivers/usb/phy/twl6030-usb.c b/drivers/usb/phy/phy-twl6030.c
similarity index 100%
rename from drivers/usb/phy/twl6030-usb.c
rename to drivers/usb/phy/phy-twl6030.c
diff --git a/drivers/usb/phy/ulpi_viewport.c b/drivers/usb/phy/phy-ulpi-viewport.c
similarity index 100%
rename from drivers/usb/phy/ulpi_viewport.c
rename to drivers/usb/phy/phy-ulpi-viewport.c
diff --git a/drivers/usb/phy/ulpi.c b/drivers/usb/phy/phy-ulpi.c
similarity index 100%
rename from drivers/usb/phy/ulpi.c
rename to drivers/usb/phy/phy-ulpi.c
-- 
1.8.1.rc1.5.g7e0651a

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

On Thu, Mar 07, 2013 at 05:45:26PM +0200, Felipe Balbi wrote:
> this will make sure that we have sensible names
> for all phy drivers. Current situation was already
> quite bad with too generic names being used.
> 
> Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>

Hi, I compiled what I could with allmodconfig and allyesconfig. Make
sure to test on your own platform.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> this will make sure that we have sensible names
> for all phy drivers. Current situation was already
> quite bad with too generic names being used.

Is phy-$name specific enough? There are other types of PHY such as
Ethernet, etc. What about phy-usb-$name?

Venu, please comment on what conflicts, if any, this will cause with the
patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote:
> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> > this will make sure that we have sensible names
> > for all phy drivers. Current situation was already
> > quite bad with too generic names being used.
> 
> Is phy-$name specific enough? There are other types of PHY such as
> Ethernet, etc. What about phy-usb-$name?

we will be creating a generic (kernel-wide) phy layer, so I guess that
matters very little. Specially since we don't want to be differentiating
PHYs by their subsystem and rather by the IP name (which means
phy-tegra, phy-samsung, phy-omap, are all 'wrong', but there were no
better names).

> Venu, please comment on what conflicts, if any, this will cause with the
> patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.

BTW, let's stop with the whole dependency between PHY driver cleanup and
arch/arm/mach-tegra/, too many patches have gone upstream bypassing my
tree. What we should be doing is figuring out how to remove arch/
dependencies so that patches can go upstream and not cause conflicts.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Venu Byravarasu]

> -----Original Message-----
> From: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-tegra-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Stephen Warren
> Sent: Friday, March 08, 2013 2:07 AM
> To: Felipe Balbi; Venu Byravarasu
> Cc: Linux USB Mailing List; Greg KH; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
> gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org;
> p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org;
> yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> 
> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> > this will make sure that we have sensible names
> > for all phy drivers. Current situation was already
> > quite bad with too generic names being used.
> 
> Is phy-$name specific enough? There are other types of PHY such as
> Ethernet, etc. What about phy-usb-$name?
> 
> Venu, please comment on what conflicts, if any, this will cause with the
> patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.

As this is just a name change, it should not cause any big issues, other than porting
all changes on top of this new file.  

Felipe,
When can we expect these changes getting merged into linux-next?

> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

On Fri, Mar 08, 2013 at 12:51:13PM +0530, Venu Byravarasu wrote:
> > -----Original Message-----
> > From: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-tegra-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Stephen Warren
> > Sent: Friday, March 08, 2013 2:07 AM
> > To: Felipe Balbi; Venu Byravarasu
> > Cc: Linux USB Mailing List; Greg KH; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
> > gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org;
> > p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org;
> > yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> > Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> > 
> > On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> > > this will make sure that we have sensible names
> > > for all phy drivers. Current situation was already
> > > quite bad with too generic names being used.
> > 
> > Is phy-$name specific enough? There are other types of PHY such as
> > Ethernet, etc. What about phy-usb-$name?
> > 
> > Venu, please comment on what conflicts, if any, this will cause with the
> > patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.
> 
> As this is just a name change, it should not cause any big issues, other than porting
> all changes on top of this new file.  
> 
> Felipe,
> When can we expect these changes getting merged into linux-next?

After -rc2 is tagged, I will have everything I need to start my -next
branch. From that point on it should be in linux-next ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote:
>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
>>> this will make sure that we have sensible names for all phy
>>> drivers. Current situation was already quite bad with too
>>> generic names being used.
>> 
>> Is phy-$name specific enough? There are other types of PHY such
>> as Ethernet, etc. What about phy-usb-$name?
> 
> we will be creating a generic (kernel-wide) phy layer, so I guess
> that matters very little. Specially since we don't want to be
> differentiating PHYs by their subsystem and rather by the IP name
> (which means phy-tegra, phy-samsung, phy-omap, are all 'wrong', but
> there were no better names).
> 
>> Venu, please comment on what conflicts, if any, this will cause
>> with the patches you'll be sending to clean up the Tegra USB/PHY
>> drivers. Thanks.
> 
> BTW, let's stop with the whole dependency between PHY driver
> cleanup and arch/arm/mach-tegra/, too many patches have gone
> upstream bypassing my tree. What we should be doing is figuring out
> how to remove arch/ dependencies so that patches can go upstream
> and not cause conflicts.

Unfortunately, there's no way to actually avoid the dependencies
themselves. The DT bindings and EHCI/PHY controller split are wrong,
and need work on both the DT and drivers to fix.

I guess I could apply all the initial DT changes to a topic branch in
the Tegra tree (item 1 below), and have you merge that branch into
yours, and then you could take all the USB-related patches (item 2
below) through your tree. Would that work better?

The only issue with that is that we would have to defer the final DT
cleanup patch until sometime after 3.10-rc1; in order to maintain
bisectability, the order needs to be: (1) add new DT content required
by fixed binding (2) make driver assume new binding (3) remove stale
DT content no longer required by the new binding. (3) is what would
have to be deferred.

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote:
>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
>>> this will make sure that we have sensible names for all phy
>>> drivers. Current situation was already quite bad with too
>>> generic names being used.
>> 
>> Is phy-$name specific enough? There are other types of PHY such
>> as Ethernet, etc. What about phy-usb-$name?
> 
> we will be creating a generic (kernel-wide) phy layer, so I guess
> that matters very little. Specially since we don't want to be
> differentiating PHYs by their subsystem and rather by the IP name
> (which means phy-tegra, phy-samsung, phy-omap, are all 'wrong', but
> there were no better names).

On other thought here: The Tegra PHY in question here very
specifically is a USB PHY. There's no way it could be used as e.g. a
SATA PHY, either as a HW block or given the driver code that program
is. Is sharing a PHY IP block or driver ever possible for any HW?

Hence, I don't think removing "USB" from the filename makes sense, nor
even moving it into a generic PHY directory.

By the same logic, any code for Tegra30's SATA PHY should also be in
phy-tegra.c, but that name would conflict. Naming them phy-tegra-usb.c
and phy-tegra-sata.c, or something specific like that, would avoid any
issue. And actually, better phy-tegra20-usb.c since Tegra114 has some
XHCI support, and I have no idea if the PHY code for that will end up
being at all related to the existing Tegra20 code, so we might need a
separate phy-tegra114-usb.c down the road.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2068 bytes --]

Hi,

On Fri, Mar 08, 2013 at 10:26:45AM -0700, Stephen Warren wrote:
> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> > On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote:
> >> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>> this will make sure that we have sensible names for all phy
> >>> drivers. Current situation was already quite bad with too
> >>> generic names being used.
> >> 
> >> Is phy-$name specific enough? There are other types of PHY such
> >> as Ethernet, etc. What about phy-usb-$name?
> > 
> > we will be creating a generic (kernel-wide) phy layer, so I guess
> > that matters very little. Specially since we don't want to be
> > differentiating PHYs by their subsystem and rather by the IP name
> > (which means phy-tegra, phy-samsung, phy-omap, are all 'wrong', but
> > there were no better names).
> > 
> >> Venu, please comment on what conflicts, if any, this will cause
> >> with the patches you'll be sending to clean up the Tegra USB/PHY
> >> drivers. Thanks.
> > 
> > BTW, let's stop with the whole dependency between PHY driver
> > cleanup and arch/arm/mach-tegra/, too many patches have gone
> > upstream bypassing my tree. What we should be doing is figuring out
> > how to remove arch/ dependencies so that patches can go upstream
> > and not cause conflicts.
> 
> Unfortunately, there's no way to actually avoid the dependencies
> themselves. The DT bindings and EHCI/PHY controller split are wrong,
> and need work on both the DT and drivers to fix.

but those changes don't need to come together, right ? I mean, for the
DT part you could add the bindings to driver A without removing from
driver B and span the changes accross 2 merge windows.

> I guess I could apply all the initial DT changes to a topic branch in
> the Tegra tree (item 1 below), and have you merge that branch into
> yours, and then you could take all the USB-related patches (item 2
> below) through your tree. Would that work better?

I'm not merging, taking everything as patches, sorry.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

Hi,

On Fri, Mar 08, 2013 at 11:33:48AM -0700, Stephen Warren wrote:
> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> > On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote:
> >> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>> this will make sure that we have sensible names for all phy
> >>> drivers. Current situation was already quite bad with too
> >>> generic names being used.
> >> 
> >> Is phy-$name specific enough? There are other types of PHY such
> >> as Ethernet, etc. What about phy-usb-$name?
> > 
> > we will be creating a generic (kernel-wide) phy layer, so I guess
> > that matters very little. Specially since we don't want to be
> > differentiating PHYs by their subsystem and rather by the IP name
> > (which means phy-tegra, phy-samsung, phy-omap, are all 'wrong', but
> > there were no better names).
> 
> On other thought here: The Tegra PHY in question here very
> specifically is a USB PHY. There's no way it could be used as e.g. a
> SATA PHY, either as a HW block or given the driver code that program
> is. Is sharing a PHY IP block or driver ever possible for any HW?

yes it is possible, and OMAP5 shares the same IP for USB3 and SATA. PHYs
don't know about USB, SATA, Ethernet and whatnot. PHYs know solely about
the physical layer. Their work is just to generate the proper electrical
signals.

> Hence, I don't think removing "USB" from the filename makes sense, nor
> even moving it into a generic PHY directory.

fair enough, I have now renamed tegra to phy-tegra-usb.c

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/11/2013 12:59 AM, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Mar 08, 2013 at 10:26:45AM -0700, Stephen Warren wrote:
>> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
>>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren
>>> wrote:
>>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
>>>>> this will make sure that we have sensible names for all
>>>>> phy drivers. Current situation was already quite bad with
>>>>> too generic names being used.
>>>> 
>>>> Is phy-$name specific enough? There are other types of PHY
>>>> such as Ethernet, etc. What about phy-usb-$name?
>>> 
>>> we will be creating a generic (kernel-wide) phy layer, so I
>>> guess that matters very little. Specially since we don't want
>>> to be differentiating PHYs by their subsystem and rather by the
>>> IP name (which means phy-tegra, phy-samsung, phy-omap, are all
>>> 'wrong', but there were no better names).
>>> 
>>>> Venu, please comment on what conflicts, if any, this will
>>>> cause with the patches you'll be sending to clean up the
>>>> Tegra USB/PHY drivers. Thanks.
>>> 
>>> BTW, let's stop with the whole dependency between PHY driver 
>>> cleanup and arch/arm/mach-tegra/, too many patches have gone 
>>> upstream bypassing my tree. What we should be doing is figuring
>>> out how to remove arch/ dependencies so that patches can go
>>> upstream and not cause conflicts.
>> 
>> Unfortunately, there's no way to actually avoid the dependencies 
>> themselves. The DT bindings and EHCI/PHY controller split are
>> wrong, and need work on both the DT and drivers to fix.
> 
> but those changes don't need to come together, right ? I mean, for
> the DT part you could add the bindings to driver A without removing
> from driver B and span the changes accross 2 merge windows.

There is only a single driver. It's being reworked to support the new
binding.

>> I guess I could apply all the initial DT changes to a topic
>> branch in the Tegra tree (item 1 below), and have you merge that
>> branch into yours, and then you could take all the USB-related
>> patches (item 2 below) through your tree. Would that work
>> better?
> 
> I'm not merging, taking everything as patches, sorry.

In that case, the Tegra USB driver changes have to go through the
Tegra tree this kernel cycle. The only way to avoid this, as you said
above, would be to break the patches into n kernel cycles, which will
introduce another 2-3 months delay, and I really don't see any point
at all in doing that just to avoid a git pull, or taking the patches
through the Tegra tree.

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/11/2013 01:01 AM, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Mar 08, 2013 at 11:33:48AM -0700, Stephen Warren wrote:
>> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
>>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren
>>> wrote:
>>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
>>>>> this will make sure that we have sensible names for all
>>>>> phy drivers. Current situation was already quite bad with
>>>>> too generic names being used.
>>>> 
>>>> Is phy-$name specific enough? There are other types of PHY
>>>> such as Ethernet, etc. What about phy-usb-$name?
>>> 
>>> we will be creating a generic (kernel-wide) phy layer, so I
>>> guess that matters very little. Specially since we don't want
>>> to be differentiating PHYs by their subsystem and rather by the
>>> IP name (which means phy-tegra, phy-samsung, phy-omap, are all
>>> 'wrong', but there were no better names).
>> 
>> On other thought here: The Tegra PHY in question here very 
>> specifically is a USB PHY. There's no way it could be used as
>> e.g. a SATA PHY, either as a HW block or given the driver code
>> that program is. Is sharing a PHY IP block or driver ever
>> possible for any HW?
> 
> yes it is possible, and OMAP5 shares the same IP for USB3 and SATA.
> PHYs don't know about USB, SATA, Ethernet and whatnot. PHYs know
> solely about the physical layer. Their work is just to generate the
> proper electrical signals.

Hmm. Is the current code in drivers/usb/phy/tegra_usb_phy.c not really
a PHY driver, then? Tegra's USB PHY HW module definitely does know
that it's specifically a USB PHY. It has direct knowledge of
UTMI/ULPI/... Instead, should the code be part of the EHCI driver,
since the concept of a PHY known to drivers/usb/phy doesn't seem
related to what the Tegra PHY HW actually is?

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2222 bytes --]

Hi,

On Mon, Mar 11, 2013 at 11:05:15AM -0600, Stephen Warren wrote:
> >> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> >>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren
> >>> wrote:
> >>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>>>> this will make sure that we have sensible names for all
> >>>>> phy drivers. Current situation was already quite bad with
> >>>>> too generic names being used.
> >>>> 
> >>>> Is phy-$name specific enough? There are other types of PHY
> >>>> such as Ethernet, etc. What about phy-usb-$name?
> >>> 
> >>> we will be creating a generic (kernel-wide) phy layer, so I
> >>> guess that matters very little. Specially since we don't want
> >>> to be differentiating PHYs by their subsystem and rather by the
> >>> IP name (which means phy-tegra, phy-samsung, phy-omap, are all
> >>> 'wrong', but there were no better names).
> >> 
> >> On other thought here: The Tegra PHY in question here very 
> >> specifically is a USB PHY. There's no way it could be used as
> >> e.g. a SATA PHY, either as a HW block or given the driver code
> >> that program is. Is sharing a PHY IP block or driver ever
> >> possible for any HW?
> > 
> > yes it is possible, and OMAP5 shares the same IP for USB3 and SATA.
> > PHYs don't know about USB, SATA, Ethernet and whatnot. PHYs know
> > solely about the physical layer. Their work is just to generate the
> > proper electrical signals.
> 
> Hmm. Is the current code in drivers/usb/phy/tegra_usb_phy.c not really
> a PHY driver, then? Tegra's USB PHY HW module definitely does know
> that it's specifically a USB PHY. It has direct knowledge of

knowledge of UTMI/ULPI doesn't mean it knows it's a USB PHY. SATA and
USB3 use the PIPE3 interface, which was designed, originally, for PCIe.

It's just that UTMI/ULPI only got used in USB scenario.

> UTMI/ULPI/... Instead, should the code be part of the EHCI driver,

no way, no. EHCI-core should be taught about PHYs instead.

> since the concept of a PHY known to drivers/usb/phy doesn't seem
> related to what the Tegra PHY HW actually is?

I disagree a PHY is a PHY, no matter if it's attached to a Host IP,
Device IP or DRD IP.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

Hi,

On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote:
> >> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> >>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren
> >>> wrote:
> >>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>>>> this will make sure that we have sensible names for all
> >>>>> phy drivers. Current situation was already quite bad with
> >>>>> too generic names being used.
> >>>> 
> >>>> Is phy-$name specific enough? There are other types of PHY
> >>>> such as Ethernet, etc. What about phy-usb-$name?
> >>> 
> >>> we will be creating a generic (kernel-wide) phy layer, so I
> >>> guess that matters very little. Specially since we don't want
> >>> to be differentiating PHYs by their subsystem and rather by the
> >>> IP name (which means phy-tegra, phy-samsung, phy-omap, are all
> >>> 'wrong', but there were no better names).
> >>> 
> >>>> Venu, please comment on what conflicts, if any, this will
> >>>> cause with the patches you'll be sending to clean up the
> >>>> Tegra USB/PHY drivers. Thanks.
> >>> 
> >>> BTW, let's stop with the whole dependency between PHY driver 
> >>> cleanup and arch/arm/mach-tegra/, too many patches have gone 
> >>> upstream bypassing my tree. What we should be doing is figuring
> >>> out how to remove arch/ dependencies so that patches can go
> >>> upstream and not cause conflicts.
> >> 
> >> Unfortunately, there's no way to actually avoid the dependencies 
> >> themselves. The DT bindings and EHCI/PHY controller split are
> >> wrong, and need work on both the DT and drivers to fix.
> > 
> > but those changes don't need to come together, right ? I mean, for
> > the DT part you could add the bindings to driver A without removing
> > from driver B and span the changes accross 2 merge windows.
> 
> There is only a single driver. It's being reworked to support the new
> binding.

alright, so what's the problem of adding new binding without removing
old one for v3.10 and remove old on v3.11 ? It gives a 3 month grace
period for all boards to be converted, at least.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Stephen Warren]

On 03/11/2013 12:49 PM, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote:
>>>> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
>>>>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren 
>>>>> wrote:
>>>>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
>>>>>>> this will make sure that we have sensible names for
>>>>>>> all phy drivers. Current situation was already quite
>>>>>>> bad with too generic names being used.
>>>>>> 
>>>>>> Is phy-$name specific enough? There are other types of
>>>>>> PHY such as Ethernet, etc. What about phy-usb-$name?
>>>>> 
>>>>> we will be creating a generic (kernel-wide) phy layer, so
>>>>> I guess that matters very little. Specially since we don't
>>>>> want to be differentiating PHYs by their subsystem and
>>>>> rather by the IP name (which means phy-tegra, phy-samsung,
>>>>> phy-omap, are all 'wrong', but there were no better
>>>>> names).
>>>>> 
>>>>>> Venu, please comment on what conflicts, if any, this
>>>>>> will cause with the patches you'll be sending to clean up
>>>>>> the Tegra USB/PHY drivers. Thanks.
>>>>> 
>>>>> BTW, let's stop with the whole dependency between PHY
>>>>> driver cleanup and arch/arm/mach-tegra/, too many patches
>>>>> have gone upstream bypassing my tree. What we should be
>>>>> doing is figuring out how to remove arch/ dependencies so
>>>>> that patches can go upstream and not cause conflicts.
>>>> 
>>>> Unfortunately, there's no way to actually avoid the
>>>> dependencies themselves. The DT bindings and EHCI/PHY
>>>> controller split are wrong, and need work on both the DT and
>>>> drivers to fix.
>>> 
>>> but those changes don't need to come together, right ? I mean,
>>> for the DT part you could add the bindings to driver A without
>>> removing from driver B and span the changes accross 2 merge
>>> windows.
>> 
>> There is only a single driver. It's being reworked to support the
>> new binding.
> 
> alright, so what's the problem of adding new binding without
> removing old one for v3.10 and remove old on v3.11 ? It gives a 3
> month grace period for all boards to be converted, at least.

By binding, I assume you mean the driver code that implements the
binding, so you want the driver to support both the old and new
bindings at once? I don't think that's practical in this case.

Currently the EHCI driver parses a single EHCI DT node, and passes
some information down to the PHY driver. The PHY driver is in fact
just a set of functions and not actually any kind of driver.

The patches will split the single EHCI DT node into a separate EHCI
and PHY DT nodes, convert the PHY driver to an actual (platform)
driver, move the parsing of the PHY DT node into the new PHY DT
driver, and remove the parsing of the PHY-related properties from the
EHCI driver. Supporting both sets of DT content across that transition
would be rather difficult I think.

The patches will convert all in-tree boards, and I'm pretty confident
that there aren't actually any out-of-tree boards for Tegra (that use
a mainline kernel; there are plenty that don't use DT and are based on
much older kernels). Hence, I don't see any need for a grace period
here. Even if there are out-of-tree boards, the conversion of the DT
content would take about 30 seconds. I'll volunteer to even do it
(without testing!) for any out-of-tree boards if there are any.

One reason that I really care about moving this forward quickly, is
that you had indicated the driver cleanup was a pre-requisite to
continuing to extend the code. Right now, the Tegra USB drivers only
support Tegra20. We'd really like to get Tegra30 and now Tegra114 USB
support into mainline ASAP.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 4187 bytes --]

Hi,

On Mon, Mar 11, 2013 at 01:54:54PM -0600, Stephen Warren wrote:
> > On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote:
> >>>> On 03/08/2013 12:08 AM, Felipe Balbi wrote:
> >>>>> On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren 
> >>>>> wrote:
> >>>>>> On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> >>>>>>> this will make sure that we have sensible names for
> >>>>>>> all phy drivers. Current situation was already quite
> >>>>>>> bad with too generic names being used.
> >>>>>> 
> >>>>>> Is phy-$name specific enough? There are other types of
> >>>>>> PHY such as Ethernet, etc. What about phy-usb-$name?
> >>>>> 
> >>>>> we will be creating a generic (kernel-wide) phy layer, so
> >>>>> I guess that matters very little. Specially since we don't
> >>>>> want to be differentiating PHYs by their subsystem and
> >>>>> rather by the IP name (which means phy-tegra, phy-samsung,
> >>>>> phy-omap, are all 'wrong', but there were no better
> >>>>> names).
> >>>>> 
> >>>>>> Venu, please comment on what conflicts, if any, this
> >>>>>> will cause with the patches you'll be sending to clean up
> >>>>>> the Tegra USB/PHY drivers. Thanks.
> >>>>> 
> >>>>> BTW, let's stop with the whole dependency between PHY
> >>>>> driver cleanup and arch/arm/mach-tegra/, too many patches
> >>>>> have gone upstream bypassing my tree. What we should be
> >>>>> doing is figuring out how to remove arch/ dependencies so
> >>>>> that patches can go upstream and not cause conflicts.
> >>>> 
> >>>> Unfortunately, there's no way to actually avoid the
> >>>> dependencies themselves. The DT bindings and EHCI/PHY
> >>>> controller split are wrong, and need work on both the DT and
> >>>> drivers to fix.
> >>> 
> >>> but those changes don't need to come together, right ? I mean,
> >>> for the DT part you could add the bindings to driver A without
> >>> removing from driver B and span the changes accross 2 merge
> >>> windows.
> >> 
> >> There is only a single driver. It's being reworked to support the
> >> new binding.
> > 
> > alright, so what's the problem of adding new binding without
> > removing old one for v3.10 and remove old on v3.11 ? It gives a 3
> > month grace period for all boards to be converted, at least.
> 
> By binding, I assume you mean the driver code that implements the
> binding, so you want the driver to support both the old and new
> bindings at once? I don't think that's practical in this case.
> 
> Currently the EHCI driver parses a single EHCI DT node, and passes
> some information down to the PHY driver. The PHY driver is in fact
> just a set of functions and not actually any kind of driver.

that's quite wrong :-)

> The patches will split the single EHCI DT node into a separate EHCI
> and PHY DT nodes, convert the PHY driver to an actual (platform)
> driver, move the parsing of the PHY DT node into the new PHY DT
> driver, and remove the parsing of the PHY-related properties from the
> EHCI driver. Supporting both sets of DT content across that transition
> would be rather difficult I think.

ok, now I get the full picture.

> The patches will convert all in-tree boards, and I'm pretty confident
> that there aren't actually any out-of-tree boards for Tegra (that use
> a mainline kernel; there are plenty that don't use DT and are based on
> much older kernels). Hence, I don't see any need for a grace period
> here. Even if there are out-of-tree boards, the conversion of the DT
> content would take about 30 seconds. I'll volunteer to even do it
> (without testing!) for any out-of-tree boards if there are any.

I guess we can't delete this from archives anymore :-p

> One reason that I really care about moving this forward quickly, is
> that you had indicated the driver cleanup was a pre-requisite to
> continuing to extend the code. Right now, the Tegra USB drivers only
> support Tegra20. We'd really like to get Tegra30 and now Tegra114 USB
> support into mainline ASAP.

Alright, now that I have the full picture it makes it a lot easier to
ack patches, thanks. Sorry for somewhat wasting time, please carry on.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Venu Byravarasu]

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
> Sent: Friday, March 08, 2013 1:08 PM
> To: Venu Byravarasu
> Cc: Stephen Warren; Felipe Balbi; Linux USB Mailing List; Greg KH; linux-
> tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org;
> aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org;
> kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org; p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org;
> stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org; yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> 
> * PGP Signed by an unknown key
> 
> On Fri, Mar 08, 2013 at 12:51:13PM +0530, Venu Byravarasu wrote:
> > > -----Original Message-----
> > > From: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-tegra-
> > > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Stephen Warren
> > > Sent: Friday, March 08, 2013 2:07 AM
> > > To: Felipe Balbi; Venu Byravarasu
> > > Cc: Linux USB Mailing List; Greg KH; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > > s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org;
> aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
> > > gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org;
> > > p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org;
> > > yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> > > Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> > >
> > > On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> > > > this will make sure that we have sensible names
> > > > for all phy drivers. Current situation was already
> > > > quite bad with too generic names being used.
> > >
> > > Is phy-$name specific enough? There are other types of PHY such as
> > > Ethernet, etc. What about phy-usb-$name?
> > >
> > > Venu, please comment on what conflicts, if any, this will cause with the
> > > patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.
> >
> > As this is just a name change, it should not cause any big issues, other than
> porting
> > all changes on top of this new file.
> >
> > Felipe,
> > When can we expect these changes getting merged into linux-next?
> 
> After -rc2 is tagged, I will have everything I need to start my -next
> branch. From that point on it should be in linux-next ;-)

As your change is not yet merged, can you plz exclude Tegra USB PHY driver renaming 
alone from your patch, as my patches are almost ready on top of current linux-next code base?
If you are OK, I can push the renaming patch as part of my last patch, so that manual merge on
top of new file can be avoided and your target of changing file names also will be served. 

> 
> --
> balbi
> 
> * Unknown Key
> * 0x35CAA444

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 3501 bytes --]

On Wed, Mar 13, 2013 at 06:01:13PM +0530, Venu Byravarasu wrote:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
> > Sent: Friday, March 08, 2013 1:08 PM
> > To: Venu Byravarasu
> > Cc: Stephen Warren; Felipe Balbi; Linux USB Mailing List; Greg KH; linux-
> > tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org;
> > aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org;
> > kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org; p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org;
> > stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org; yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> > Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> > 
> > * PGP Signed by an unknown key
> > 
> > On Fri, Mar 08, 2013 at 12:51:13PM +0530, Venu Byravarasu wrote:
> > > > -----Original Message-----
> > > > From: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-tegra-
> > > > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Stephen Warren
> > > > Sent: Friday, March 08, 2013 2:07 AM
> > > > To: Felipe Balbi; Venu Byravarasu
> > > > Cc: Linux USB Mailing List; Greg KH; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > > > s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org;
> > aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
> > > > gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org;
> > > > p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org; tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org;
> > > > yuxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
> > > > Subject: Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c
> > > >
> > > > On 03/07/2013 08:45 AM, Felipe Balbi wrote:
> > > > > this will make sure that we have sensible names
> > > > > for all phy drivers. Current situation was already
> > > > > quite bad with too generic names being used.
> > > >
> > > > Is phy-$name specific enough? There are other types of PHY such as
> > > > Ethernet, etc. What about phy-usb-$name?
> > > >
> > > > Venu, please comment on what conflicts, if any, this will cause with the
> > > > patches you'll be sending to clean up the Tegra USB/PHY drivers. Thanks.
> > >
> > > As this is just a name change, it should not cause any big issues, other than
> > porting
> > > all changes on top of this new file.
> > >
> > > Felipe,
> > > When can we expect these changes getting merged into linux-next?
> > 
> > After -rc2 is tagged, I will have everything I need to start my -next
> > branch. From that point on it should be in linux-next ;-)
> 
> As your change is not yet merged, can you plz exclude Tegra USB PHY
> driver renaming alone from your patch, as my patches are almost ready
> on top of current linux-next code base?
> If you are OK, I can push the renaming patch as part of my last patch,
> so that manual merge on top of new file can be avoided and your target
> of changing file names also will be served. 

git can handle the rename just fine. Besides the merge conflicts will be
easy to solve. I don't think it's necessary to drop the patch from my
tree.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]