[PATCH] regmap: Remove __attribute__ ((packed))

[PATCH] regmap: Remove __attribute__ ((packed))

[Dimitris Papastamos]

There is no point having this.  The space gains are trivial if there
are any at all.

Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
 drivers/base/regmap/regcache-rbtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index dd5ed6c..383fc00 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -31,7 +31,7 @@ struct regcache_rbtree_node {
 	void *block;
 	/* number of registers available in the block */
 	unsigned int blklen;
-} __attribute__ ((packed));
+};
 
 struct regcache_rbtree_ctx {
 	struct rb_root root;
-- 
1.8.1.5

Re: [PATCH] regmap: Remove __attribute__ ((packed))

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

On Thu, Mar 14, 2013 at 03:26:19PM +0000, Dimitris Papastamos wrote:
> There is no point having this.  The space gains are trivial if there
> are any at all.

Applied, but numbers would have been nice and...

> Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f

...this shouldn't be in upstream submissions.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] regmap: Remove __attribute__ ((packed))

[Dimitris Papastamos]

On Fri, Mar 15, 2013 at 01:36:40AM +0000, Mark Brown wrote:
> On Thu, Mar 14, 2013 at 03:26:19PM +0000, Dimitris Papastamos wrote:
> > There is no point having this.  The space gains are trivial if there
> > are any at all.
> 
> Applied, but numbers would have been nice and...
> 
> > Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f
> 
> ...this shouldn't be in upstream submissions.

Oops, sorry for the Change-Id.

On my system there was no benefit of using it, it just happens
that the struct is aligned properly and needs no padding.

Thanks,
Dimitris

Re: [PATCH] regmap: Remove __attribute__ ((packed))

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On Fri, Mar 15, 2013 at 11:16:02AM +0000, Dimitris Papastamos wrote:

> On my system there was no benefit of using it, it just happens
> that the struct is aligned properly and needs no padding.

OK, so which system was that and is it not possible that other systems
will get something useful from this?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] regmap: Remove __attribute__ ((packed))

[Dimitris Papastamos]

On Fri, Mar 15, 2013 at 04:53:51PM +0000, Mark Brown wrote:
> On Fri, Mar 15, 2013 at 11:16:02AM +0000, Dimitris Papastamos wrote:
> 
> > On my system there was no benefit of using it, it just happens
> > that the struct is aligned properly and needs no padding.
> 
> OK, so which system was that and is it not possible that other systems
> will get something useful from this?

Well I guess it has to do with the gcc cross compiler version that
I've got and the actual data layout of the linking rbtree node.
The data seems to be aligned on a 4-byte boundary anyhow and
that should be ok for many systems.

Thanks,
Dimitris