From: Samuel Ortiz <sameo@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bill Pemberton <wfp5p@virginia.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove
Date: Fri, 15 Mar 2013 07:43:31 +0100 [thread overview]
Message-ID: <20130315064331.GC12559@zurbaran> (raw)
In-Reply-To: <1363298204-8014-1-git-send-email-arnd@arndb.de>
Hi Arnd,
On Thu, Mar 14, 2013 at 10:56:38PM +0100, Arnd Bergmann wrote:
> 4740f73fe5 "mfd: remove use of __devexit" removed the __devexit annotation
> on the twl4030_madc_remove function, but left an __exit_p() present on the
> pointer to this function. Using __exit_p was as wrong with the devexit in
> place as it is now, but now we get a gcc warning about an unused function.
>
> In order for the twl4030_madc_remove to work correctly in built-in code, we
> have to remove the __exit_p.
>
> Cc: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> Please apply to MFD tree for 3.9
>
> drivers/mfd/twl4030-madc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mfd-fixes.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove
Date: Fri, 15 Mar 2013 07:43:31 +0100 [thread overview]
Message-ID: <20130315064331.GC12559@zurbaran> (raw)
In-Reply-To: <1363298204-8014-1-git-send-email-arnd@arndb.de>
Hi Arnd,
On Thu, Mar 14, 2013 at 10:56:38PM +0100, Arnd Bergmann wrote:
> 4740f73fe5 "mfd: remove use of __devexit" removed the __devexit annotation
> on the twl4030_madc_remove function, but left an __exit_p() present on the
> pointer to this function. Using __exit_p was as wrong with the devexit in
> place as it is now, but now we get a gcc warning about an unused function.
>
> In order for the twl4030_madc_remove to work correctly in built-in code, we
> have to remove the __exit_p.
>
> Cc: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> Please apply to MFD tree for 3.9
>
> drivers/mfd/twl4030-madc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mfd-fixes.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-03-15 6:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 21:56 [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-14 21:56 ` [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-15 6:44 ` Samuel Ortiz
2013-03-15 6:44 ` Samuel Ortiz
2013-03-15 10:18 ` Arnd Bergmann
2013-03-15 10:18 ` Arnd Bergmann
2013-03-15 16:46 ` Samuel Ortiz
2013-03-15 16:46 ` Samuel Ortiz
2013-03-14 21:56 ` [PATCH 3/3] mfd: ab8500: kill "reg" property from binding Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-15 6:45 ` Samuel Ortiz
2013-03-15 6:45 ` Samuel Ortiz
2013-03-14 21:56 ` [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-15 6:26 ` Geert Uytterhoeven
2013-03-15 6:26 ` Geert Uytterhoeven
2013-03-15 10:15 ` Arnd Bergmann
2013-03-15 10:15 ` Arnd Bergmann
2013-03-15 12:16 ` David Miller
2013-03-15 12:16 ` David Miller
2013-03-15 12:29 ` Arnd Bergmann
2013-03-15 12:29 ` Arnd Bergmann
2013-03-15 12:33 ` David Miller
2013-03-15 12:33 ` David Miller
2013-03-15 13:41 ` Arnd Bergmann
2013-03-15 13:41 ` Arnd Bergmann
2013-03-17 16:01 ` David Miller
2013-03-17 16:01 ` David Miller
2013-03-14 21:56 ` [PATCH] ethernet/tulip: DE4x5 needs VIRT_TO_BUS Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-17 16:01 ` David Miller
2013-03-17 16:01 ` David Miller
2013-03-14 21:56 ` [PATCH] vfio: include <linux/slab.h> for kmalloc Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-15 20:15 ` Alex Williamson
2013-03-15 20:15 ` Alex Williamson
2013-03-14 21:56 ` [PATCH] [media] ir: IR_RX51 only works on OMAP2 Arnd Bergmann
2013-03-14 21:56 ` Arnd Bergmann
2013-03-15 6:39 ` Timo Kokkonen
2013-03-15 6:39 ` Timo Kokkonen
2013-03-15 16:28 ` Tony Lindgren
2013-03-15 16:28 ` Tony Lindgren
2013-03-18 23:54 ` Mauro Carvalho Chehab
2013-03-18 23:54 ` Mauro Carvalho Chehab
2013-03-15 6:43 ` Samuel Ortiz [this message]
2013-03-15 6:43 ` [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315064331.GC12559@zurbaran \
--to=sameo@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.