* [U-Boot] [PATCHv2 1/3] OMAP3: igep00x0: use official board names.
2013-02-07 10:40 [U-Boot] [PATCHv2 0/3] new IGEP board support
@ 2013-02-07 10:40 `
2013-02-19 16:17 ` [U-Boot] [U-Boot, PATCHv2, " Tom Rini
2013-02-07 10:40 ` [U-Boot] [U-boot][PATCHv2 2/3] OMAP3: igep00x0: add missing include mach-types.h
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: @ 2013-02-07 10:40 UTC (permalink / raw)
To: u-boot
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
This trivial patch only changes current boards names for the official
names.
Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
board/isee/igep00x0/igep00x0.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/isee/igep00x0/igep00x0.h b/board/isee/igep00x0/igep00x0.h
index fefdb89..dbc7cf6 100644
--- a/board/isee/igep00x0/igep00x0.h
+++ b/board/isee/igep00x0/igep00x0.h
@@ -34,10 +34,10 @@
const omap3_sysinfo sysinfo = {
DDR_STACKED,
#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020)
- "OMAP3 IGEP v2 board",
+ "IGEPv2",
#endif
#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030)
- "OMAP3 IGEP COM Module",
+ "IGEP COM MODULE/ELECTRON",
#endif
#if defined(CONFIG_ENV_IS_IN_ONENAND)
"ONENAND",
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [U-boot][PATCHv2 2/3] OMAP3: igep00x0: add missing include mach-types.h
2013-02-07 10:40 [U-Boot] [PATCHv2 0/3] new IGEP board support
2013-02-07 10:40 ` [U-Boot] [PATCHv2 1/3] OMAP3: igep00x0: use official board names
@ 2013-02-07 10:40 `
2013-02-07 10:40 ` [U-Boot] [PATCHv2 3/3] OMAP3: igep00x0: Add new IGEP COM PROTON
2013-02-07 11:37 ` [U-Boot] [PATCHv2 0/3] new IGEP board support Javier Martinez Canillas
3 siblings, 0 replies; 8+ messages in thread
From: @ 2013-02-07 10:40 UTC (permalink / raw)
To: u-boot
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
Current '#if' directives (used in igep00x0.h config file) comparing MACH_TYPE
values in igep00x0.h doesn't work as expected. The comparision between
CONFIG_MACH_TYPE and MACH_TYPE_IGEP0020 is always true independent of the IGEP
machine configured.
For example, following directive
if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020)
define something
endif
Is always evaluated true although we configure u-boot for MACH_TYPE_IGEP0030.
The build doesn't shows any error so looks that both defines had always the same
value. Including the mach-types.h file sets properly the value of
MACH_TYPE_IGEPxxxx.
Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
include/configs/igep00x0.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h
index 0e7f924..0e539ef 100644
--- a/include/configs/igep00x0.h
+++ b/include/configs/igep00x0.h
@@ -36,6 +36,7 @@
#include <asm/arch/cpu.h>
#include <asm/arch/omap3.h>
+#include <asm/mach-types.h>
/*
* Display CPU and Board information
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCHv2 3/3] OMAP3: igep00x0: Add new IGEP COM PROTON.
2013-02-07 10:40 [U-Boot] [PATCHv2 0/3] new IGEP board support
2013-02-07 10:40 ` [U-Boot] [PATCHv2 1/3] OMAP3: igep00x0: use official board names
2013-02-07 10:40 ` [U-Boot] [U-boot][PATCHv2 2/3] OMAP3: igep00x0: add missing include mach-types.h
@ 2013-02-07 10:40 `
2013-02-07 11:37 ` [U-Boot] [PATCHv2 0/3] new IGEP board support Javier Martinez Canillas
3 siblings, 0 replies; 8+ messages in thread
From: @ 2013-02-07 10:40 UTC (permalink / raw)
To: u-boot
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
The IGEP COM PROTON is a new ultra compact module design with an
on-board ethernet controller.
Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
MAINTAINERS | 1 +
board/isee/igep00x0/igep00x0.h | 3 +++
boards.cfg | 1 +
include/configs/igep00x0.h | 6 +++++-
4 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d3ed390..1aed6d9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -607,6 +607,7 @@ Enric Balletbo i Serra <eballetbo@iseebcn.com>
igep0020 ARM ARMV7 (OMAP3xx SoC)
igep0030 ARM ARMV7 (OMAP3xx SoC)
+ igep0032 ARM ARMV7 (OMAP3xx SoC)
Eric Benard <eric@eukrea.com>
diff --git a/board/isee/igep00x0/igep00x0.h b/board/isee/igep00x0/igep00x0.h
index dbc7cf6..f5fce9c 100644
--- a/board/isee/igep00x0/igep00x0.h
+++ b/board/isee/igep00x0/igep00x0.h
@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {
#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030)
"IGEP COM MODULE/ELECTRON",
#endif
+#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0032)
+ "IGEP COM PROTON",
+#endif
#if defined(CONFIG_ENV_IS_IN_ONENAND)
"ONENAND",
#else
diff --git a/boards.cfg b/boards.cfg
index 691a32a..8453836 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee
igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND
igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND
igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND
+igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND
am3517_evm arm armv7 am3517evm logicpd omap3
mt_ventoux arm armv7 mt_ventoux teejet omap3
omap3_zoom1 arm armv7 zoom1 logicpd omap3
diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h
index 0e539ef..559e375 100644
--- a/include/configs/igep00x0.h
+++ b/include/configs/igep00x0.h
@@ -87,7 +87,10 @@
#define CONFIG_DOS_PARTITION 1
/* define to enable boot progress via leds */
+#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) || \
+ (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030)
#define CONFIG_SHOW_BOOT_PROGRESS
+#endif
/* USB */
#define CONFIG_MUSB_UDC 1
@@ -119,7 +122,8 @@
#ifdef CONFIG_BOOT_NAND
#define CONFIG_CMD_NAND
#endif
-#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020)
+#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) || \
+ (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0032)
#define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */
#endif
#define CONFIG_CMD_DHCP
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCHv2 0/3] new IGEP board support
2013-02-07 10:40 [U-Boot] [PATCHv2 0/3] new IGEP board support
` (2 preceding siblings ...)
2013-02-07 10:40 ` [U-Boot] [PATCHv2 3/3] OMAP3: igep00x0: Add new IGEP COM PROTON
@ 2013-02-07 11:37 ` Javier Martinez Canillas
2013-03-15 12:48 ` Enric Balletbo Serra
3 siblings, 1 reply; 8+ messages in thread
From: Javier Martinez Canillas @ 2013-02-07 11:37 UTC (permalink / raw)
To: u-boot
On Thu, Feb 7, 2013 at 11:40 AM, [Enric Balletbo i Serra
<eballetbo@gmail.com> wrote:
> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
> Hi all,
>
> This is the second version to add support to the IGEP COM PROTON board in
> current mainline.
>
> These patches applies on top of u-boot-ti repository as the following patch is
> required.
>
> OMAP3: use a single board file for IGEP devices
> commit 076be4528851126b56f2c1b84d07834297797f6c
> From Javier Martinez Canillas
>
> Changes since v1:
> * Only define CONFIG_SHOW_BOOT_PROGRESS for the machines that have a boot
> progress (thanks to Javier)
> * Also define CONFIG_CMD_NET on IGEP0032 machine (thanks to Javier)
> * Add new patch in the serie to fix a missing include.
>
> Thanks a lot for your comments,
>
> Enric Balletbo i Serra (3):
> OMAP3: igep00x0: use official board names.
> OMAP3: igep00x0: add missing include mach-types.h in config.
> OMAP3: igep00x0: Add new IGEP COM PROTON.
>
For all the patches:
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCHv2 0/3] new IGEP board support
2013-02-07 11:37 ` [U-Boot] [PATCHv2 0/3] new IGEP board support Javier Martinez Canillas
@ 2013-03-15 12:48 ` Enric Balletbo Serra
2013-03-15 13:08 ` Tom Rini
0 siblings, 1 reply; 8+ messages in thread
From: Enric Balletbo Serra @ 2013-03-15 12:48 UTC (permalink / raw)
To: u-boot
Hi Tom,
Any comments on these patch series ?
2013/2/7 Javier Martinez Canillas <javier@dowhile0.org>:
> On Thu, Feb 7, 2013 at 11:40 AM, [Enric Balletbo i Serra
> <eballetbo@gmail.com> wrote:
>> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>>
>> Hi all,
>>
>> This is the second version to add support to the IGEP COM PROTON board in
>> current mainline.
>>
>> These patches applies on top of u-boot-ti repository as the following patch is
>> required.
>>
>> OMAP3: use a single board file for IGEP devices
>> commit 076be4528851126b56f2c1b84d07834297797f6c
>> From Javier Martinez Canillas
>>
>> Changes since v1:
>> * Only define CONFIG_SHOW_BOOT_PROGRESS for the machines that have a boot
>> progress (thanks to Javier)
>> * Also define CONFIG_CMD_NET on IGEP0032 machine (thanks to Javier)
>> * Add new patch in the serie to fix a missing include.
>>
>> Thanks a lot for your comments,
>>
>> Enric Balletbo i Serra (3):
>> OMAP3: igep00x0: use official board names.
>> OMAP3: igep00x0: add missing include mach-types.h in config.
>> OMAP3: igep00x0: Add new IGEP COM PROTON.
>>
>
> For all the patches:
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCHv2 0/3] new IGEP board support
2013-03-15 12:48 ` Enric Balletbo Serra
@ 2013-03-15 13:08 ` Tom Rini
0 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2013-03-15 13:08 UTC (permalink / raw)
To: u-boot
On Fri, Mar 15, 2013 at 01:48:38PM +0100, Enric Balletbo Serra wrote:
> Hi Tom,
>
> Any comments on these patch series ?
>
> 2013/2/7 Javier Martinez Canillas <javier@dowhile0.org>:
> > On Thu, Feb 7, 2013 at 11:40 AM, [Enric Balletbo i Serra
> > <eballetbo@gmail.com> wrote:
> >> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> >>
> >> Hi all,
> >>
> >> This is the second version to add support to the IGEP COM PROTON board in
> >> current mainline.
> >>
> >> These patches applies on top of u-boot-ti repository as the following patch is
> >> required.
> >>
> >> OMAP3: use a single board file for IGEP devices
> >> commit 076be4528851126b56f2c1b84d07834297797f6c
> >> From Javier Martinez Canillas
> >>
> >> Changes since v1:
> >> * Only define CONFIG_SHOW_BOOT_PROGRESS for the machines that have a boot
> >> progress (thanks to Javier)
> >> * Also define CONFIG_CMD_NET on IGEP0032 machine (thanks to Javier)
> >> * Add new patch in the serie to fix a missing include.
> >>
> >> Thanks a lot for your comments,
> >>
> >> Enric Balletbo i Serra (3):
> >> OMAP3: igep00x0: use official board names.
> >> OMAP3: igep00x0: add missing include mach-types.h in config.
> >> OMAP3: igep00x0: Add new IGEP COM PROTON.
> >>
> >
> > For all the patches:
> >
> > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Sorry, applied to u-boot-ti/master and already now part of
u-boot-arm/master.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130315/6332e7a9/attachment.pgp>
^ permalink raw reply [flat|nested] 8+ messages in thread