* [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing
@ 2013-03-20 1:12 Kirill Tkhai
2013-03-20 18:42 ` David Miller
2013-03-20 20:14 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Kirill Tkhai @ 2013-03-20 1:12 UTC (permalink / raw)
To: sparclinux
Common hibernation code looks at num_physpages during suspend and restore.
Restore is able to be called from initcall, which is before initmem freeing.
This case leads to restore fail.
Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
CC: David Miller <davem@davemloft.net>
CC: Sam Ravnborg <sam@ravnborg.org>
---
arch/sparc/mm/init_64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index 5c2c6e6..d3f8506 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -2125,7 +2125,6 @@ void free_initmem(void)
ClearPageReserved(p);
init_page_count(p);
__free_page(p);
- num_physpages++;
totalram_pages++;
}
}
@@ -2142,7 +2141,6 @@ void free_initrd_mem(unsigned long start, unsigned long end)
ClearPageReserved(p);
init_page_count(p);
__free_page(p);
- num_physpages++;
totalram_pages++;
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing
2013-03-20 1:12 [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing Kirill Tkhai
@ 2013-03-20 18:42 ` David Miller
2013-03-20 20:14 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-20 18:42 UTC (permalink / raw)
To: sparclinux
From: Kirill Tkhai <tkhai@yandex.ru>
Date: Wed, 20 Mar 2013 05:12:08 +0400
> Common hibernation code looks at num_physpages during suspend and restore.
> Restore is able to be called from initcall, which is before initmem freeing.
> This case leads to restore fail.
>
> Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing
2013-03-20 1:12 [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing Kirill Tkhai
2013-03-20 18:42 ` David Miller
@ 2013-03-20 20:14 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2013-03-20 20:14 UTC (permalink / raw)
To: sparclinux
On Wed, Mar 20, 2013 at 02:42:07PM -0400, David Miller wrote:
> From: Kirill Tkhai <tkhai@yandex.ru>
> Date: Wed, 20 Mar 2013 05:12:08 +0400
>
> > Common hibernation code looks at num_physpages during suspend and restore.
> > Restore is able to be called from initcall, which is before initmem freeing.
> > This case leads to restore fail.
> >
> > Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
>
> Applied.
Btw. I expect this patch to introduce some trivial conflict with a patch
in Andrew's queue which cleans up some memory management stuff.
This: "mm/SPARC: use common help functions to free reserved pages"
Just so we are prepared when it happens.
Stephen will tell us...
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-20 1:12 [PATCH v2 1/1]sparc64: Do not change num_physpages during initmem freeing Kirill Tkhai
2013-03-20 18:42 ` David Miller
2013-03-20 20:14 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.