From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: dev@openvswitch.org, Karsten Keil <isdn@linux-pingi.de>,
netdev@vger.kernel.org, Gross <jesse@nicira.com>,
linux-media@vger.kernel.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel@lists.sourceforge.net,
"David S. Miller" <davem@davemloft.net>,
Jesse
Subject: Re: [PATCH] net: add ETH_P_802_3_MIN
Date: Thu, 21 Mar 2013 11:02:55 -0300 [thread overview]
Message-ID: <20130321110255.4c06b2b7@redhat.com> (raw)
In-Reply-To: <1363854568-32228-1-git-send-email-horms@verge.net.au>
Em Thu, 21 Mar 2013 17:29:28 +0900
Simon Horman <horms@verge.net.au> escreveu:
> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> an 802.3 frame. Frames with a lower value in the ethernet type field
> are Ethernet II.
>
> Also update all the users of this value that I could find to use the
> new constant.
>
> I anticipate adding some more users of this constant when
> adding MPLS support to Open vSwtich.
>
> As suggested by Jesse Gross.
>
> Compile tested only.
>
> Cc: Jesse Gross <jesse@nicira.com>
> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-media@vger.kernel.org
> Cc: dev@openvswitch.org
> Signed-off-by: Simon Horman <horms@verge.net.au>
...
> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
> index 44225b1..9fc82a1 100644
> --- a/drivers/media/dvb-core/dvb_net.c
> +++ b/drivers/media/dvb-core/dvb_net.c
> @@ -185,7 +185,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
> skb->pkt_type=PACKET_MULTICAST;
> }
>
> - if (ntohs(eth->h_proto) >= 1536)
> + if (ntohs(eth->h_proto) >= ETH_P_802_3_MIN)
> return eth->h_proto;
...
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cheers,
Mauro
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jesse Gross <jesse@nicira.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Karsten Keil <isdn@linux-pingi.de>,
linux1394-devel@lists.sourceforge.net,
linux-media@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH] net: add ETH_P_802_3_MIN
Date: Thu, 21 Mar 2013 11:02:55 -0300 [thread overview]
Message-ID: <20130321110255.4c06b2b7@redhat.com> (raw)
In-Reply-To: <1363854568-32228-1-git-send-email-horms@verge.net.au>
Em Thu, 21 Mar 2013 17:29:28 +0900
Simon Horman <horms@verge.net.au> escreveu:
> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> an 802.3 frame. Frames with a lower value in the ethernet type field
> are Ethernet II.
>
> Also update all the users of this value that I could find to use the
> new constant.
>
> I anticipate adding some more users of this constant when
> adding MPLS support to Open vSwtich.
>
> As suggested by Jesse Gross.
>
> Compile tested only.
>
> Cc: Jesse Gross <jesse@nicira.com>
> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-media@vger.kernel.org
> Cc: dev@openvswitch.org
> Signed-off-by: Simon Horman <horms@verge.net.au>
...
> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
> index 44225b1..9fc82a1 100644
> --- a/drivers/media/dvb-core/dvb_net.c
> +++ b/drivers/media/dvb-core/dvb_net.c
> @@ -185,7 +185,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
> skb->pkt_type=PACKET_MULTICAST;
> }
>
> - if (ntohs(eth->h_proto) >= 1536)
> + if (ntohs(eth->h_proto) >= ETH_P_802_3_MIN)
> return eth->h_proto;
...
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cheers,
Mauro
next prev parent reply other threads:[~2013-03-21 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 8:29 [PATCH] net: add ETH_P_802_3_MIN Simon Horman
2013-03-21 13:24 ` Stefan Richter
2013-03-21 13:24 ` Stefan Richter
2013-03-21 14:02 ` Mauro Carvalho Chehab [this message]
2013-03-21 14:02 ` Mauro Carvalho Chehab
2013-03-21 15:56 ` David Miller
[not found] ` <20130321.115608.570355867509300023.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-03-22 13:49 ` Simon Horman
2013-03-22 13:49 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321110255.4c06b2b7@redhat.com \
--to=mchehab@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=horms@verge.net.au \
--cc=isdn@linux-pingi.de \
--cc=jesse@nicira.com \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.