* [PATCH 1/4] linux-firmware: Use the included Makefile for install
@ 2013-03-23 20:30 Otavio Salvador
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 20:30 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
This uses the install procedure included in the Makefile which avoids
code dupplication.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
.../linux-firmware/linux-firmware/makefile-fix.patch | 19 +++++++++++++++++++
.../linux-firmware/linux-firmware_git.bb | 6 +++---
2 files changed, 22 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
new file mode 100644
index 0000000..8a23284
--- /dev/null
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
@@ -0,0 +1,19 @@
+build: Avoid use of bashism and Makefile deployment
+
+Upstream-Status: Submitted
+
+Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
+
+diff --git a/Makefile b/Makefile
+index 321a4e2..9bdeef0 100644
+--- a/Makefile
++++ b/Makefile
+@@ -9,4 +9,7 @@ install:
+ mkdir -p $(DESTDIR)$(FIRMWAREDIR)
+ cp -r * $(DESTDIR)$(FIRMWAREDIR)
+ rm -f $(DESTDIR)/usbdux/*dux $(DESTDIR)/*/*.asm
+- rm $(DESTDIR)$(FIRMWAREDIR)/{WHENCE,LICENSE.*,LICENCE.*}
++ rm $(DESTDIR)$(FIRMWAREDIR)/Makefile
++ rm $(DESTDIR)$(FIRMWAREDIR)/WHENCE
++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENSE.*
++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENCE.*
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index b9e00fc..6842738 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -24,7 +24,8 @@ SRCREV = "c530a75c1e6a472b0eb9558310b518f0dfcd8860"
PE = "1"
PV = "0.0+git${SRCPV}"
-SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git;protocol=git"
+SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git;protocol=git \
+ file://makefile-fix.patch"
S = "${WORKDIR}/git"
@@ -35,8 +36,7 @@ do_compile() {
}
do_install() {
- install -d ${D}/lib/firmware/
- cp -r * ${D}/lib/firmware/
+ oe_runmake install DESTDIR=${D}
# Libertas sd8686
ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
--
1.8.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-23 20:30 [PATCH 1/4] linux-firmware: Use the included Makefile for install Otavio Salvador
@ 2013-03-23 20:30 ` Otavio Salvador
2013-03-23 21:23 ` Khem Raj
2013-03-24 15:01 ` Eric Bénard
2013-03-23 20:30 ` [PATCH 3/4] linux-firmware: Package vt6656, ath6k, ath9k and ar9170 Otavio Salvador
` (2 subsequent siblings)
3 siblings, 2 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 20:30 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
We don't ship license files with packages and firmware packages are no
different; drop them.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index 6842738..99c226c 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -42,9 +42,6 @@ do_install() {
ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
ln -sf libertas/sd8686_v9_helper.bin ${D}/lib/firmware/sd8686_helper.bin
- # Realtek rtl8192*
- install -m 0644 LICENCE.rtlwifi_firmware.txt ${D}/lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt
-
# fixup wl12xx location, after 2.6.37 the kernel searches a different location for it
( cd ${D}/lib/firmware ; ln -sf ti-connectivity/* . )
}
@@ -56,20 +53,17 @@ PACKAGES =+ "${PN}-ralink ${PN}-sd8686 ${PN}-rtl8192cu \
LICENSE_${PN}-ralink = "Firmware-ralink"
FILES_${PN}-ralink = " \
/lib/firmware/rt*.bin \
- /lib/firmware/LICENSE.ralink_firmware.txt \
"
LICENSE_${PN}-sd8686 = "Firmware-libertas"
FILES_${PN}-sd8686 = " \
/lib/firmware/libertas/sd8686_v9* \
/lib/firmware/sd8686* \
- /lib/firmware/LICENCE.libertas \
"
LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi"
FILES_${PN}-rtl8192cu = " \
/lib/firmware/rtlwifi/rtl8192cufw.bin \
- /lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt \
"
LICENSE_${PN}-rtl8192ce = "Firmware-rtlwifi"
@@ -97,7 +91,6 @@ ALTERNATIVE_LINK_NAME[brcmfmac-sdio.bin] = "/lib/firmware/brcm/brcmfmac-sdio.bin
LICENSE_${PN}-bcm4329 = "Firmware-bcm4329"
FILES_${PN}-bcm4329 = " \
/lib/firmware/brcm/brcmfmac4329.bin \
- /lib/firmware/LICENCE.broadcom_bcm43xx \
"
ALTERNATIVE_linux-firmware-bcm4329 = "brcmfmac-sdio.bin"
ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] = "/lib/firmware/brcm/brcmfmac4329.bin"
@@ -105,7 +98,6 @@ ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] = "/lib/firmware/br
LICENSE_${PN}-bcm4330 = "Firmware-bcm4330"
FILES_${PN}-bcm4330 = " \
/lib/firmware/brcm/brcmfmac4330.bin \
- /lib/firmware/LICENCE.broadcom_bcm43xx \
"
ALTERNATIVE_linux-firmware-bcm4330 = "brcmfmac-sdio.bin"
@@ -114,7 +106,6 @@ ALTERNATIVE_TARGET_linux-firmware-bcm4330[brcmfmac-sdio.bin] = "/lib/firmware/br
LICENSE_${PN}-bcm4334 = "Firmware-bcm4334"
FILES_${PN}-bcm4334 = " \
/lib/firmware/brcm/brcmfmac4334.bin \
- /lib/firmware/LICENCE.broadcom_bcm43xx \
"
ALTERNATIVE_linux-firmware-bcm4334 = "brcmfmac-sdio.bin"
--
1.8.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/4] linux-firmware: Package vt6656, ath6k, ath9k and ar9170
2013-03-23 20:30 [PATCH 1/4] linux-firmware: Use the included Makefile for install Otavio Salvador
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
@ 2013-03-23 20:30 ` Otavio Salvador
2013-03-23 20:31 ` [PATCH 4/4] linux-firmware: Add missing license information for wl12xx Otavio Salvador
2013-03-23 21:21 ` [PATCH 1/4] linux-firmware: Use the included Makefile for install Khem Raj
3 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 20:30 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
.../linux-firmware/linux-firmware_git.bb | 29 +++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index 99c226c..b181a6b 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -18,6 +18,8 @@ LIC_FILES_CHKSUM = "file://LICENSE.radeon;md5=e56b405656593a0c97e478513051ea0e \
file://LICENCE.agere;md5=af0133de6b4a9b2522defd5f188afd31 \
file://LICENCE.rtlwifi_firmware.txt;md5=00d06cfd3eddd5a2698948ead2ad54a5 \
file://LICENCE.broadcom_bcm43xx;md5=3160c14df7228891b868060e1951dfbc \
+ file://LICENCE.atheros_firmware;md5=30a14c7823beedac9fa39c64fdd01a13 \
+ file://LICENCE.via_vt6656;md5=e4159694cba42d4377a912e78a6e850f \
"
SRCREV = "c530a75c1e6a472b0eb9558310b518f0dfcd8860"
@@ -48,7 +50,27 @@ do_install() {
PACKAGES =+ "${PN}-ralink ${PN}-sd8686 ${PN}-rtl8192cu \
${PN}-rtl8192ce ${PN}-rtl8192su ${PN}-wl12xx \
- ${PN}-bcm4329 ${PN}-bcm4330 ${PN}-bcm4334"
+ ${PN}-bcm4329 ${PN}-bcm4330 ${PN}-bcm4334 \
+ ${PN}-vt6656 ${PN}-ar9170 ${PN}-ath6k \
+ ${PN}-ath9k"
+
+LICENSE_${PN}-9170 = "Firmware-atheros_firmware"
+FILES_${PN}-ar9170 = " \
+ /lib/firmware/ar9170*.fw \
+"
+
+LICENSE_${PN}-ath6k = "Firmware-atheros_firmware"
+FILES_${PN}-ath6k = " \
+ /lib/firmware/ath6k \
+"
+
+LICENSE_${PN}-ath9k = "Firmware-atheros_firmware"
+FILES_${PN}-ath9k = " \
+ /lib/firmware/ar9271.fw \
+ /lib/firmware/ar7010*.fw \
+ /lib/firmware/htc_9271.fw \
+ /lib/firmware/htc_7010.fw \
+"
LICENSE_${PN}-ralink = "Firmware-ralink"
FILES_${PN}-ralink = " \
@@ -82,6 +104,11 @@ FILES_${PN}-wl12xx = " \
/lib/firmware/ti-connectivity \
"
+LICENSE_${PN}-vt6656 = "Firmware-via_vt6656"
+FILES_${PN}-vt6656 = " \
+ /lib/firmware/vntwusb.fw \
+"
+
# WARNING: The ALTERNATIVE_* variables are not using ${PN} because of
# a bug in bitbake; when this is fixed and bitbake learns how to proper
# pass variable flags with expansion we can rework this patch.
--
1.8.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/4] linux-firmware: Add missing license information for wl12xx
2013-03-23 20:30 [PATCH 1/4] linux-firmware: Use the included Makefile for install Otavio Salvador
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
2013-03-23 20:30 ` [PATCH 3/4] linux-firmware: Package vt6656, ath6k, ath9k and ar9170 Otavio Salvador
@ 2013-03-23 20:31 ` Otavio Salvador
2013-03-23 21:21 ` [PATCH 1/4] linux-firmware: Use the included Makefile for install Khem Raj
3 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 20:31 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index b181a6b..c1f40fe 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -18,6 +18,7 @@ LIC_FILES_CHKSUM = "file://LICENSE.radeon;md5=e56b405656593a0c97e478513051ea0e \
file://LICENCE.agere;md5=af0133de6b4a9b2522defd5f188afd31 \
file://LICENCE.rtlwifi_firmware.txt;md5=00d06cfd3eddd5a2698948ead2ad54a5 \
file://LICENCE.broadcom_bcm43xx;md5=3160c14df7228891b868060e1951dfbc \
+ file://LICENCE.ti-connectivity;md5=186e7a43cf6c274283ad81272ca218ea \
file://LICENCE.atheros_firmware;md5=30a14c7823beedac9fa39c64fdd01a13 \
file://LICENCE.via_vt6656;md5=e4159694cba42d4377a912e78a6e850f \
"
@@ -98,6 +99,7 @@ FILES_${PN}-rtl8192su = " \
/lib/firmware/rtlwifi/rtl8712u.bin \
"
+LICENSE_${PN}-wl12xx = "Firmware-ti-connectivity"
FILES_${PN}-wl12xx = " \
/lib/firmware/wl12* \
/lib/firmware/TI* \
--
1.8.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] linux-firmware: Use the included Makefile for install
2013-03-23 20:30 [PATCH 1/4] linux-firmware: Use the included Makefile for install Otavio Salvador
` (2 preceding siblings ...)
2013-03-23 20:31 ` [PATCH 4/4] linux-firmware: Add missing license information for wl12xx Otavio Salvador
@ 2013-03-23 21:21 ` Khem Raj
2013-03-23 22:12 ` Otavio Salvador
3 siblings, 1 reply; 12+ messages in thread
From: Khem Raj @ 2013-03-23 21:21 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
[-- Attachment #1: Type: text/plain, Size: 2830 bytes --]
On Saturday, March 23, 2013, Otavio Salvador <otavio@ossystems.com.br>
wrote:
> This uses the install procedure included in the Makefile which avoids
> code dupplication.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> .../linux-firmware/linux-firmware/makefile-fix.patch | 19
+++++++++++++++++++
> .../linux-firmware/linux-firmware_git.bb | 6 +++---
> 2 files changed, 22 insertions(+), 3 deletions(-)
> create mode 100644
meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
>
> diff --git
a/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
> new file mode 100644
> index 0000000..8a23284
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
> @@ -0,0 +1,19 @@
> +build: Avoid use of bashism and Makefile deployment
> +
> +Upstream-Status: Submitted
> +
> +Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> +
> +diff --git a/Makefile b/Makefile
> +index 321a4e2..9bdeef0 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -9,4 +9,7 @@ install:
> + mkdir -p $(DESTDIR)$(FIRMWAREDIR)
> + cp -r * $(DESTDIR)$(FIRMWAREDIR)
> + rm -f $(DESTDIR)/usbdux/*dux $(DESTDIR)/*/*.asm
> +- rm $(DESTDIR)$(FIRMWAREDIR)/{WHENCE,LICENSE.*,LICENCE.*}
> ++ rm $(DESTDIR)$(FIRMWAREDIR)/Makefile
> ++ rm $(DESTDIR)$(FIRMWAREDIR)/WHENCE
> ++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENSE.*
> ++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENCE.*
Can you explain this change ?
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bbb/meta/recipes-kernel/linux-firmware/
linux-firmware_git.bb
> index b9e00fc..6842738 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -24,7 +24,8 @@ SRCREV = "c530a75c1e6a472b0eb9558310b518f0dfcd8860"
> PE = "1"
> PV = "0.0+git${SRCPV}"
>
> -SRC_URI = "git://
git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git;protocol=git
"
> +SRC_URI = "git://
git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git;protocol=git\
> + file://makefile-fix.patch"
>
> S = "${WORKDIR}/git"
>
> @@ -35,8 +36,7 @@ do_compile() {
> }
>
> do_install() {
> - install -d ${D}/lib/firmware/
> - cp -r * ${D}/lib/firmware/
> + oe_runmake install DESTDIR=${D}
>
> # Libertas sd8686
> ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
> --
> 1.8.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 4046 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
@ 2013-03-23 21:23 ` Khem Raj
2013-03-23 22:13 ` Otavio Salvador
2013-03-24 15:01 ` Eric Bénard
1 sibling, 1 reply; 12+ messages in thread
From: Khem Raj @ 2013-03-23 21:23 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
[-- Attachment #1: Type: text/plain, Size: 3248 bytes --]
Should they be packaged elsewhere
On Saturday, March 23, 2013, Otavio Salvador <otavio@ossystems.com.br>
wrote:
> We don't ship license files with packages and firmware packages are no
> different; drop them.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bbb/meta/recipes-kernel/linux-firmware/
linux-firmware_git.bb
> index 6842738..99c226c 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -42,9 +42,6 @@ do_install() {
> ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
> ln -sf libertas/sd8686_v9_helper.bin
${D}/lib/firmware/sd8686_helper.bin
>
> - # Realtek rtl8192*
> - install -m 0644 LICENCE.rtlwifi_firmware.txt
${D}/lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt
> -
> # fixup wl12xx location, after 2.6.37 the kernel searches a
different location for it
> ( cd ${D}/lib/firmware ; ln -sf ti-connectivity/* . )
> }
> @@ -56,20 +53,17 @@ PACKAGES =+ "${PN}-ralink ${PN}-sd8686
${PN}-rtl8192cu \
> LICENSE_${PN}-ralink = "Firmware-ralink"
> FILES_${PN}-ralink = " \
> /lib/firmware/rt*.bin \
> - /lib/firmware/LICENSE.ralink_firmware.txt \
> "
>
> LICENSE_${PN}-sd8686 = "Firmware-libertas"
> FILES_${PN}-sd8686 = " \
> /lib/firmware/libertas/sd8686_v9* \
> /lib/firmware/sd8686* \
> - /lib/firmware/LICENCE.libertas \
> "
>
> LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi"
> FILES_${PN}-rtl8192cu = " \
> /lib/firmware/rtlwifi/rtl8192cufw.bin \
> - /lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt \
> "
>
> LICENSE_${PN}-rtl8192ce = "Firmware-rtlwifi"
> @@ -97,7 +91,6 @@ ALTERNATIVE_LINK_NAME[brcmfmac-sdio.bin] =
"/lib/firmware/brcm/brcmfmac-sdio.bin
> LICENSE_${PN}-bcm4329 = "Firmware-bcm4329"
> FILES_${PN}-bcm4329 = " \
> /lib/firmware/brcm/brcmfmac4329.bin \
> - /lib/firmware/LICENCE.broadcom_bcm43xx \
> "
> ALTERNATIVE_linux-firmware-bcm4329 = "brcmfmac-sdio.bin"
> ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] =
"/lib/firmware/brcm/brcmfmac4329.bin"
> @@ -105,7 +98,6 @@
ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] =
"/lib/firmware/br
> LICENSE_${PN}-bcm4330 = "Firmware-bcm4330"
> FILES_${PN}-bcm4330 = " \
> /lib/firmware/brcm/brcmfmac4330.bin \
> - /lib/firmware/LICENCE.broadcom_bcm43xx \
> "
>
> ALTERNATIVE_linux-firmware-bcm4330 = "brcmfmac-sdio.bin"
> @@ -114,7 +106,6 @@
ALTERNATIVE_TARGET_linux-firmware-bcm4330[brcmfmac-sdio.bin] =
"/lib/firmware/br
> LICENSE_${PN}-bcm4334 = "Firmware-bcm4334"
> FILES_${PN}-bcm4334 = " \
> /lib/firmware/brcm/brcmfmac4334.bin \
> - /lib/firmware/LICENCE.broadcom_bcm43xx \
> "
>
> ALTERNATIVE_linux-firmware-bcm4334 = "brcmfmac-sdio.bin"
> --
> 1.8.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 4377 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] linux-firmware: Use the included Makefile for install
2013-03-23 21:21 ` [PATCH 1/4] linux-firmware: Use the included Makefile for install Khem Raj
@ 2013-03-23 22:12 ` Otavio Salvador
0 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 22:12 UTC (permalink / raw)
To: Khem Raj; +Cc: OpenEmbedded Core Mailing List
On Sat, Mar 23, 2013 at 6:21 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
>
> On Saturday, March 23, 2013, Otavio Salvador <otavio@ossystems.com.br>
> wrote:
>> This uses the install procedure included in the Makefile which avoids
>> code dupplication.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> .../linux-firmware/linux-firmware/makefile-fix.patch | 19
>> +++++++++++++++++++
>> .../linux-firmware/linux-firmware_git.bb | 6 +++---
>> 2 files changed, 22 insertions(+), 3 deletions(-)
>> create mode 100644
>> meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
>>
>> diff --git
>> a/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
>> b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
>> new file mode 100644
>> index 0000000..8a23284
>> --- /dev/null
>> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware/makefile-fix.patch
>> @@ -0,0 +1,19 @@
>> +build: Avoid use of bashism and Makefile deployment
>> +
>> +Upstream-Status: Submitted
>> +
>> +Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> +
>> +diff --git a/Makefile b/Makefile
>> +index 321a4e2..9bdeef0 100644
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -9,4 +9,7 @@ install:
>> + mkdir -p $(DESTDIR)$(FIRMWAREDIR)
>> + cp -r * $(DESTDIR)$(FIRMWAREDIR)
>> + rm -f $(DESTDIR)/usbdux/*dux $(DESTDIR)/*/*.asm
>> +- rm $(DESTDIR)$(FIRMWAREDIR)/{WHENCE,LICENSE.*,LICENCE.*}
>> ++ rm $(DESTDIR)$(FIRMWAREDIR)/Makefile
>> ++ rm $(DESTDIR)$(FIRMWAREDIR)/WHENCE
>> ++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENSE.*
>> ++ rm $(DESTDIR)$(FIRMWAREDIR)/LICENCE.*
>
> Can you explain this change ?
From the patch file; I sent it to upstream already
+build: Avoid use of bashism and Makefile deployment
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-23 21:23 ` Khem Raj
@ 2013-03-23 22:13 ` Otavio Salvador
0 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-03-23 22:13 UTC (permalink / raw)
To: Khem Raj; +Cc: OpenEmbedded Core Mailing List
On Sat, Mar 23, 2013 at 6:23 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Should they be packaged elsewhere
It may come in the package license but this not at my control and I
think it is being done already. Not in binaries for rootfs.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
2013-03-23 21:23 ` Khem Raj
@ 2013-03-24 15:01 ` Eric Bénard
2013-03-24 15:42 ` Otavio Salvador
1 sibling, 1 reply; 12+ messages in thread
From: Eric Bénard @ 2013-03-24 15:01 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
Hi Otavio,
Le Sat, 23 Mar 2013 17:30:58 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :
> We don't ship license files with packages and firmware packages are no
> different; drop them.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
there may be a good reason to distribute the license files together with
the firmware's binairies : it's often requested by the firmware's
license.
For example in bcm43xx
2. Restrictions. Licensee shall distribute Software with a copy
of this Agreement.
Best regards,
Eric
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-24 15:01 ` Eric Bénard
@ 2013-03-24 15:42 ` Otavio Salvador
2013-03-24 16:55 ` John Weber
0 siblings, 1 reply; 12+ messages in thread
From: Otavio Salvador @ 2013-03-24 15:42 UTC (permalink / raw)
To: Eric Bénard; +Cc: OpenEmbedded Core Mailing List
On Sun, Mar 24, 2013 at 12:01 PM, Eric Bénard <eric@eukrea.com> wrote:
> Hi Otavio,
>
> Le Sat, 23 Mar 2013 17:30:58 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>> We don't ship license files with packages and firmware packages are no
>> different; drop them.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> there may be a good reason to distribute the license files together with
> the firmware's binairies : it's often requested by the firmware's
> license.
>
> For example in bcm43xx
> 2. Restrictions. Licensee shall distribute Software with a copy
> of this Agreement.
In this case we'll need to have a -license package for each license as
we often have more than one fw covered by same license. I'd like to
someone to comment on this so I can send a patch to fix it.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-24 15:42 ` Otavio Salvador
@ 2013-03-24 16:55 ` John Weber
2013-03-24 17:52 ` Eric Bénard
0 siblings, 1 reply; 12+ messages in thread
From: John Weber @ 2013-03-24 16:55 UTC (permalink / raw)
To: openembedded-core
Showing my ignorance here, but is a manifest created with all of the packaged
licenses? Is it possible for the developer to ship that if they see fit?
I think what Otavio was trying to do was to keep /lib/firmware from being
cluttered with license files. At least, that is the benefit as I see it.
On 3/24/13 10:42 AM, Otavio Salvador wrote:
> On Sun, Mar 24, 2013 at 12:01 PM, Eric Bénard <eric@eukrea.com> wrote:
>> Hi Otavio,
>>
>> Le Sat, 23 Mar 2013 17:30:58 -0300,
>> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>>> We don't ship license files with packages and firmware packages are no
>>> different; drop them.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>
>> there may be a good reason to distribute the license files together with
>> the firmware's binairies : it's often requested by the firmware's
>> license.
>>
>> For example in bcm43xx
>> 2. Restrictions. Licensee shall distribute Software with a copy
>> of this Agreement.
>
> In this case we'll need to have a -license package for each license as
> we often have more than one fw covered by same license. I'd like to
> someone to comment on this so I can send a patch to fix it.
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] linux-firmware: Do not deploy license files in packages
2013-03-24 16:55 ` John Weber
@ 2013-03-24 17:52 ` Eric Bénard
0 siblings, 0 replies; 12+ messages in thread
From: Eric Bénard @ 2013-03-24 17:52 UTC (permalink / raw)
To: John Weber; +Cc: openembedded-core
Le Sun, 24 Mar 2013 11:55:09 -0500,
John Weber <rjohnweber@gmail.com> a écrit :
> Showing my ignorance here, but is a manifest created with all of the packaged
> licenses? Is it possible for the developer to ship that if they see fit?
>
> I think what Otavio was trying to do was to keep /lib/firmware from being
> cluttered with license files. At least, that is the benefit as I see it.
>
I see the benefit, I was just giving a reason why the initial recipe
writer may have wanted to include the license files in the packages
together with the binaries of the firmwares.
Eric
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-03-24 18:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-23 20:30 [PATCH 1/4] linux-firmware: Use the included Makefile for install Otavio Salvador
2013-03-23 20:30 ` [PATCH 2/4] linux-firmware: Do not deploy license files in packages Otavio Salvador
2013-03-23 21:23 ` Khem Raj
2013-03-23 22:13 ` Otavio Salvador
2013-03-24 15:01 ` Eric Bénard
2013-03-24 15:42 ` Otavio Salvador
2013-03-24 16:55 ` John Weber
2013-03-24 17:52 ` Eric Bénard
2013-03-23 20:30 ` [PATCH 3/4] linux-firmware: Package vt6656, ath6k, ath9k and ar9170 Otavio Salvador
2013-03-23 20:31 ` [PATCH 4/4] linux-firmware: Add missing license information for wl12xx Otavio Salvador
2013-03-23 21:21 ` [PATCH 1/4] linux-firmware: Use the included Makefile for install Khem Raj
2013-03-23 22:12 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.