* [PATCH] ARM: l2x0: don't set .set_debug in l310 case
@ 2013-03-24 18:27 ` Paolo Pisati
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Pisati @ 2013-03-24 18:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Paolo Pisati <paolo.pisati@canonical.com>
commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
to actually work needs .set_debug to be not set during definition
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
---
arch/arm/mm/cache-l2x0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index d457653..37f1364 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
.flush_all = l2x0_flush_all,
.inv_all = l2x0_inv_all,
.disable = l2x0_disable,
- .set_debug = pl310_set_debug,
},
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/7] ARM: l2x0: don't set .set_debug in l310 case
2013-03-24 18:27 ` Paolo Pisati
@ 2013-03-24 20:29 ` Paolo Pisati
-1 siblings, 0 replies; 10+ messages in thread
From: Paolo Pisati @ 2013-03-24 20:29 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Russell King, Gregory CLEMENT, Will Deacon, Jason Cooper,
Rob Herring, linux-kernel, Paolo Pisati
commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
to actually work needs .set_debug to be not set during definition
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
arch/arm/mm/cache-l2x0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index d457653..37f1364 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
.flush_all = l2x0_flush_all,
.inv_all = l2x0_inv_all,
.disable = l2x0_disable,
- .set_debug = pl310_set_debug,
},
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/7] ARM: l2x0: don't set .set_debug in l310 case
@ 2013-03-24 20:29 ` Paolo Pisati
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Pisati @ 2013-03-24 20:29 UTC (permalink / raw)
To: linux-arm-kernel
commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
to actually work needs .set_debug to be not set during definition
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
arch/arm/mm/cache-l2x0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index d457653..37f1364 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
.flush_all = l2x0_flush_all,
.inv_all = l2x0_inv_all,
.disable = l2x0_disable,
- .set_debug = pl310_set_debug,
},
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: l2x0: don't set .set_debug in l310 case
2013-03-24 18:27 ` Paolo Pisati
@ 2013-03-24 21:14 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2013-03-24 21:14 UTC (permalink / raw)
To: Paolo Pisati
Cc: linux-arm-kernel, Russell King, Jason Cooper, Will Deacon,
linux-kernel, Rob Herring, Gregory CLEMENT
On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> From: Paolo Pisati <paolo.pisati@canonical.com>
>
> commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> to actually work needs .set_debug to be not set during definition
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
Ah crap, missed this part. Can I add this into my fix and I'll put it in
Russell's patch system.
Rob
> ---
> arch/arm/mm/cache-l2x0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index d457653..37f1364 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
> .flush_all = l2x0_flush_all,
> .inv_all = l2x0_inv_all,
> .disable = l2x0_disable,
> - .set_debug = pl310_set_debug,
> },
> };
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: l2x0: don't set .set_debug in l310 case
@ 2013-03-24 21:14 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2013-03-24 21:14 UTC (permalink / raw)
To: linux-arm-kernel
On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> From: Paolo Pisati <paolo.pisati@canonical.com>
>
> commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> to actually work needs .set_debug to be not set during definition
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
Ah crap, missed this part. Can I add this into my fix and I'll put it in
Russell's patch system.
Rob
> ---
> arch/arm/mm/cache-l2x0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index d457653..37f1364 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
> .flush_all = l2x0_flush_all,
> .inv_all = l2x0_inv_all,
> .disable = l2x0_disable,
> - .set_debug = pl310_set_debug,
> },
> };
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ARM: l2x0: don't set .set_debug in l310 case
2013-03-24 21:14 ` Rob Herring
@ 2013-03-25 10:30 ` Paolo Pisati
-1 siblings, 0 replies; 10+ messages in thread
From: Paolo Pisati @ 2013-03-25 10:30 UTC (permalink / raw)
To: Rob Herring
Cc: Paolo Pisati, linux-arm-kernel, Russell King, Jason Cooper,
Will Deacon, linux-kernel, Rob Herring, Gregory CLEMENT
On Sun, Mar 24, 2013 at 04:14:57PM -0500, Rob Herring wrote:
> On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> > From: Paolo Pisati <paolo.pisati@canonical.com>
> >
> > commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> > to actually work needs .set_debug to be not set during definition
> >
> > Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
>
> Ah crap, missed this part. Can I add this into my fix and I'll put it in
> Russell's patch system.
Of course, go ahead.
--
bye,
p.
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: l2x0: don't set .set_debug in l310 case
@ 2013-03-25 10:30 ` Paolo Pisati
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Pisati @ 2013-03-25 10:30 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Mar 24, 2013 at 04:14:57PM -0500, Rob Herring wrote:
> On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> > From: Paolo Pisati <paolo.pisati@canonical.com>
> >
> > commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> > to actually work needs .set_debug to be not set during definition
> >
> > Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
>
> Ah crap, missed this part. Can I add this into my fix and I'll put it in
> Russell's patch system.
Of course, go ahead.
--
bye,
p.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: l2x0: don't set .set_debug in l310 case
2013-03-24 18:27 ` Paolo Pisati
@ 2013-03-25 15:07 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2013-03-25 15:07 UTC (permalink / raw)
To: Paolo Pisati
Cc: linux-arm-kernel, Russell King, Jason Cooper, Will Deacon,
linux-kernel, Rob Herring, Gregory CLEMENT
On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> From: Paolo Pisati <paolo.pisati@canonical.com>
>
> commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> to actually work needs .set_debug to be not set during definition
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
> ---
> arch/arm/mm/cache-l2x0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index d457653..37f1364 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
> .flush_all = l2x0_flush_all,
> .inv_all = l2x0_inv_all,
> .disable = l2x0_disable,
> - .set_debug = pl310_set_debug,
This actually breaks the cases that need set_debug because the memcpy of
the function pointers is after the set_debug init. So I'll come up with
something else.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: l2x0: don't set .set_debug in l310 case
@ 2013-03-25 15:07 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2013-03-25 15:07 UTC (permalink / raw)
To: linux-arm-kernel
On 03/24/2013 01:27 PM, Paolo Pisati wrote:
> From: Paolo Pisati <paolo.pisati@canonical.com>
>
> commit 74ddcdb ("l2x0: Only set .set_debug on PL310 r3p0 and earlier")
> to actually work needs .set_debug to be not set during definition
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
> ---
> arch/arm/mm/cache-l2x0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index d457653..37f1364 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -724,7 +724,6 @@ static const struct l2x0_of_data pl310_data = {
> .flush_all = l2x0_flush_all,
> .inv_all = l2x0_inv_all,
> .disable = l2x0_disable,
> - .set_debug = pl310_set_debug,
This actually breaks the cases that need set_debug because the memcpy of
the function pointers is after the set_debug init. So I'll come up with
something else.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread