From: Will Deacon <will.deacon@arm.com> To: Michael Cree <mcree@orcon.net.nz> Cc: "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com> Subject: Re: [PATCH] alpha: makefile: don't enforce small data model for kernel builds Date: Mon, 25 Mar 2013 13:37:11 +0000 [thread overview] Message-ID: <20130325133710.GD14280@mudshark.cambridge.arm.com> (raw) In-Reply-To: <BFB01C0A-95E5-4C2B-8AF2-A06BE1FF74E0@orcon.net.nz> On Mon, Mar 18, 2013 at 04:11:15AM +0000, Michael Cree wrote: > On 18/03/2013, at 10:48 AM, Will Deacon wrote: > > Due to all of the goodness being packed into today's kernels, the > > resulting image isn't as slim as it once was. > > > > In light of this, don't pass -msmall-data to the tools, which > > results in > > link failures due to impossible relocations when compiling anything > > but > > the most trivial configurations. > > I think many of us have been using -mlarge-data when compiling with > gcc-4.6 or later so maybe it is time to get the change upstream. > > The interesting thing is that the kernel still compiles fine with > gcc-4.5 and the relocation errors only appear if compiling with > gcc-4.6 or later. I had asked before on this forum what had changed > with gcc-4.6 that results in the extra usage of the small data area > but never got an answer. I am still curious to know. > > BTW, the phrase "to the tools" in the commit message makes me think > immediately of the tools directory (containing perf, etc.) which is > not what is intended. > > Matt: Are you able to collect up this and the other patches of Will > and get them sent to Linus? Any news on these? I've included an updated version of the first patch, with the Tested-by-tag and a tweaked commit message below. Will --->8 >From 8cbd016322bb01593795ec76cbdcbb52ac010203 Mon Sep 17 00:00:00 2001 From: Will Deacon <will.deacon@arm.com> Date: Mon, 4 Mar 2013 04:46:44 +0000 Subject: [PATCH] alpha: makefile: don't enforce small data model for kernel builds Due to all of the goodness being packed into today's kernels, the resulting image isn't as slim as it once was. In light of this, don't pass -msmall-data to gcc, which otherwise results in link failures due to impossible relocations when compiling anything but the most trivial configurations. Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Matt Turner <mattst88@gmail.com> Tested-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de> Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/alpha/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/Makefile b/arch/alpha/Makefile index 4759fe7..2cc3cc5 100644 --- a/arch/alpha/Makefile +++ b/arch/alpha/Makefile @@ -12,7 +12,7 @@ NM := $(NM) -B LDFLAGS_vmlinux := -static -N #-relax CHECKFLAGS += -D__alpha__ -m64 -cflags-y := -pipe -mno-fp-regs -ffixed-8 -msmall-data +cflags-y := -pipe -mno-fp-regs -ffixed-8 cflags-y += $(call cc-option, -fno-jump-tables) cpuflags-$(CONFIG_ALPHA_EV4) := -mcpu=ev4 -- 1.8.0
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com> To: Michael Cree <mcree@orcon.net.nz> Cc: "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com> Subject: Re: [PATCH] alpha: makefile: don't enforce small data model for kernel builds Date: Mon, 25 Mar 2013 13:37:11 +0000 [thread overview] Message-ID: <20130325133710.GD14280@mudshark.cambridge.arm.com> (raw) In-Reply-To: <BFB01C0A-95E5-4C2B-8AF2-A06BE1FF74E0@orcon.net.nz> On Mon, Mar 18, 2013 at 04:11:15AM +0000, Michael Cree wrote: > On 18/03/2013, at 10:48 AM, Will Deacon wrote: > > Due to all of the goodness being packed into today's kernels, the > > resulting image isn't as slim as it once was. > > > > In light of this, don't pass -msmall-data to the tools, which > > results in > > link failures due to impossible relocations when compiling anything > > but > > the most trivial configurations. > > I think many of us have been using -mlarge-data when compiling with > gcc-4.6 or later so maybe it is time to get the change upstream. > > The interesting thing is that the kernel still compiles fine with > gcc-4.5 and the relocation errors only appear if compiling with > gcc-4.6 or later. I had asked before on this forum what had changed > with gcc-4.6 that results in the extra usage of the small data area > but never got an answer. I am still curious to know. > > BTW, the phrase "to the tools" in the commit message makes me think > immediately of the tools directory (containing perf, etc.) which is > not what is intended. > > Matt: Are you able to collect up this and the other patches of Will > and get them sent to Linus? Any news on these? I've included an updated version of the first patch, with the Tested-by-tag and a tweaked commit message below. Will --->8 From 8cbd016322bb01593795ec76cbdcbb52ac010203 Mon Sep 17 00:00:00 2001 From: Will Deacon <will.deacon@arm.com> Date: Mon, 4 Mar 2013 04:46:44 +0000 Subject: [PATCH] alpha: makefile: don't enforce small data model for kernel builds Due to all of the goodness being packed into today's kernels, the resulting image isn't as slim as it once was. In light of this, don't pass -msmall-data to gcc, which otherwise results in link failures due to impossible relocations when compiling anything but the most trivial configurations. Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Matt Turner <mattst88@gmail.com> Tested-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de> Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/alpha/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/Makefile b/arch/alpha/Makefile index 4759fe7..2cc3cc5 100644 --- a/arch/alpha/Makefile +++ b/arch/alpha/Makefile @@ -12,7 +12,7 @@ NM := $(NM) -B LDFLAGS_vmlinux := -static -N #-relax CHECKFLAGS += -D__alpha__ -m64 -cflags-y := -pipe -mno-fp-regs -ffixed-8 -msmall-data +cflags-y := -pipe -mno-fp-regs -ffixed-8 cflags-y += $(call cc-option, -fno-jump-tables) cpuflags-$(CONFIG_ALPHA_EV4) := -mcpu=ev4 -- 1.8.0
next prev parent reply other threads:[~2013-03-25 13:37 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-17 21:48 [PATCH] alpha: makefile: don't enforce small data model for kernel builds Will Deacon 2013-03-18 4:11 ` Michael Cree 2013-03-25 13:37 ` Will Deacon [this message] 2013-03-25 13:37 ` Will Deacon 2013-03-25 15:09 ` Tobias Klausmann 2013-03-25 20:06 ` Michael Cree 2013-03-25 20:55 ` Matt Turner 2013-03-26 1:52 ` Rob Landley 2013-03-27 17:56 ` Tobias Klausmann 2013-03-28 10:25 ` Tobias Klausmann 2013-04-03 18:02 ` Will Deacon 2013-03-18 18:18 ` Thorsten Kranzkowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130325133710.GD14280@mudshark.cambridge.arm.com \ --to=will.deacon@arm.com \ --cc=ink@jurassic.park.msu.ru \ --cc=linux-alpha@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mattst88@gmail.com \ --cc=mcree@orcon.net.nz \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.