From: Michal Hocko <mhocko@suse.cz> To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() Date: Tue, 26 Mar 2013 10:49:50 +0100 [thread overview] Message-ID: <20130326094950.GM2295@dhcp22.suse.cz> (raw) In-Reply-To: <1364272480-bmzkqzs6-mutt-n-horiguchi@ah.jp.nec.com> On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: > On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: > > On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: [...] > > > @@ -1482,12 +1483,20 @@ static int soft_offline_huge_page(struct page *page, int flags) > > > unlock_page(hpage); > > > > > > /* Keep page count to indicate a given hugepage is isolated. */ > > > - ret = migrate_huge_page(hpage, new_page, MPOL_MF_MOVE_ALL, > > > - MIGRATE_SYNC); > > > - put_page(hpage); > > > + list_move(&hpage->lru, &pagelist); > > > + ret = migrate_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL, > > > + MIGRATE_SYNC, MR_MEMORY_FAILURE); > > > if (ret) { > > > pr_info("soft offline: %#lx: migration failed %d, type %lx\n", > > > pfn, ret, page->flags); > > > + /* > > > + * We know that soft_offline_huge_page() tries to migrate > > > + * only one hugepage pointed to by hpage, so we need not > > > + * run through the pagelist here. > > > + */ > > > + putback_active_hugepage(hpage); > > > > Maybe I am missing something but why we didn't need to call this before > > when using migrate_huge_page? > > migrate_huge_page() does not need list handling before/after the call, > because it's defined to migrate only one hugepage, and it has a page as > an argument, not list_head. I do not understand this reasoning. migrate_huge_page calls unmap_and_move_huge_page and migrate_pages does the same + accounting. So what is the difference here? I suspect that putback_active_hugepage was simply missing in this code path. > > > + if (ret > 0) > > > + ret = -EIO; > > > } else { > > > set_page_hwpoison_huge_page(hpage); > > > dequeue_hwpoisoned_huge_page(hpage); > > > diff --git v3.9-rc3.orig/mm/migrate.c v3.9-rc3/mm/migrate.c > > > index f69f354..66030b6 100644 > > > --- v3.9-rc3.orig/mm/migrate.c > > > +++ v3.9-rc3/mm/migrate.c > > > @@ -981,6 +981,8 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > > > > > > unlock_page(hpage); > > > out: > > > + if (rc != -EAGAIN) > > > + putback_active_hugepage(hpage); > > > > And why do you put it here? If it is called from migrate_pages then the > > caller already does the clean-up (putback_lru_pages). > > What the caller of migrate_pages() cleans up is the (huge)pages which failed > to be migrated. And what the above code cleans up is the source hugepage > after the migration succeeds. Why should you want to add successfully migrated page? /me confused. -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz> To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() Date: Tue, 26 Mar 2013 10:49:50 +0100 [thread overview] Message-ID: <20130326094950.GM2295@dhcp22.suse.cz> (raw) In-Reply-To: <1364272480-bmzkqzs6-mutt-n-horiguchi@ah.jp.nec.com> On Tue 26-03-13 00:34:40, Naoya Horiguchi wrote: > On Mon, Mar 25, 2013 at 01:31:28PM +0100, Michal Hocko wrote: > > On Fri 22-03-13 16:23:48, Naoya Horiguchi wrote: [...] > > > @@ -1482,12 +1483,20 @@ static int soft_offline_huge_page(struct page *page, int flags) > > > unlock_page(hpage); > > > > > > /* Keep page count to indicate a given hugepage is isolated. */ > > > - ret = migrate_huge_page(hpage, new_page, MPOL_MF_MOVE_ALL, > > > - MIGRATE_SYNC); > > > - put_page(hpage); > > > + list_move(&hpage->lru, &pagelist); > > > + ret = migrate_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL, > > > + MIGRATE_SYNC, MR_MEMORY_FAILURE); > > > if (ret) { > > > pr_info("soft offline: %#lx: migration failed %d, type %lx\n", > > > pfn, ret, page->flags); > > > + /* > > > + * We know that soft_offline_huge_page() tries to migrate > > > + * only one hugepage pointed to by hpage, so we need not > > > + * run through the pagelist here. > > > + */ > > > + putback_active_hugepage(hpage); > > > > Maybe I am missing something but why we didn't need to call this before > > when using migrate_huge_page? > > migrate_huge_page() does not need list handling before/after the call, > because it's defined to migrate only one hugepage, and it has a page as > an argument, not list_head. I do not understand this reasoning. migrate_huge_page calls unmap_and_move_huge_page and migrate_pages does the same + accounting. So what is the difference here? I suspect that putback_active_hugepage was simply missing in this code path. > > > + if (ret > 0) > > > + ret = -EIO; > > > } else { > > > set_page_hwpoison_huge_page(hpage); > > > dequeue_hwpoisoned_huge_page(hpage); > > > diff --git v3.9-rc3.orig/mm/migrate.c v3.9-rc3/mm/migrate.c > > > index f69f354..66030b6 100644 > > > --- v3.9-rc3.orig/mm/migrate.c > > > +++ v3.9-rc3/mm/migrate.c > > > @@ -981,6 +981,8 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > > > > > > unlock_page(hpage); > > > out: > > > + if (rc != -EAGAIN) > > > + putback_active_hugepage(hpage); > > > > And why do you put it here? If it is called from migrate_pages then the > > caller already does the clean-up (putback_lru_pages). > > What the caller of migrate_pages() cleans up is the (huge)pages which failed > to be migrated. And what the above code cleans up is the source hugepage > after the migration succeeds. Why should you want to add successfully migrated page? /me confused. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-26 9:49 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-22 20:23 [PATCH v2 0/10] extend hugepage migration Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 01/10] migrate: add migrate_entry_wait_huge() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-23 15:55 ` Rik van Riel 2013-03-23 15:55 ` Rik van Riel 2013-03-25 10:13 ` Michal Hocko 2013-03-25 10:13 ` Michal Hocko 2013-03-26 4:25 ` Naoya Horiguchi 2013-03-26 4:25 ` Naoya Horiguchi 2013-04-05 20:33 ` KOSAKI Motohiro 2013-04-05 20:33 ` KOSAKI Motohiro 2013-04-08 20:00 ` Naoya Horiguchi 2013-04-08 20:00 ` Naoya Horiguchi 2013-04-05 20:33 ` KOSAKI Motohiro 2013-04-05 20:33 ` KOSAKI Motohiro 2013-03-22 20:23 ` [PATCH 02/10] migrate: make core migration code aware of hugepage Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 10:57 ` Michal Hocko 2013-03-25 10:57 ` Michal Hocko 2013-03-26 4:33 ` Naoya Horiguchi 2013-03-26 4:33 ` Naoya Horiguchi 2013-03-26 8:49 ` Michal Hocko 2013-03-26 8:49 ` Michal Hocko 2013-04-05 20:41 ` KOSAKI Motohiro 2013-04-05 20:41 ` KOSAKI Motohiro 2013-03-22 20:23 ` [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 12:31 ` Michal Hocko 2013-03-25 12:31 ` Michal Hocko 2013-03-26 4:34 ` Naoya Horiguchi 2013-03-26 4:34 ` Naoya Horiguchi 2013-03-26 9:49 ` Michal Hocko [this message] 2013-03-26 9:49 ` Michal Hocko 2013-03-26 20:35 ` Naoya Horiguchi 2013-03-26 20:35 ` Naoya Horiguchi 2013-03-27 13:00 ` Michal Hocko 2013-03-27 13:00 ` Michal Hocko 2013-04-05 21:11 ` KOSAKI Motohiro 2013-04-05 21:11 ` KOSAKI Motohiro 2013-03-26 11:29 ` Aneesh Kumar K.V 2013-03-26 11:29 ` Aneesh Kumar K.V 2013-03-27 13:52 ` Michal Hocko 2013-03-27 13:52 ` Michal Hocko 2013-03-27 19:19 ` Naoya Horiguchi 2013-03-27 19:19 ` Naoya Horiguchi 2013-03-28 8:53 ` Michal Hocko 2013-03-28 8:53 ` Michal Hocko 2013-03-29 5:26 ` Aneesh Kumar K.V 2013-03-29 5:26 ` Aneesh Kumar K.V 2013-03-29 9:36 ` Michal Hocko 2013-03-29 9:36 ` Michal Hocko 2013-04-01 5:13 ` Aneesh Kumar K.V 2013-04-01 5:13 ` Aneesh Kumar K.V 2013-04-02 9:45 ` Michal Hocko 2013-04-02 9:45 ` Michal Hocko 2013-03-22 20:23 ` [PATCH 04/10] migrate: clean up migrate_huge_page() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-04-05 21:13 ` KOSAKI Motohiro 2013-04-05 21:13 ` KOSAKI Motohiro 2013-03-22 20:23 ` [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 13:04 ` Michal Hocko 2013-03-25 13:04 ` Michal Hocko 2013-03-26 5:13 ` Naoya Horiguchi 2013-03-26 5:13 ` Naoya Horiguchi 2013-03-26 8:55 ` Michal Hocko 2013-03-26 8:55 ` Michal Hocko 2013-04-05 21:17 ` KOSAKI Motohiro 2013-04-05 21:17 ` KOSAKI Motohiro 2013-04-08 20:21 ` Naoya Horiguchi 2013-04-08 20:21 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 06/10] migrate: add hugepage migration code to move_pages() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 13:36 ` Michal Hocko 2013-03-25 13:36 ` Michal Hocko 2013-03-26 7:06 ` Naoya Horiguchi 2013-03-26 7:06 ` Naoya Horiguchi 2013-03-26 10:02 ` Michal Hocko 2013-03-26 10:02 ` Michal Hocko 2013-03-26 20:37 ` Naoya Horiguchi 2013-03-26 20:37 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 07/10] mbind: add hugepage migration code to mbind() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 13:49 ` Michal Hocko 2013-03-25 13:49 ` Michal Hocko 2013-04-05 22:23 ` KOSAKI Motohiro 2013-04-05 22:23 ` KOSAKI Motohiro 2013-04-06 7:04 ` Michal Hocko 2013-04-06 7:04 ` Michal Hocko 2013-04-05 22:18 ` KOSAKI Motohiro 2013-04-05 22:18 ` KOSAKI Motohiro 2013-04-08 20:25 ` Naoya Horiguchi 2013-04-08 20:25 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 08/10] migrate: remove VM_HUGETLB from vma flag check in vma_migratable() Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 09/10] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 15:09 ` Michal Hocko 2013-03-25 15:09 ` Michal Hocko 2013-03-26 18:23 ` Naoya Horiguchi 2013-03-26 18:23 ` Naoya Horiguchi 2013-03-27 14:19 ` Michal Hocko 2013-03-27 14:19 ` Michal Hocko 2013-03-27 21:29 ` Naoya Horiguchi 2013-03-27 21:29 ` Naoya Horiguchi 2013-03-27 21:58 ` Naoya Horiguchi 2013-03-27 21:58 ` Naoya Horiguchi 2013-03-27 22:55 ` Michal Hocko 2013-03-27 22:55 ` Michal Hocko 2013-03-26 12:01 ` Aneesh Kumar K.V 2013-03-26 12:01 ` Aneesh Kumar K.V 2013-03-27 19:28 ` Naoya Horiguchi 2013-03-27 19:28 ` Naoya Horiguchi 2013-04-06 0:13 ` KOSAKI Motohiro 2013-04-06 0:13 ` KOSAKI Motohiro 2013-04-09 20:07 ` Naoya Horiguchi 2013-04-09 20:07 ` Naoya Horiguchi 2013-04-09 21:27 ` KOSAKI Motohiro 2013-04-09 21:27 ` KOSAKI Motohiro 2013-04-09 22:43 ` Naoya Horiguchi 2013-04-09 22:43 ` Naoya Horiguchi 2013-04-10 1:56 ` KOSAKI Motohiro 2013-04-10 1:56 ` KOSAKI Motohiro 2013-04-10 2:24 ` Naoya Horiguchi 2013-04-10 2:24 ` Naoya Horiguchi 2013-03-22 20:23 ` [PATCH 10/10] prepare to remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi 2013-03-22 20:23 ` Naoya Horiguchi 2013-03-25 15:12 ` Michal Hocko 2013-03-25 15:12 ` Michal Hocko 2013-04-06 0:15 ` KOSAKI Motohiro 2013-04-06 0:15 ` KOSAKI Motohiro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130326094950.GM2295@dhcp22.suse.cz \ --to=mhocko@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=andi@firstfloor.org \ --cc=dhillf@gmail.com \ --cc=hughd@google.com \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mel@csn.ul.ie \ --cc=n-horiguchi@ah.jp.nec.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.