All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
@ 2013-03-26 13:49 Magnus Damm
  2013-03-27  4:56 ` Simon Horman
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Magnus Damm @ 2013-03-26 13:49 UTC (permalink / raw)
  To: linux-sh

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
[PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
[PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
[PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
[PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
[PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
[PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
[PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
[PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
[PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

This series is V2 of initial PFC support for the r8a73a4 SoC.
The patches add a regular old-style GPIO function controller
and makes it partially converted over to PINCTRL for SCIF
and IRQC that are tied up on the APE6EVM board. The final
patches remove the GPIO function support, so when new drivers
for r8a73a4 are added then PINCTRL support has to be included.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Written against renesas-next-20130321 in renesas.git
 Requires "r8a73a4.h" provided by
  [PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3

 arch/arm/mach-shmobile/include/mach/r8a73a4.h | 1838 +++++-----
 drivers/pinctrl/sh-pfc/Kconfig                |    5 
 drivers/pinctrl/sh-pfc/Makefile               |    1 
 drivers/pinctrl/sh-pfc/core.c                 |    3 
 drivers/pinctrl/sh-pfc/core.h                 |    1 
 drivers/pinctrl/sh-pfc/pfc-r8a73a4.c          | 4592 +++++++++++++++++++------
 6 files changed, 4519 insertions(+), 1921 deletions(-)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
@ 2013-03-27  4:56 ` Simon Horman
  2013-03-27  8:36 ` Laurent Pinchart
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-03-27  4:56 UTC (permalink / raw)
  To: linux-sh

On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> sh-pfc: Initial r8a73a4 PFC support (V2)
> 
> [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> 
> This series is V2 of initial PFC support for the r8a73a4 SoC.
> The patches add a regular old-style GPIO function controller
> and makes it partially converted over to PINCTRL for SCIF
> and IRQC that are tied up on the APE6EVM board. The final
> patches remove the GPIO function support, so when new drivers
> for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere,
but could you let me know a bit about the dependencies for this series.

I am assuming it depends on:

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
[PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it
or should I add it to my tree directly?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
  2013-03-27  4:56 ` Simon Horman
@ 2013-03-27  8:36 ` Laurent Pinchart
  2013-03-27  8:48 ` Magnus Damm
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2013-03-27  8:36 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
> On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> > sh-pfc: Initial r8a73a4 PFC support (V2)
> > 
> > [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> > [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> > [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> > [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> > [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> > [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> > [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> > [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> > [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> > [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> > [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> > [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> > [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> > 
> > This series is V2 of initial PFC support for the r8a73a4 SoC.
> > The patches add a regular old-style GPIO function controller
> > and makes it partially converted over to PINCTRL for SCIF
> > and IRQC that are tied up on the APE6EVM board. The final
> > patches remove the GPIO function support, so when new drivers
> > for r8a73a4 are added then PINCTRL support has to be included.
> 
> Hi Magnus,
> 
> I apologise if the information is obvious or available elsewhere, but could
> you let me know a bit about the dependencies for this series.
> 
> I am assuming it depends on:
> 
> [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779
> 
> Laurent, if/when this series is ready do you want to take it or should I add
> it to my tree directly?

You can add it to your tree directly when it will be ready. I've acked all but 
patches 01/13 and 06/13. I expect Magnus to resubmit 06/13, could you please 
have a look at my comments on the cover letter and tell whether 01/13 should 
be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary 
from the ARM tree point of view ?

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
  2013-03-27  4:56 ` Simon Horman
  2013-03-27  8:36 ` Laurent Pinchart
@ 2013-03-27  8:48 ` Magnus Damm
  2013-03-27 12:15 ` Simon Horman
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Magnus Damm @ 2013-03-27  8:48 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 27, 2013 at 1:56 PM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
>> sh-pfc: Initial r8a73a4 PFC support (V2)
>>
>> [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
>> [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
>> [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
>> [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
>> [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
>> [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
>> [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
>> [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
>> [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
>> [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
>> [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
>> [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
>> [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
>>
>> This series is V2 of initial PFC support for the r8a73a4 SoC.
>> The patches add a regular old-style GPIO function controller
>> and makes it partially converted over to PINCTRL for SCIF
>> and IRQC that are tied up on the APE6EVM board. The final
>> patches remove the GPIO function support, so when new drivers
>> for r8a73a4 are added then PINCTRL support has to be included.
>
> Hi Magnus,
>
> I apologise if the information is obvious or available elsewhere,
> but could you let me know a bit about the dependencies for this series.
>
> I am assuming it depends on:
>
> [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Hi Simon,

Thanks for your email. It looks like you estimated the worst-case
dependencies. =)

Fortunately, for r8a73a4 (APE6) there is no separate GPIO controller.
So regular PFC without any special dependencies is enough. This means
that the r8a7779 patches are not needed for r8a73a4. However, to fully
support r8a7790 (R-Car H2) we need to follow the same pattern as
r8a7779. The automotive SoCs seem to come with a separate GPIO
controller.

So based on that the following patches should be enough for merging:

 Written against renesas-next-20130321 in renesas.git
 Requires "r8a73a4.h" provided by
  [PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3

The above r8a73a4 SoC V3 series also requires the following patch:
[PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB

To actually use this code you also need board code provided by a
separate patch series.

Thanks,

/ magnus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
                   ` (2 preceding siblings ...)
  2013-03-27  8:48 ` Magnus Damm
@ 2013-03-27 12:15 ` Simon Horman
  2013-03-27 12:21 ` Simon Horman
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-03-27 12:15 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 27, 2013 at 05:48:27PM +0900, Magnus Damm wrote:
> On Wed, Mar 27, 2013 at 1:56 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> >> sh-pfc: Initial r8a73a4 PFC support (V2)
> >>
> >> [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> >> [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> >> [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> >> [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> >> [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> >> [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> >> [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> >> [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> >> [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> >> [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> >> [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> >> [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> >> [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> >>
> >> This series is V2 of initial PFC support for the r8a73a4 SoC.
> >> The patches add a regular old-style GPIO function controller
> >> and makes it partially converted over to PINCTRL for SCIF
> >> and IRQC that are tied up on the APE6EVM board. The final
> >> patches remove the GPIO function support, so when new drivers
> >> for r8a73a4 are added then PINCTRL support has to be included.
> >
> > Hi Magnus,
> >
> > I apologise if the information is obvious or available elsewhere,
> > but could you let me know a bit about the dependencies for this series.
> >
> > I am assuming it depends on:
> >
> > [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> > [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779
> 
> Hi Simon,
> 
> Thanks for your email. It looks like you estimated the worst-case
> dependencies. =)
> 
> Fortunately, for r8a73a4 (APE6) there is no separate GPIO controller.
> So regular PFC without any special dependencies is enough. This means
> that the r8a7779 patches are not needed for r8a73a4. However, to fully
> support r8a7790 (R-Car H2) we need to follow the same pattern as
> r8a7779. The automotive SoCs seem to come with a separate GPIO
> controller.
> 
> So based on that the following patches should be enough for merging:
> 
>  Written against renesas-next-20130321 in renesas.git
>  Requires "r8a73a4.h" provided by
>   [PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3
> 
> The above r8a73a4 SoC V3 series also requires the following patch:
> [PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB
> 
> To actually use this code you also need board code provided by a
> separate patch series.

Thanks, got it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
                   ` (3 preceding siblings ...)
  2013-03-27 12:15 ` Simon Horman
@ 2013-03-27 12:21 ` Simon Horman
  2013-03-27 14:12 ` Laurent Pinchart
  2013-03-28  0:54 ` Simon Horman
  6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-03-27 12:21 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 27, 2013 at 09:36:39AM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
> > On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> > > sh-pfc: Initial r8a73a4 PFC support (V2)
> > > 
> > > [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> > > [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> > > [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> > > [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> > > [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> > > [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> > > [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> > > [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> > > [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> > > [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> > > [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> > > [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> > > [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> > > 
> > > This series is V2 of initial PFC support for the r8a73a4 SoC.
> > > The patches add a regular old-style GPIO function controller
> > > and makes it partially converted over to PINCTRL for SCIF
> > > and IRQC that are tied up on the APE6EVM board. The final
> > > patches remove the GPIO function support, so when new drivers
> > > for r8a73a4 are added then PINCTRL support has to be included.
> > 
> > Hi Magnus,
> > 
> > I apologise if the information is obvious or available elsewhere, but could
> > you let me know a bit about the dependencies for this series.
> > 
> > I am assuming it depends on:
> > 
> > [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> > [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779
> > 
> > Laurent, if/when this series is ready do you want to take it or should I add
> > it to my tree directly?
> 
> You can add it to your tree directly when it will be ready. I've acked all but 
> patches 01/13 and 06/13.

Got it. I will hold off for now.

> I expect Magnus to resubmit 06/13, could you please 
> have a look at my comments on the cover letter and tell whether 01/13 should 
> be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary 
> from the ARM tree point of view ?

Unfortunately I seem to be missing the email with your comments
but I think that it is not strictly necessary to split the patch.
Although doing so would allow it to be applied to a separate branch
(soc, most likely) it would also set up a dependency on that branch.
And to be honest, I have enough branch dependencies already.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
                   ` (4 preceding siblings ...)
  2013-03-27 12:21 ` Simon Horman
@ 2013-03-27 14:12 ` Laurent Pinchart
  2013-03-28  0:54 ` Simon Horman
  6 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2013-03-27 14:12 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Wednesday 27 March 2013 21:21:57 Simon Horman wrote:
> On Wed, Mar 27, 2013 at 09:36:39AM +0100, Laurent Pinchart wrote:
> > On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
> > > On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> > > > sh-pfc: Initial r8a73a4 PFC support (V2)
> > > > 
> > > > [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> > > > [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> > > > [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> > > > [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> > > > [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> > > > [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> > > > [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> > > > [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> > > > [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> > > > [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> > > > [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> > > > [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> > > > [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> > > > 
> > > > This series is V2 of initial PFC support for the r8a73a4 SoC.
> > > > The patches add a regular old-style GPIO function controller
> > > > and makes it partially converted over to PINCTRL for SCIF
> > > > and IRQC that are tied up on the APE6EVM board. The final
> > > > patches remove the GPIO function support, so when new drivers
> > > > for r8a73a4 are added then PINCTRL support has to be included.
> > > 
> > > Hi Magnus,
> > > 
> > > I apologise if the information is obvious or available elsewhere, but
> > > could
> > > you let me know a bit about the dependencies for this series.
> > > 
> > > I am assuming it depends on:
> > > 
> > > [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> > > [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779
> > > 
> > > Laurent, if/when this series is ready do you want to take it or should I
> > > add it to my tree directly?
> > 
> > You can add it to your tree directly when it will be ready. I've acked all
> > but patches 01/13 and 06/13.
> 
> Got it. I will hold off for now.
> 
> > I expect Magnus to resubmit 06/13, could you please
> > have a look at my comments on the cover letter and tell whether 01/13
> > should be split in a arch/arm/ patch and a drivers/ patch or if that's
> > unnecessary from the ARM tree point of view ?
> 
> Unfortunately I seem to be missing the email with your comments
> but I think that it is not strictly necessary to split the patch.
> Although doing so would allow it to be applied to a separate branch
> (soc, most likely) it would also set up a dependency on that branch.
> And to be honest, I have enough branch dependencies already.

Fair enough.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

for 01/13 then. All that is missing is a resubmission of 06/13.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support
  2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
                   ` (5 preceding siblings ...)
  2013-03-27 14:12 ` Laurent Pinchart
@ 2013-03-28  0:54 ` Simon Horman
  6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-03-28  0:54 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 27, 2013 at 03:12:20PM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday 27 March 2013 21:21:57 Simon Horman wrote:
> > On Wed, Mar 27, 2013 at 09:36:39AM +0100, Laurent Pinchart wrote:
> > > On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
> > > > On Tue, Mar 26, 2013 at 10:49:39PM +0900, Magnus Damm wrote:
> > > > > sh-pfc: Initial r8a73a4 PFC support (V2)
> > > > > 
> > > > > [PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
> > > > > [PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers
> > > > > [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
> > > > > [PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support
> > > > > [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions
> > > > > [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions
> > > > > [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS
> > > > > [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS
> > > > > [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs
> > > > > [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs
> > > > > [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
> > > > > [PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums
> > > > > [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data
> > > > > 
> > > > > This series is V2 of initial PFC support for the r8a73a4 SoC.
> > > > > The patches add a regular old-style GPIO function controller
> > > > > and makes it partially converted over to PINCTRL for SCIF
> > > > > and IRQC that are tied up on the APE6EVM board. The final
> > > > > patches remove the GPIO function support, so when new drivers
> > > > > for r8a73a4 are added then PINCTRL support has to be included.
> > > > 
> > > > Hi Magnus,
> > > > 
> > > > I apologise if the information is obvious or available elsewhere, but
> > > > could
> > > > you let me know a bit about the dependencies for this series.
> > > > 
> > > > I am assuming it depends on:
> > > > 
> > > > [PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support
> > > > [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779
> > > > 
> > > > Laurent, if/when this series is ready do you want to take it or should I
> > > > add it to my tree directly?
> > > 
> > > You can add it to your tree directly when it will be ready. I've acked all
> > > but patches 01/13 and 06/13.
> > 
> > Got it. I will hold off for now.
> > 
> > > I expect Magnus to resubmit 06/13, could you please
> > > have a look at my comments on the cover letter and tell whether 01/13
> > > should be split in a arch/arm/ patch and a drivers/ patch or if that's
> > > unnecessary from the ARM tree point of view ?
> > 
> > Unfortunately I seem to be missing the email with your comments
> > but I think that it is not strictly necessary to split the patch.
> > Although doing so would allow it to be applied to a separate branch
> > (soc, most likely) it would also set up a dependency on that branch.
> > And to be honest, I have enough branch dependencies already.
> 
> Fair enough.

After all that it seems that there are dependencies in the pinmux branch
for a patch by bastian "ARM: shmobile: r8a7740: Migrate from INTC to GIC".
But I am still happy for 01/13 to go into pinmux as-is.

> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> for 01/13 then. All that is missing is a resubmission of 06/13.
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-03-28  0:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-26 13:49 [PATCH 00/13 v2] sh-pfc: Initial r8a73a4 PFC support Magnus Damm
2013-03-27  4:56 ` Simon Horman
2013-03-27  8:36 ` Laurent Pinchart
2013-03-27  8:48 ` Magnus Damm
2013-03-27 12:15 ` Simon Horman
2013-03-27 12:21 ` Simon Horman
2013-03-27 14:12 ` Laurent Pinchart
2013-03-28  0:54 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.