Re: FAILED: patch "[PATCH] xen/blkback: correctly respond to unknown, non-native" failed to apply to 3.0-stable tree

Re: FAILED: patch "[PATCH] xen/blkback: correctly respond to unknown, non-native" failed to apply to 3.0-stable tree

[David Vrabel]

On 01/04/13 22:23, gregkh@linuxfoundation.org wrote:
> 
> The patch below does not apply to the 3.0-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.

This is non-trivial backport as it depends on some structure changes
from b3cb0d6adc4b (xen-blkback: Implement discard requests
('feature-discard') added to 3.2.

I don't think there will be many people running 3.0.y as a dom0 kernel
so backporting this to 3.0 is not necessary.

David

> ------------------ original commit in Linus's tree ------------------
> 
> From 0e367ae46503cfe7791460c8ba8434a5d60b2bd5 Mon Sep 17 00:00:00 2001
> From: David Vrabel <david.vrabel@citrix.com>
> Date: Thu, 7 Mar 2013 17:32:01 +0000
> Subject: [PATCH] xen/blkback: correctly respond to unknown, non-native
>  requests
> 
> If the frontend is using a non-native protocol (e.g., a 64-bit
> frontend with a 32-bit backend) and it sent an unrecognized request,
> the request was not translated and the response would have the
> incorrect ID.  This may cause the frontend driver to behave
> incorrectly or crash.
> 
> Since the ID field in the request is always in the same place,
> regardless of the request type we can get the correct ID and make a
> valid response (which will report BLKIF_RSP_EOPNOTSUPP).
> 
> This bug affected 64-bit SLES 11 guests when using a 32-bit backend.
> This guest does a BLKIF_OP_RESERVED_1 (BLKIF_OP_PACKET in the SLES
> source) and would crash in blkif_int() as the ID in the response would
> be invalid.
> 
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Re: FAILED: patch "[PATCH] xen/blkback: correctly respond to unknown, non-native" failed to apply to 3.0-stable tree

[gregkh]

On Tue, Apr 02, 2013 at 11:44:58AM +0100, David Vrabel wrote:
> On 01/04/13 22:23, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 3.0-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> 
> This is non-trivial backport as it depends on some structure changes
> from b3cb0d6adc4b (xen-blkback: Implement discard requests
> ('feature-discard') added to 3.2.
> 
> I don't think there will be many people running 3.0.y as a dom0 kernel
> so backporting this to 3.0 is not necessary.

Ok, thanks for letting me know.

greg k-h