[lm-sensors] Nuvoton NCT5572D incorrectly detected as NCT6775F

[lm-sensors] Nuvoton NCT5572D incorrectly detected as NCT6775F

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]

(please CC me as I am not subscribed)


Dear Linux hwmon folks,


lately I was fooled to think my board ASRock E350M1 has a Nuvoton 6775F.

                w83627ehf: Found NCT6775F chip at 0x290

Then I was pointed out that it actually has a Nuvoton NCT 5572D and
looking at the board, this is actually written on the chip. Searching
for that on the Web this was confirmed too [1][2][3].

Should the Linux message be changed to the following?

        w83627ehf: Found NCT6775F (or NCT5572D) chip at 0x290

Is it planned to add support for that the NCT5572D?


Thanks,

Paul


[1] http://review.coreboot.org/gitweb?p=coreboot.git;a=commit;h=63896e75b42697a8898c0386c492091318cf5c82
[2] http://www.spinics.net/lists/lm-sensors/msg32057.html
[3] http://www.coreboot.org/pipermail/coreboot/2013-April/075596.html

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Nuvoton NCT5572D incorrectly detected as NCT6775F

[Guenter Roeck]

On Tue, Apr 02, 2013 at 11:24:26AM +0200, Paul Menzel wrote:
> (please CC me as I am not subscribed)
> 
> 
> Dear Linux hwmon folks,
> 
> 
> lately I was fooled to think my board ASRock E350M1 has a Nuvoton 6775F.
> 
>                 w83627ehf: Found NCT6775F chip at 0x290
> 
> Then I was pointed out that it actually has a Nuvoton NCT 5572D and
> looking at the board, this is actually written on the chip. Searching
> for that on the Web this was confirmed too [1][2][3].
> 
> Should the Linux message be changed to the following?
> 
>         w83627ehf: Found NCT6775F (or NCT5572D) chip at 0x290
> 
> Is it planned to add support for that the NCT5572D?
> 
I don't think so. Many of the superio chips have different labels - we would
end up spending a lot of time trying to keep the labels up to date.
Besides, that chip can also be labeled as NCT6772F or NCT6771F.
So it should read

    w83627ehf: Found NCT6775F, or NCT6771F, or NCT6772F, or NCT5572D chip at 0x290

which would get a bit awkward. And then there is its original name, W83677HG-I,
which we would presumably have to add as well.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Nuvoton NCT5572D incorrectly detected as NCT6775F

[Jean Delvare]

On Tue, 2 Apr 2013 06:05:10 -0700, Guenter Roeck wrote:
> On Tue, Apr 02, 2013 at 11:24:26AM +0200, Paul Menzel wrote:
> > (please CC me as I am not subscribed)
> > 
> > 
> > Dear Linux hwmon folks,
> > 
> > 
> > lately I was fooled to think my board ASRock E350M1 has a Nuvoton 6775F.
> > 
> >                 w83627ehf: Found NCT6775F chip at 0x290
> > 
> > Then I was pointed out that it actually has a Nuvoton NCT 5572D and
> > looking at the board, this is actually written on the chip. Searching
> > for that on the Web this was confirmed too [1][2][3].
> > 
> > Should the Linux message be changed to the following?
> > 
> >         w83627ehf: Found NCT6775F (or NCT5572D) chip at 0x290
> > 
> > Is it planned to add support for that the NCT5572D?
> > 
> I don't think so. Many of the superio chips have different labels - we would
> end up spending a lot of time trying to keep the labels up to date.
> Besides, that chip can also be labeled as NCT6772F or NCT6771F.
> So it should read
> 
>     w83627ehf: Found NCT6775F, or NCT6771F, or NCT6772F, or NCT5572D chip at 0x290
> 
> which would get a bit awkward. And then there is its original name, W83677HG-I,
> which we would presumably have to add as well.

"NCT6775F or compatible" is one way to name it, that would make
everyone happy I think.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Nuvoton NCT5572D incorrectly detected as NCT6775F

[Guenter Roeck]

On Tue, Apr 02, 2013 at 04:22:48PM +0200, Jean Delvare wrote:
> On Tue, 2 Apr 2013 06:05:10 -0700, Guenter Roeck wrote:
> > On Tue, Apr 02, 2013 at 11:24:26AM +0200, Paul Menzel wrote:
> > > (please CC me as I am not subscribed)
> > > 
> > > 
> > > Dear Linux hwmon folks,
> > > 
> > > 
> > > lately I was fooled to think my board ASRock E350M1 has a Nuvoton 6775F.
> > > 
> > >                 w83627ehf: Found NCT6775F chip at 0x290
> > > 
> > > Then I was pointed out that it actually has a Nuvoton NCT 5572D and
> > > looking at the board, this is actually written on the chip. Searching
> > > for that on the Web this was confirmed too [1][2][3].
> > > 
> > > Should the Linux message be changed to the following?
> > > 
> > >         w83627ehf: Found NCT6775F (or NCT5572D) chip at 0x290
> > > 
> > > Is it planned to add support for that the NCT5572D?
> > > 
> > I don't think so. Many of the superio chips have different labels - we would
> > end up spending a lot of time trying to keep the labels up to date.
> > Besides, that chip can also be labeled as NCT6772F or NCT6771F.
> > So it should read
> > 
> >     w83627ehf: Found NCT6775F, or NCT6771F, or NCT6772F, or NCT5572D chip at 0x290
> > 
> > which would get a bit awkward. And then there is its original name, W83677HG-I,
> > which we would presumably have to add as well.
> 
> "NCT6775F or compatible" is one way to name it, that would make
> everyone happy I think.
> 
Ok, I'll add something like that to the nct6775 driver. Turns out the other
supported chips (NCT6776, NCT6779) have similar variants, so "or compatible"
applies to all those chips. One interesting detail is that the variants
support fewer sensors/fans according to the data sheets, but there is no way
to distinguish the chips from each other.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors