* [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
@ 2013-04-02 9:30 Jonghwan Choi
2013-04-02 18:44 ` Greg KH
2013-04-02 20:02 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Jonghwan Choi @ 2013-04-02 9:30 UTC (permalink / raw)
To: linux-kernel
Cc: stable, 'Liam Girdwood', 'Mark Brown',
'Russ Dill'
3.8-stable review patch. If anyone has any objections, please let us know.
------------------
From: "Russ Dill <Russ.Dill@ti.com>"
commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
commit dd8004af: 'regulator: core: Log when a device causes a voltage
constraint fail', tried to print out some information about the
check consumer min/max uV fixup, however, it uses a garbage pointer
left over from list_for_each_entry leading to boot messages in the
form:
'[ 2.079890] <RANDOM ASCII>: Restricting voltage,
3735899821-4294967295uV'
Because it references regulator->dev, it could potentially read memory from
anywhere causing a panic.
This patch instead uses rdev and the updated min/max uV values.
Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 2785843..5a0f54a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -200,8 +200,8 @@ static int regulator_check_consumers(struct
regulator_dev *rdev,
}
if (*min_uV > *max_uV) {
- dev_err(regulator->dev, "Restricting voltage, %u-%uuV\n",
- regulator->min_uV, regulator->max_uV);
+ rdev_err(rdev, "Restricting voltage, %u-%uuV\n",
+ *min_uV, *max_uV);
return -EINVAL;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
2013-04-02 9:30 [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage Jonghwan Choi
@ 2013-04-02 18:44 ` Greg KH
2013-04-02 20:02 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2013-04-02 18:44 UTC (permalink / raw)
To: Jonghwan Choi
Cc: linux-kernel, stable, 'Liam Girdwood',
'Mark Brown', 'Russ Dill'
On Tue, Apr 02, 2013 at 06:30:42PM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch. If anyone has any objections, please let us know.
Who is "us"? :)
It's a bit nicer to say, "This patch looks like it should be in the
3.8-stable tree, should we apply it?"
That way, the default, if no one replies, is that the patch is not
applied (safer), not that it will be applied. I need/require that the
authors/maintainers agree that any patch they don't explicitly mark for
the stable tree, yet people think it should be, to be acknowledged by
them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
2013-04-02 9:30 [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage Jonghwan Choi
2013-04-02 18:44 ` Greg KH
@ 2013-04-02 20:02 ` Greg KH
2013-04-02 20:39 ` Russ Dill
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2013-04-02 20:02 UTC (permalink / raw)
To: Jonghwan Choi
Cc: linux-kernel, stable, 'Liam Girdwood',
'Mark Brown', 'Russ Dill'
On Tue, Apr 02, 2013 at 06:30:42PM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: "Russ Dill <Russ.Dill@ti.com>"
>
> commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
Wait, no, this is NOT the commit id of this patch, please don't get this
wrong.
I've dropped this from my stable mbox, if Russ feels this should go to
3.8-stable, please send me the correct git id of the patch to apply.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
2013-04-02 20:02 ` Greg KH
@ 2013-04-02 20:39 ` Russ Dill
2013-04-02 20:54 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Russ Dill @ 2013-04-02 20:39 UTC (permalink / raw)
To: Greg KH; +Cc: Jonghwan Choi, linux-kernel, stable, 'Mark Brown'
On 04/02/2013 01:02 PM, Greg KH wrote:
> On Tue, Apr 02, 2013 at 06:30:42PM +0900, Jonghwan Choi wrote:
>> 3.8-stable review patch. If anyone has any objections, please let us know.
>>
>> ------------------
>>
>> From: "Russ Dill <Russ.Dill@ti.com>"
>>
>> commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
>
> Wait, no, this is NOT the commit id of this patch, please don't get this
> wrong.
>
> I've dropped this from my stable mbox, if Russ feels this should go to
> 3.8-stable, please send me the correct git id of the patch to apply.
9c7b4e8a8ad2624106fbf690fa97ab9c8c9bfa88 is the proper upstream commit.
This fixes a potential oops that was added in 3.8-rc4, and fixed
upstream in 3.9-rc1. I do think it belongs in stable.
Too bad I can't muck up the commit, then I'd owe you a beer. Might help
that shoulder of yours.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
2013-04-02 20:39 ` Russ Dill
@ 2013-04-02 20:54 ` Greg KH
2013-04-02 23:32 ` Jonghwan Choi
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2013-04-02 20:54 UTC (permalink / raw)
To: Russ Dill; +Cc: Jonghwan Choi, linux-kernel, stable, 'Mark Brown'
On Tue, Apr 02, 2013 at 01:39:06PM -0700, Russ Dill wrote:
> On 04/02/2013 01:02 PM, Greg KH wrote:
> > On Tue, Apr 02, 2013 at 06:30:42PM +0900, Jonghwan Choi wrote:
> >> 3.8-stable review patch. If anyone has any objections, please let us know.
> >>
> >> ------------------
> >>
> >> From: "Russ Dill <Russ.Dill@ti.com>"
> >>
> >> commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
> >
> > Wait, no, this is NOT the commit id of this patch, please don't get this
> > wrong.
> >
> > I've dropped this from my stable mbox, if Russ feels this should go to
> > 3.8-stable, please send me the correct git id of the patch to apply.
>
> 9c7b4e8a8ad2624106fbf690fa97ab9c8c9bfa88 is the proper upstream commit.
> This fixes a potential oops that was added in 3.8-rc4, and fixed
> upstream in 3.9-rc1. I do think it belongs in stable.
Thanks, I've applied that commit now.
> Too bad I can't muck up the commit, then I'd owe you a beer. Might help
> that shoulder of yours.
Yes, that would help it out, but probably not help me catch up with
pending patches to apply :)
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage
2013-04-02 20:54 ` Greg KH
@ 2013-04-02 23:32 ` Jonghwan Choi
0 siblings, 0 replies; 6+ messages in thread
From: Jonghwan Choi @ 2013-04-02 23:32 UTC (permalink / raw)
To: 'Greg KH', 'Russ Dill'
Cc: linux-kernel, stable, 'Mark Brown'
Dear all.
> > >> ------------------
> > >>
> > >> From: "Russ Dill <Russ.Dill@ti.com>"
> > >>
> > >> commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
> > >
> > > Wait, no, this is NOT the commit id of this patch, please don't get
> this
> > > wrong.
> > >
> > > I've dropped this from my stable mbox, if Russ feels this should go to
> > > 3.8-stable, please send me the correct git id of the patch to apply.
> >
> > 9c7b4e8a8ad2624106fbf690fa97ab9c8c9bfa88 is the proper upstream commit.
> > This fixes a potential oops that was added in 3.8-rc4, and fixed
> > upstream in 3.9-rc1. I do think it belongs in stable.
>
-> This is my fault. I will be more careful from now on
Thanks.
Best regards.
> -----Original Message-----
> From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org]
> On Behalf Of Greg KH
> Sent: Wednesday, April 03, 2013 5:55 AM
> To: Russ Dill
> Cc: Jonghwan Choi; linux-kernel@vger.kernel.org; stable@vger.kernel.org;
> 'Mark Brown'
> Subject: Re: [PATCH 3.8-stable] regulator: core: Log when a device causes
> a voltage
>
> On Tue, Apr 02, 2013 at 01:39:06PM -0700, Russ Dill wrote:
> > On 04/02/2013 01:02 PM, Greg KH wrote:
> > > On Tue, Apr 02, 2013 at 06:30:42PM +0900, Jonghwan Choi wrote:
> > >> 3.8-stable review patch. If anyone has any objections, please let us
> know.
> > >>
> > >> ------------------
> > >>
> > >> From: "Russ Dill <Russ.Dill@ti.com>"
> > >>
> > >> commit 6e45eb12fd1c741d556bf264ee98853b5f3104e5 upstream.
> > >
> > > Wait, no, this is NOT the commit id of this patch, please don't get
> this
> > > wrong.
> > >
> > > I've dropped this from my stable mbox, if Russ feels this should go to
> > > 3.8-stable, please send me the correct git id of the patch to apply.
> >
> > 9c7b4e8a8ad2624106fbf690fa97ab9c8c9bfa88 is the proper upstream commit.
> > This fixes a potential oops that was added in 3.8-rc4, and fixed
> > upstream in 3.9-rc1. I do think it belongs in stable.
>
> Thanks, I've applied that commit now.
>
> > Too bad I can't muck up the commit, then I'd owe you a beer. Might help
> > that shoulder of yours.
>
> Yes, that would help it out, but probably not help me catch up with
> pending patches to apply :)
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-02 23:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-02 9:30 [PATCH 3.8-stable] regulator: core: Log when a device causes a voltage Jonghwan Choi
2013-04-02 18:44 ` Greg KH
2013-04-02 20:02 ` Greg KH
2013-04-02 20:39 ` Russ Dill
2013-04-02 20:54 ` Greg KH
2013-04-02 23:32 ` Jonghwan Choi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.